Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61141C7618B for ; Tue, 14 Mar 2023 07:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbjCNH5t (ORCPT ); Tue, 14 Mar 2023 03:57:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbjCNH5r (ORCPT ); Tue, 14 Mar 2023 03:57:47 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A089211D9; Tue, 14 Mar 2023 00:57:45 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4461B1C000A; Tue, 14 Mar 2023 07:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678780664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rV/48DFH0VRtT8styWUtBxfjMGT8+CfYXF8J4C5hkDc=; b=RG3+iLr/iC05m99Svg5Uu2IkjXiuvdGWcpm6yDSeZEWm+E5c0c3WUExdpe20VHpuyw7oRp sR1TnJ7M9s9WS9jFpzOPPVfWvKEHVUaZefl982MrSxEHgN/noBm3HP/EKnAzwXK13/YiD9 htDf5t1pzBEvhdUHYJJWYl+7x/8c2A6+ouv9VE2jFcdR8IrigfdrlZA5DuLECwtItfy6P9 LqJC9W/6/pl9gV4fUjwbS9UV4zalfIHL3C4uMBN2hRcsBoj7+M4Ijl37sIkodESZtuHfHH xQZ4joqYKs6UefCIYMfSwyBVPTrLf5TvciPH8/oHYpCcqtkroJROuF++5bmMww== Date: Tue, 14 Mar 2023 08:57:41 +0100 From: Herve Codina To: Lukas Bulwahn Cc: Li Yang , Christophe Leroy , Mark Brown , Qiang Zhao , linuxppc-dev , Linux ARM , Linux Kernel Mailing List , kernel-janitors Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC Message-ID: <20230314085741.6f968e68@bootlin.com> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukas, On Tue, 14 Mar 2023 08:21:50 +0100 Lukas Bulwahn wrote: > Dear Herve, >=20 > In your patch below, you added the config CPM_QMC which depends on the > non-existing config SOC_FSL: >=20 > https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@bootlin.c= om >=20 > Up to my knowledge, the config SOC_FSL never existed in the mainline > tree. Is this dependency really required or can the expression simply > be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL? >=20 > Note: This patch has now shown up in linux-next with commit > 3178d58e0b97. Currently, it would not be possible to compile test this > driver, as the dependency on SOC_FSL is never met. >=20 >=20 > Best regards, >=20 > Lukas My bad :( The dependency must be FSL_SOC instead of SOC_FSL. I mean: diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig index f90cfdf0c763..7268c2fbcbc1 100644 --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -47,7 +47,7 @@ config CPM_TSA config CPM_QMC tristate "CPM QMC support" depends on OF && HAS_IOMEM - depends on CPM1 || (SOC_FSL && COMPILE_TEST) + depends on CPM1 || (FSL_SOC && COMPILE_TEST) depends on CPM_TSA help Freescale CPM QUICC Multichannel Controller --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com