Date:   Tue, 14 Mar 2023 09:20:42 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Serge Semin <Sergey.Semin@baikalelectronics.ru>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "Andrew Lunn" <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Qing Zhang <zhangqing@loongson.cn>,
        Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Biao Huang <biao.huang@mediatek.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 13/13] net: dwmac-loongson: Perceive zero IRQ as
 invalid
Message-ID: <ZBAuWk9lnGjeuvKC@nimitz>
References: <20230313224237.28757-1-Sergey.Semin@baikalelectronics.ru>
 <20230313224237.28757-14-Sergey.Semin@baikalelectronics.ru>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230313224237.28757-14-Sergey.Semin@baikalelectronics.ru>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fcEPFjxYvPiUrW7UnE7Q0suGhI5X1FbV7iALsjlxUk5reAoKBgZCCCnDQtwK?=
 =?us-ascii?Q?wSiei0BDnpVQ/X+KNd6cbXzDhjKdrTgC6nWmJ0/iAD5DWaViVdOPY+jJPaYw?=
 =?us-ascii?Q?BtZCJIBWgx6hMUMSPPp2wofsrLzlyZIuUzmBqsSNdigIGWwA32lrxNNEiIC8?=
 =?us-ascii?Q?xaetEiTWjzWMIC0z0hE8aeQ6W5E3oKn5vdmGjT/gE7k4GtzGGSxzxIJ/SCz+?=
 =?us-ascii?Q?nKfzuAVEeDQVphQWnD6KWvcqoTAFQ5X8IybvdwLQruJxPjEWTPABigizWnBi?=
 =?us-ascii?Q?OpsC9bpuo1bjWJkmVc5LDC66V95c7ehIyy+LVrVsnmpuDlHX+hHjSVZzv9HC?=
 =?us-ascii?Q?kLEzJCr8P9ImB7Izl10q7nTkDZLiaTKqBsoY2ulq5yrJdY1oe8jqwtU69zA6?=
 =?us-ascii?Q?XgM4PZPkpz+4vTcvU2/6uoV1HU8ion+k+FvfAE/RUnNuJPYgx+gmfB88NVbm?=
 =?us-ascii?Q?4K0nuoSgZ8Prz6paJmoL+k2c569UUEwqMBpib8K5YI1f9ZZK2uDSkQUJZUMD?=
 =?us-ascii?Q?ibXnwPsC6HcZG4Rz3FQBtNnzOj13Nqn+sy7QhDeV9ez2jQJoh97SGXWfQre/?=
 =?us-ascii?Q?G7RbrUo+LLcD/rfmLe1fyxqIbGNvzYZ1StrHQ/D0a1wAHlKXwyAqSYVkB9pX?=
 =?us-ascii?Q?5RLC7loQPd9275OEibYZ5mORyWLl6YoXQ8I9m1VNgm1by6Yt+jkP2vSfgkUZ?=
 =?us-ascii?Q?MRpXLW2A2JPctHSDS1ojvhTvInI7j9ps6++fWEtS+t6BQ4DeEYEfQefbvRei?=
 =?us-ascii?Q?hD+wcKoSSxja97184a/TEMQTghfSkueknGNhjAaRSu/ZNDpAvG8ZbKXFcXbI?=
 =?us-ascii?Q?nfcyAe/y3xevu5dD6lc3YP/kv7yBuOc8Sn1QPOvQuIzNI3FbKgQY4fIA0ynA?=
 =?us-ascii?Q?4Jh+v8XkfnPqd7BihAo3uItuzrlHgvxu7KQ6gmFVDihJHWeLYHL4oF8zYjKZ?=
 =?us-ascii?Q?egquvNBnLohiAQGpXMnWgTkPc7YHtTB129448t+wkRRubpwzFxJAYcOUdfjG?=
 =?us-ascii?Q?m7L9fY25bUYx1wxkER9Ilt/8w4CKudordU2eCJFqnNRoS1Cq2KEmSG2s8YFH?=
 =?us-ascii?Q?cTiemQJUfCrE+Vrkn6AiuURFX8t3ffyXTXTMbMCk45N9bHkS04p75YsG4U7T?=
 =?us-ascii?Q?3+6dTcDwKra22aNpYIlJITX3rHNIwoOjKPhVAy6vSnhxaAHQZE+hTNmB/Hpn?=
 =?us-ascii?Q?/NMkvTixnUhTLKNjHyeqbwe73N5xk9U7Ryn5QZFb35dKcvRYTOy+Zpq98v7Q?=
 =?us-ascii?Q?r2x4Hl/xwxWOWVzmx8eVQi30ygVeFDiIrtVFsy+CPvB++dikfwAoTzztky+K?=
 =?us-ascii?Q?OnwCZwvafB5iOr1pzxhXoueqjwySUOlocYLI6AKJGvmrZ2Z1+EBxu2y8SFcK?=
 =?us-ascii?Q?w74CDISTzdQMDT3V9Tfmcc2Gl+k/F/EhXEWs99IS/kOUSC+hhPqPK/AaEbxy?=
 =?us-ascii?Q?u8qoyUlcMkUeLCG6jQ4AtVcJDGa9jWNmJlfJn/b6oYD0UgcL3ejU1MTuBks5?=
 =?us-ascii?Q?LSMv3+ppT6qO4t9yjAVgMR3Zt+cbrKoeAWMDXXfDI0DnE9GY6uaW+JTcyg+H?=
 =?us-ascii?Q?1U7m+LsnaeWke3oUZKcrbnQC7hKf4Sc5tWuyt1DSFw/JKNefqKZWHqyDlQ45?=
 =?us-ascii?Q?Iw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3926236a-d598-4351-73d1-08db246507c3
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 08:20:54.5478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0efHE1Co6iblDjDPAYs1dIJJ+GdDt1bxbkIz+LzjpeJSTpyblRv1oqDJv2rU9dgB+r2O/9fYmrCAfy+qutRvKT+u8hn3EXhx5PmSFEG+05Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5345
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 01:42:37AM +0300, Serge Semin wrote:
> Linux kernel defines zero IRQ number as invalid in case if IRQ couldn't be
> mapped. Fix that for Loongson PCI MAC specific IRQs request procedure.
> 

Looks a little odd but as I also checked and kernel does seem to treat
zero as mapping failure instead of -WHATEVER.

Fix looks fine.

Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>

> Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> index a25c187d3185..907bdfcc07e9 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> @@ -127,20 +127,20 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>  	res.addr = pcim_iomap_table(pdev)[0];
>  
>  	res.irq = of_irq_get_byname(np, "macirq");
> -	if (res.irq < 0) {
> +	if (res.irq <= 0) {
>  		dev_err(&pdev->dev, "IRQ macirq not found\n");
>  		ret = -ENODEV;
>  		goto err_disable_msi;
>  	}
>  
>  	res.wol_irq = of_irq_get_byname(np, "eth_wake_irq");
> -	if (res.wol_irq < 0) {
> +	if (res.wol_irq <= 0) {
>  		dev_info(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
>  		res.wol_irq = res.irq;
>  	}
>  
>  	res.lpi_irq = of_irq_get_byname(np, "eth_lpi");
> -	if (res.lpi_irq < 0) {
> +	if (res.lpi_irq <= 0) {
>  		dev_err(&pdev->dev, "IRQ eth_lpi not found\n");
>  		ret = -ENODEV;
>  		goto err_disable_msi;
> -- 
> 2.39.2
> 
>