Date:   Tue, 14 Mar 2023 10:36:57 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     "Ye, Xiang" <xiang.ye@intel.com>
Cc:     Lee Jones <lee@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org,
        srinivas.pandruvada@intel.com, andriy.shevchenko@linux.intel.com,
        sakari.ailus@linux.intel.com, zhifeng.wang@intel.com,
        wentong.wu@intel.com, lixu.zhang@intel.com
Subject: Re: [PATCH v5 1/5] usb: Add support for Intel LJCA device
Message-ID: <ZBAyKQwnQ8fxHRuU@kuha.fi.intel.com>
References: <20230312190435.3568212-1-xiang.ye@intel.com>
 <20230312190435.3568212-2-xiang.ye@intel.com>
 <20230313170341.GV9667@google.com>
 <ZBAqTqZEDz/vAwVC@ye-NUC7i7DNHE>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZBAqTqZEDz/vAwVC@ye-NUC7i7DNHE>
Precedence: bulk

Hi Xiang,

On Tue, Mar 14, 2023 at 04:03:26PM +0800, Ye, Xiang wrote:
> > Please don't use the MFD API outside of drivers/mfd.
> > 
> > If you wish to use the API, please do.
> > 
> > Strip out (only) the MFD parts and move them into drivers/mfd.
> I have no idea about how to split MFD parts out from this driver
> currently. The MFD part just have mfd cells filling and the call
> mfd_add_hotplug_devices to register mfd devices. How to module them
> as an independent driver?
> Would you give some hints or recommendations?
> 
> And I am a little comfused about where this USB device driver should
> be put to (drivers/mfd or drivers/usb).
> 
> As far as I know, where a driver should be put is based on what
> it provides. This driver just do some urb package transfer to provides
> multi-functions, such as GPIO function, I2C function, SPI function.
> so it should be under drivers/mfd folder. Please correct me, if
> something is wrong. Thanks

You don't really seem to get any benefit from MFD. Perhaps it would be
more appropriate and clear if you just registered auxiliary devices in
this driver. Check drivers/base/auxiliary.c.

thanks,

-- 
heikki