Date:   Tue, 14 Mar 2023 09:38:43 +0100
From:   Christian Brauner <brauner@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Anjali Kulkarni <anjali.k.kulkarni@oracle.com>,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        zbr@ioremap.net, johannes@sipsolutions.net, ecree.xilinx@gmail.com,
        leon@kernel.org, keescook@chromium.org, socketcan@hartkopp.net,
        petrm@nvidia.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v1 2/5] connector/cn_proc: Add filtering to fix some bugs
Message-ID: <20230314083843.wb3xmzboejxfg73b@wittgenstein>
References: <20230310221547.3656194-1-anjali.k.kulkarni@oracle.com>
 <20230310221547.3656194-3-anjali.k.kulkarni@oracle.com>
 <20230313172441.480c9ec7@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230313172441.480c9ec7@kernel.org>
Precedence: bulk

On Mon, Mar 13, 2023 at 05:24:41PM -0700, Jakub Kicinski wrote:
> On Fri, 10 Mar 2023 14:15:44 -0800 Anjali Kulkarni wrote:
> > diff --git a/include/linux/connector.h b/include/linux/connector.h
> > index 487350bb19c3..1336a5e7dd2f 100644
> > --- a/include/linux/connector.h
> > +++ b/include/linux/connector.h
> > @@ -96,7 +96,11 @@ void cn_del_callback(const struct cb_id *id);
> >   *
> >   * If there are no listeners for given group %-ESRCH can be returned.
> >   */
> > -int cn_netlink_send_mult(struct cn_msg *msg, u16 len, u32 portid, u32 group, gfp_t gfp_mask);
> > +int cn_netlink_send_mult(struct cn_msg *msg, u16 len, u32 portid,
> > +			 u32 group, gfp_t gfp_mask,
> > +			 int (*filter)(struct sock *dsk, struct sk_buff *skb,
> > +				       void *data),
> > +			 void *filter_data);
> 
> kdoc needs to be extended

just a thought from my side. I think giving access to unprivileged users
will require a little thought as that's potentially sensitive.

If possible I would think that the patches that don't lead to a
behavioral change should go in completely independently and then we can
discuss the non-root access change.