Date:   Tue, 14 Mar 2023 09:39:25 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Ong Boon Leong <boon.leong.ong@intel.com>,
        <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        "Looi Hong Aun" <hong.aun.looi@intel.com>,
        Voon Weifeng <weifeng.voon@intel.com>,
        Lai Peter Jun Ann <peter.jun.ann.lai@intel.com>
Subject: Re: [PATCH net 1/2] net: stmmac: fix PHY handle parsing
Message-ID: <ZBAyvXhvXPsQ8WrT@nimitz>
References: <20230313080135.2952774-1-michael.wei.hong.sit@intel.com>
 <20230313080135.2952774-2-michael.wei.hong.sit@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230313080135.2952774-2-michael.wei.hong.sit@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zis8dv+pE5+Nfv7XxVxa1S3yFdqEcj6Wp21wKan+HLQXZFKcBYoT9yt4//3I?=
 =?us-ascii?Q?4SDGWi4RzbvAtog5SIDGyvGg/6e+A/onYg8Zm6mYqo7nLZzke5T7WxU8dfwe?=
 =?us-ascii?Q?T/XvnATNHxoSVV7eb2/T3E2phCIzqFZVo6RWI13BVPd+/x6bC1C/gjhWIK1H?=
 =?us-ascii?Q?foAK9zmHMOdLRLBaMXd+Uq8IBeh3nbohcINYT1FGCdjf+KH21Br4TcoQ1ThD?=
 =?us-ascii?Q?zB5fP6kwqlZBZTjhLOaVlwkHVUrcE8mgXuvHgYMKiqBDSHJUghiDM46ThxRi?=
 =?us-ascii?Q?4RFzB2c8jugr0IHzOKfR7cE70Rs9ymqZ9T2H4QXtsHBjxNkiOsjhUZNaz7EB?=
 =?us-ascii?Q?vKwmlEFgffqnUnZufclH2AYupuscMoGKu/O1sGkg6xA96kDtFc36DB/KShca?=
 =?us-ascii?Q?3AbNdjE5Z2PMxHmxv9u/VlJ6mA9RSjeMEAmV6zpP7aSGTFjk43sOo1ureNjL?=
 =?us-ascii?Q?msfVdAG22RbYLZsEF1qCpLdG7Vso+QmoCgg69XTPDiGJg5gPuFXWDWlqTdkd?=
 =?us-ascii?Q?V+k+B5NnsgL06Je2X2BDbqaJdJv8fGXnJwXRdrE05KloN1OBwKV/pO4mRQy6?=
 =?us-ascii?Q?gNyHN+UMmq7Gicnasfkarie0AeIn5KWnG9aGO01RyyZl/BaJnvGlytPVAXOc?=
 =?us-ascii?Q?Dke/lPs2BmTW5Nf//YMxY2em+OGVRw4pJIrESfYY1FvHrcphkW2gCQbQt3U6?=
 =?us-ascii?Q?ekKmIjPRsjUga5NHJ0IwfwnVmWaPkBtFU0mNh9qRglrv/5GFgSB1tbNm+zpN?=
 =?us-ascii?Q?U/Y3TDuWzl9B6VeLMcYvKeH7WxkrZdNTNneZKWbPZLQve8SQ/1dncRLSZBWR?=
 =?us-ascii?Q?877Cq2FxwgzxDf7MAjZtwOPYnE07QKoMuGkBvF+m3LCKiQu/3M/i9/fzpHCI?=
 =?us-ascii?Q?EbaHLt49cHmApqyyQqJEgiFUezr60hZ0SyGpCBkFkiUmHOOu6xRJ/s/hw0ud?=
 =?us-ascii?Q?mvRbz3is+rwsl5QJH9hid0tvfeada41Bacl56TDoCfeEFJGK7sgrEV3yaIPj?=
 =?us-ascii?Q?Z6Ot7uA6/3IAKEKqliwQFo5t8HRWCa7mryFA6QGYsOOxjvAAdtTRd38nsdaw?=
 =?us-ascii?Q?MMerZhSuXZrziKp8+j/uUK2nQoMh4RHvN3jr9qdGISTEXxWvkYWINDKHxBZs?=
 =?us-ascii?Q?sbcRa1I4dxERXO1adtYn+jO7ZcZIZMsf1Y2VP5Vg+ncF3gL2IkNCoQrpnLvf?=
 =?us-ascii?Q?blwZI5JbjKFu1EefMZ0k1EfO7Tix1liTDAJB3Liah+U6Q8FFoEMgPVdVttTD?=
 =?us-ascii?Q?P2teQ0cRwXg8W8q75xYtb2Ss5q7yAYyvICvWYvjtVRcpMOJQ2X41uPKpYhel?=
 =?us-ascii?Q?e+joJM2I24kqwuC4BMhDzUNXDSa/hLAIe8DvHKt33HYF7zUChIIyxmmYAX1r?=
 =?us-ascii?Q?RlNwdkWhytrWijLZOEi4fdPprBIJfwnb2mfG11V/l/U0DJrhH4SA9nAFv/ZG?=
 =?us-ascii?Q?Tf8Ix4RPcVqgDCqvZrskjlOqo+WWj1/KoYHIi89PAC4IKo2tkh6rRZz+6Wbf?=
 =?us-ascii?Q?S5C9q7lgppw+4SVwuVKc23G1JHeLlmEIeAMPjY3xbuWiWzY+ffNBql7zv7/Z?=
 =?us-ascii?Q?CvbPIClGiixLhJRa16dDM5fHGTpvyIEl8V/53RIcXNUOz3L5xwXfq+CyOEgp?=
 =?us-ascii?Q?CQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b58584e-4fed-4bd9-ebef-08db2467aabb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 08:39:47.0209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I77bC2I3y5ZqyuenIRURKoXFawb6FGruV4bLu0JV2c2e+PptBRHg+ztiQ/eefxSjKXgEuP6dzss06qhYlIEoKkpS7mN/VowB9WVCEO8zO3g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5905
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 13, 2023 at 04:01:34PM +0800, Michael Sit Wei Hong wrote:
> phylink_fwnode_phy_connect returns 0 when set to MLO_AN_INBAND.
> This causes the PHY handle parsing to skip and the PHY will not be attached
> to the MAC.
> 
> Add additional check for PHY handle parsing when set to MLO_AN_INBAND.
> 
> Fixes: ab21cf920928 ("net: stmmac: make mdio register skips PHY scanning for fixed-link")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
> Signed-off-by: Lai Peter Jun Ann <peter.jun.ann.lai@intel.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 8f543c3ab5c5..398adcd68ee8 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1134,6 +1134,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)
>  static int stmmac_init_phy(struct net_device *dev)
>  {
>  	struct stmmac_priv *priv = netdev_priv(dev);
> +	struct fwnode_handle *fixed_node;
>  	struct fwnode_handle *fwnode;
>  	int ret;
>  
> @@ -1141,13 +1142,16 @@ static int stmmac_init_phy(struct net_device *dev)
>  	if (!fwnode)
>  		fwnode = dev_fwnode(priv->device);
>  
> -	if (fwnode)
> +	if (fwnode) {
> +		fixed_node = fwnode_get_named_child_node(fwnode, "fixed-link");
> +		fwnode_handle_put(fixed_node);
>  		ret = phylink_fwnode_phy_connect(priv->phylink, fwnode, 0);
> +	}
>  

On the occasion, why not rewrite above to:
if (!fwnode)
...
else
...

or:
if(fwnode)
...
else
?

>  	/* Some DT bindings do not set-up the PHY handle. Let's try to
>  	 * manually parse it
>  	 */
> -	if (!fwnode || ret) {
> +	if (!fwnode || ret || !fixed_node) {
>  		int addr = priv->plat->phy_addr;
>  		struct phy_device *phydev;
>  
> -- 
> 2.34.1
>