Date:   Tue, 14 Mar 2023 10:19:50 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     shakeelb@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] mm/oom_kill: don't kill exiting tasks in
 oom_kill_memcg_member
Message-ID: <ZBA8NlwBTprShO3e@dhcp22.suse.cz>
References: <20230314091136.264878-1-haifeng.xu@shopee.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314091136.264878-1-haifeng.xu@shopee.com>
Precedence: bulk

On Tue 14-03-23 09:11:36, Haifeng Xu wrote:
> If oom_group is set, oom_kill_process() invokes oom_kill_memcg_member()
> to kill all processes in the memcg. When scanning tasks in memcg, maybe
> the provided task is marked as oom victim. Also, some tasks are likely
> to release their address space. There is no need to kill the exiting tasks.

This doesn't state any actual problem. Could you be more specific? Is
this a bug fix, a behavior change or an optimization?
-- 
Michal Hocko
SUSE Labs