Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F98C6FD1D for ; Tue, 14 Mar 2023 10:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbjCNKDk (ORCPT ); Tue, 14 Mar 2023 06:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjCNKDe (ORCPT ); Tue, 14 Mar 2023 06:03:34 -0400 X-Greylist: delayed 434 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 14 Mar 2023 03:03:28 PDT Received: from mail.sgstbr.de (mail.sgstbr.de [IPv6:2a01:4f8:10b:1515::10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB2671EBCB; Tue, 14 Mar 2023 03:03:28 -0700 (PDT) Received: from [IPV6:2a02:810d:ab40:2500:3b46:4127:c750:bf0] (unknown [IPv6:2a02:810d:ab40:2500:3b46:4127:c750:bf0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: fabian@blaese.de) by mail.sgstbr.de (Postfix) with ESMTPSA id CD29A249440; Tue, 14 Mar 2023 10:56:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blaese.de; s=201803; t=1678787793; bh=2YHHIOnfCNb0tl9AGjKfzZ+jPiMxd5LIoKufI4ihP0c=; h=Date:Subject:To:References:From:In-Reply-To:From; b=wadZqMqq6kk9Y3Z29PL08r1mM8MJuJg10klMiJ1n0XzL6l0Zyqk9ibZ9OVjIFYZzu SUJ4nviYK36Z9U64Oxz3J84nk9EoH8BRWu6c5ePrVaVeXnd5VvSXgG8xBeOGXhY5Gj UgRbwH2mcggyFnxPc6BSL3MWGcf5kkMxAfJZSIqUidqpt21qIDeUJbZjb9OAxRmALs I7LmnONEayviRGhIepyd8MPjGDYstdAqVgmsI2micefL5No1rTR8uIDy2IBIfg0Wn7 RRzXtWfafKSXmsHhW00rnxzsVX26sc6TlfkVfbXLH2ulX29LQl8hdvPUmXP2slNABu WrB6edUDgWytw== Message-ID: Date: Tue, 14 Mar 2023 10:56:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup code Content-Language: de-DE To: Michael Sit Wei Hong , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Looi Hong Aun , Voon Weifeng , Lai Peter Jun Ann References: <20230314070208.3703963-1-michael.wei.hong.sit@intel.com> <20230314070208.3703963-3-michael.wei.hong.sit@intel.com> From: =?UTF-8?Q?Fabian_Bl=c3=a4se?= In-Reply-To: <20230314070208.3703963-3-michael.wei.hong.sit@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.23 08:02, Michael Sit Wei Hong wrote: > xpcs_an_inband value is updated in the speed_mode_2500 function > which turns on the xpcs_an_inband mode. > > Moving the fixed-link fixup code to right before phylink setup to > ensure no more fixup will affect the fixed-link mode configurations. > > Fixes: 72edaf39fc65 ("stmmac: intel: add phy-mode and fixed-link ACPI _DSD setting support") > Signed-off-by: Michael Sit Wei Hong Tested-by: Fabian Bläse