From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, mirela.rabulea@oss.nxp.com,
        hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, xiahong.bao@nxp.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 08/10] media: imx-jpeg: Clear slot next desc ptr if config error
Date:   Tue, 14 Mar 2023 18:08:51 +0800
Message-Id: <5541277a3c93fd141e35a7fef0bd87047afdb532.1678788305.git.ming.qian@nxp.com>
In-Reply-To: <cover.1678788305.git.ming.qian@nxp.com>
References: <cover.1678788305.git.ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+UaPdT+G2xzAxaWnTBztwORH0iqBvYzU+lJW/BY0HuB1KyHxq5V6rYfX1J+w?=
 =?us-ascii?Q?GWHVO3Zn+4VrXxHW4xQ5u8U0w+GA/+aSe6ZpWeLp/3ROROISbfxo8ODv87vZ?=
 =?us-ascii?Q?TtcDReFa0Fae6VwW6No3G8PfyEvUQ9ee17MDe1Oh/PFSt76ZeKTu5Uc2bDbV?=
 =?us-ascii?Q?hYBRv5EmZZkVUWJiGLKmXeYFTSOmPWVLLQx4mQS4J4+3SAv5bKzJpVq6IqI8?=
 =?us-ascii?Q?zhfn/gVHlFMeUj6Pd2BuV3U/xry/Q7yhleTeFshkkHF+jGVrIlz7ThbTC/iw?=
 =?us-ascii?Q?fQNh/UNtjUM02X+98vQXhP9nAMOCZh3fJ95zp7aIWRE+MAm4sHG/OvWxOZjL?=
 =?us-ascii?Q?Vk4z7ctrxJ43ModZQ6DD/J8SxptsJk8sd4xiPqIrLpbUIUOK/3laK88WpeJO?=
 =?us-ascii?Q?QlukHpC7eypZnHAwTeWZcH5IJEt21aSkXdrHe+sS92JeNjmnMspxDbcGN+/K?=
 =?us-ascii?Q?2d0HZLA5NbIdbvOF0E9eEXfsGri640Tg/Q/U09JU3eOG69IoZIvA15T5CELo?=
 =?us-ascii?Q?5JYHKpVIunrMlnth0gwU3ZOyOfZGcpsRVo9/bW+OmBPsfQ1V3lBs9qlYbvXg?=
 =?us-ascii?Q?JlhY09Zlr8ek8BCl+dd7HL1TiAGIzPFXUZqsZfMUtaMpOJ/X5t8URKNijXGp?=
 =?us-ascii?Q?4UI37WUalwG9UBByAALTF0uT07jdtprc0g85ruax1DpTdbipM2nZoIT4CyFg?=
 =?us-ascii?Q?F2BgOq1BDYBUiHbSVCvgbIflF3AxH2T8FX8A5fZyMXfATY5duMRC7BZx4fZ+?=
 =?us-ascii?Q?hO7VLptimL9xhC+eJM3BVTccl01K9zSKAIyFFezukqZYb/pA1troxuR3U0EL?=
 =?us-ascii?Q?2M2LpJjaL3FewWZW34PrKNtWV2IBdo14Nf2uMvCvV5axNDBqpAG3GtrYStpa?=
 =?us-ascii?Q?1V6cMmyzw874NkdWe8FK3Y2UOX5edsSeEjc5nz8kBexpPmKBrNJjSkz+SnUS?=
 =?us-ascii?Q?d74PYdzA7+BYnpJMnwi3W6psOiYvSim2kLptqCjLBa5yfGSbTaRl3K2136ge?=
 =?us-ascii?Q?8qpjkxW3eyiltS3jQqAjNTRoJLin8HQKd5GACMKHq1Dfx6OOkts+Vz+0uMA8?=
 =?us-ascii?Q?ONxifabN/CNmqKxcBh3KGQF7zNa6sjzg9L3Z7evfGKq7yEM2fTNLSAxVRFXZ?=
 =?us-ascii?Q?z8k3F/1S8RVk5BXUVd1/NY/dQVRSS/g2Vh8nkXnv58II/81QIuK/akL0Nrdb?=
 =?us-ascii?Q?SYybTqBe4s+itFNZMPCHzbhNDKYGPFM2V91pnOeJZrm3VnFZ5UYSZH15/4P0?=
 =?us-ascii?Q?GuihBkPd49xR5OuHw2ehh8JNOuXkxG2QFlGEuha4ws0axyvS9DFGOjVLcg/z?=
 =?us-ascii?Q?LWD7RaFqzjPxafHII2Dk7fdRXPNjgdjILwl/MiypA6FtoplpFq1NLhsoifcK?=
 =?us-ascii?Q?mVOTu58wtoDT/KB1SfJfMiYhhuPxEzo33/KqVPvUBsIa7wnVr0VwqyitTLM9?=
 =?us-ascii?Q?Xs8zd8O9yQ+aVJVLYeuV9QchGYpspnpoZ4bYxBrPTY8C05fRpxSDFlzJBBxm?=
 =?us-ascii?Q?NsBT+zCp21TVpoVJrr/mAmnjAwE+n3Wez0a+zddoQG00JE13bMYJK1GA07eO?=
 =?us-ascii?Q?cyMJG7BSpWyJBUYhMcEghN5Cp8NAKRy36IGtZIom?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 576f03e4-873a-454b-0ee2-08db2474575b
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 10:10:30.5479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hbjgtHp9RIJfbiun0HK5zh7nBTfaeaAmDzaq1m1luj7jIfJAidoRSZ+cExPUAMLG5yna9BApzPJWYMsQfb+lXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7841
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

clear slot next desc ptr if config error,
otherwise codec will report config error interrupt repeatedly,
it may led to system hang.

Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 5 +++++
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h | 1 +
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c    | 1 +
 3 files changed, 7 insertions(+)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
index ef28122a5ed4..bbd5d6a9fc86 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
@@ -178,3 +178,8 @@ void mxc_jpeg_set_desc(u32 desc, void __iomem *reg, int slot)
 	writel(desc | MXC_NXT_DESCPT_EN,
 	       reg + MXC_SLOT_OFFSET(slot, SLOT_NXT_DESCPT_PTR));
 }
+
+void mxc_jpeg_clr_desc(void __iomem *reg, int slot)
+{
+	writel(0, reg + MXC_SLOT_OFFSET(slot, SLOT_NXT_DESCPT_PTR));
+}
diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
index ecf3b6562ba2..8b7cd6526efd 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
@@ -137,6 +137,7 @@ void mxc_jpeg_set_bufsize(struct mxc_jpeg_desc *desc,  u32 bufsize);
 void mxc_jpeg_set_res(struct mxc_jpeg_desc *desc, u16 w, u16 h);
 void mxc_jpeg_set_line_pitch(struct mxc_jpeg_desc *desc, u32 line_pitch);
 void mxc_jpeg_set_desc(u32 desc, void __iomem *reg, int slot);
+void mxc_jpeg_clr_desc(void __iomem *reg, int slot);
 void mxc_jpeg_set_regs_from_desc(struct mxc_jpeg_desc *desc,
 				 void __iomem *reg);
 #endif
diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
index 70b6eea733e7..3f1c9bc4b144 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -692,6 +692,7 @@ static irqreturn_t mxc_jpeg_dec_irq(int irq, void *priv)
 		u32 ret = readl(reg + CAST_STATUS12);
 
 		dev_err(dev, "Encoder/decoder error, status=0x%08x", ret);
+		mxc_jpeg_clr_desc(reg, slot);
 		mxc_jpeg_sw_reset(reg);
 		buf_state = VB2_BUF_STATE_ERROR;
 		goto buffers_done;
-- 
2.38.1