Date:   Tue, 14 Mar 2023 11:35:07 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com
Subject: Re: [PATCH v10 1/3] serdev: Add method to assert break signal over
 tty UART port
Message-ID: <ZBBN2ySl/q7NGehB@corigine.com>
References: <20230313144028.3156825-1-neeraj.sanjaykale@nxp.com>
 <20230313144028.3156825-2-neeraj.sanjaykale@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230313144028.3156825-2-neeraj.sanjaykale@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tpvYrhqFVY/y7t/ah92X+iYvML9OeWf0l630pM7pWLCkguDbsdiKd3kQObYF?=
 =?us-ascii?Q?xBvDZEL8aMwsd3KQiYsjJWAcrTPQGJJCZZG6jOZ2O2YnvNn5fuJZwVhQhene?=
 =?us-ascii?Q?x/N/bjuoKq+WNIooJSB9z9BxZH+kxWHkyz5hqZqWHJlJb9vqblbXc/xz9D2f?=
 =?us-ascii?Q?rgX2VtcYZh9L5CnkHfTYc4tozBtwrmqRtnvhv+FEuenFR2Q2hh8s8QRVc7ow?=
 =?us-ascii?Q?JmVKzn+Bt/dJ2U0bAGLrbSDJF2uUJRpDqc1SD1akxPAA3S3JLDycO1pZuoTr?=
 =?us-ascii?Q?m9gbOqklwwNFLdh3Snz3rmvaixeXIHmORgtk7EZxLKIUzlzmayshlxTK1qx0?=
 =?us-ascii?Q?u+3AeiBYp8lmjb4PkYF6vGJnBESPwklFYcMsdUGJdg8NQ3KcFKpz0ZK3Ra5F?=
 =?us-ascii?Q?06L1DnyiTR7TatogChjarZL1eNqF2ucbF/myMP3zCtNWKgOqfXd6trRtDOVu?=
 =?us-ascii?Q?bvCKmlzh68bSZQsx8ZT0EQwTDCTlLSNV4arm9SlDiYz+lS26WYnod9H4RUGU?=
 =?us-ascii?Q?tUbuqXKmTvuNfgbMbkQ0Q6dopArQzuCxO5gkpXLkm4Ikr+qQuB8KbNMJM4Df?=
 =?us-ascii?Q?ky60wz1/ZfgzFDYVBQBPtEq9aumPN2wOUhKHbLX2YZBJGMt42gDcrEwlQAKB?=
 =?us-ascii?Q?1GerfYsaze08tZ7QowF6u9oLgoYZafCoiHp5E4E+Z36vw1Dr/qbBlJ8++Ewp?=
 =?us-ascii?Q?qiyXdSWdWnEZVIzAhfzZMVIIZKbRsQ9FzX256uZfvt5y1oh0++bTL9Wbz4mB?=
 =?us-ascii?Q?X7a7UaV4gNnu4xByzk9A2KibF8NtMwjoIFLIXOAAMLJ1GAYLULiV6x+QsJnl?=
 =?us-ascii?Q?QCEdxi1AqfhYx2Xs53VbtkNPSsQ8leFxkRLy6UJBPV71gi6ZyUxcxfOrzFbg?=
 =?us-ascii?Q?ClHnEF753zr5h2KDBSXoO9AqOZwBfs5hkljAIh5ttW0IZ1TAuWhsRP9ZvV6m?=
 =?us-ascii?Q?z4LshnByL81EY7bp0peenQf6aiWEcpVnsxBYLhEPmE2htiNZZ87A2j5nhwXj?=
 =?us-ascii?Q?CPrUkPuJYI8kCSGXEuqotM85kFIUxxSw21Thz0nqjtTGSvGVTTkCv4zOfTdW?=
 =?us-ascii?Q?U+I0WWmL+IZDvPhe7u7U2xFI7g3/e8FXD26BFaVXkQwXL8uQWr1617XANuZd?=
 =?us-ascii?Q?2+Q1WEz+0NdN2oZceQ5JNdnOsSIHmVNXR5bQ/dSAX4Anv66w8JecLU0mvcoi?=
 =?us-ascii?Q?7iZZYG6rkKDvHdlpJjlQk6okifOykb06UJyXeSgvdouZYq7SWwOcs7CzhYlO?=
 =?us-ascii?Q?bdllR3OihnHZ5qwXAC2ci7eVtflUf1eG/kaF2DA143frV0ihBaeGpFqxdkXq?=
 =?us-ascii?Q?nWQEMX9pDh4wUi5Bi6OEKf4lbi6rtSeve5B335oZJX3RZoVxsivxKG6sTpcz?=
 =?us-ascii?Q?aum2V3lgT3dcaTQLQQNY2l7Ce4bp3AR0gS5MsAGJqT30flHKDljum8Vkmi+h?=
 =?us-ascii?Q?QWUOz1EeqQS8njZRsp60i4/KKYrOnMfubonw+DOSQqECHtMW2Usb4Vs0Faj+?=
 =?us-ascii?Q?zNoHBK5GeULNFn+Vt0ml3RCwNqrx9d+zWHk2EkYNClEyDc9iWqUeqn/28I5j?=
 =?us-ascii?Q?WqZ/OoY+bGmOXVzLs5FGnqLdDM8d+DjfJC3oCR3PUb7q4+GMFHnvCzkv2PWf?=
 =?us-ascii?Q?sPaDa3IWkKEuGwK9hqBMIHA6q7RiLYoaPi1lkqeqn+Q9a7xOheEe+b/OBUbF?=
 =?us-ascii?Q?MeaKGw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe447f54-e67d-4b01-fbf4-08db2477ccd5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 10:35:16.2777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xaI1fdVgGo55Gvr2bT2VECL3rZSkoDEHhmkkWCHQJMfkmqCUpUwLNNcFUtR6qFKTaAJjV9QRmqp6gGAjDKX1FQiPLexsC9Q7NOFkhbS/hsw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5890
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 13, 2023 at 08:10:26PM +0530, Neeraj Sanjay Kale wrote:
> Adds serdev_device_break_ctl() and an implementation for ttyport.
> This function simply calls the break_ctl in tty layer, which can
> assert a break signal over UART-TX line, if the tty and the
> underlying platform and UART peripheral supports this operation.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
> v3: Add details to the commit message. Replace ENOTSUPP with
> EOPNOTSUPP. (Greg KH, Leon Romanovsky)
> v9: Replace all instances of ENOTSUPP with EOPNOTSUPP.
> (Simon Horman)

I'm all for this change. But perhaps it should be a separate clean-up patch,
that precedes the feature-patch which adds the new method. I think that
would make things a bit clearer.

...

> diff --git a/include/linux/serdev.h b/include/linux/serdev.h
> index 66f624fc618c..c065ef1c82f1 100644
> --- a/include/linux/serdev.h
> +++ b/include/linux/serdev.h

...

> @@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
>  void serdev_device_wait_until_sent(struct serdev_device *, long);
>  int serdev_device_get_tiocm(struct serdev_device *);
>  int serdev_device_set_tiocm(struct serdev_device *, int, int);
> +int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
>  void serdev_device_write_wakeup(struct serdev_device *);
>  int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
>  void serdev_device_write_flush(struct serdev_device *);
> @@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
>  {
>  	return -ENOTSUPP;

It seems that you might have missed at least this one.

>  }
> +static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
> +{
> +	return -EOPNOTSUPP;
> +}
>  static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
>  				      size_t count, unsigned long timeout)
>  {
> -- 
> 2.34.1
>