Subject: Re: [PATCH v8 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon
 migration driver
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     <alex.williamson@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        <jonathan.cameron@huawei.com>, <cohuck@redhat.com>,
        <linux-kernel@vger.kernel.org>, <linuxarm@openeuler.org>
References: <20230217084831.35783-1-liulongfang@huawei.com>
 <20230217084831.35783-4-liulongfang@huawei.com> <ZAtnaFHucAe9ntKW@nvidia.com>
From:   liulongfang <liulongfang@huawei.com>
Message-ID: <1e2b9f0f-e99e-babb-7531-6083673d399d@huawei.com>
Date:   Tue, 14 Mar 2023 18:35:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <ZAtnaFHucAe9ntKW@nvidia.com>
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/3/11 1:22, Jason Gunthorpe wrote:
> On Fri, Feb 17, 2023 at 04:48:29PM +0800, Longfang Liu wrote:
> 
>> +static int hisi_acc_vfio_debug_init(struct hisi_acc_vf_core_device *hisi_acc_vdev)
>> +{
>> +	struct vfio_device *vdev = &hisi_acc_vdev->core_device.vdev;
>> +	struct device *dev = vdev->dev;
>> +	void *migf = NULL;
>> +
>> +	if (!debugfs_initialized())
>> +		return 0;
>> +
>> +	vfio_vf_debugfs_init(vdev);
> 
> This is weirdly named with _vf_, this is just
> vfio_device_debufs_init()
> 
OK,

Thanks,
Longfang.
> Jason
> .
>