Date:   Tue, 14 Mar 2023 12:20:18 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Serge Semin <Sergey.Semin@baikalelectronics.ru>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "Andrew Lunn" <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Biao Huang <biao.huang@mediatek.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        "Jose Abreu" <Jose.Abreu@synopsys.com>
Subject: Re: [PATCH net 09/13] net: stmmac: Remove default maxmtu DT-platform
 setting
Message-ID: <ZBBYcnh51WMutdG8@nimitz>
References: <20230313224237.28757-1-Sergey.Semin@baikalelectronics.ru>
 <20230313224237.28757-10-Sergey.Semin@baikalelectronics.ru>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230313224237.28757-10-Sergey.Semin@baikalelectronics.ru>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hlbuZco8CBt9YbeKRZ4NuS4ALzWsxwQpn09lzDMN44iIpKxP4V84eFxb+Q4G?=
 =?us-ascii?Q?ElKmC46LEI6VS7IT29Cy8V7oKtiD5mbpCMT6QlI6TOvJ/pJTMwClj+GPfmbC?=
 =?us-ascii?Q?9Su8LzQN/i58MrpLzr50cuOx+c2R5xYKqyZHrhjXLRR0TyNdCGL6XkrpYWA3?=
 =?us-ascii?Q?pzhstnLqtSwwJ9fiywkNRvHwl5ixqqW7eCZGXEVNMpk/jlRpR8OkR5d7wuhK?=
 =?us-ascii?Q?sNmuzBZ8Wjghopp96w2mv0VGKyX0FRiS5+ezm38sFlOPHZGqIjEG6hDU+ol0?=
 =?us-ascii?Q?H1NXP8+z8Un2cHjLXx2MV1rxyuGQPNkeSQEdChiNTW3BqGpmCJsIhAr784fd?=
 =?us-ascii?Q?/AVw01DTuAn/3Uz/e0+wWwJ5vBHUseZzeJL7f35CkYrXBjOwBx+6YnEDngYL?=
 =?us-ascii?Q?6JIaDmEpHZcnm6XsH1IyipcUcbYRQTHGMywXdZ8hxVcC+NlOVYHFrcvin/mj?=
 =?us-ascii?Q?FhkxPiwTzDx39rVpd5dI5t7E8iF9Ks4XQ4akVoZZ/MdtkDhRPqBM4Azl9sjx?=
 =?us-ascii?Q?8Lbt7Oa67MhZlHVznpTUrwzMAZgkEXjECig6voarRHYl+U4Kb/vE7MXGIsve?=
 =?us-ascii?Q?Kx2pBrT7ER4kPqcKZJCmS8Y+0PDQy3DmnWhoGWjAeD+2/K1tF8f2SqxXOYAP?=
 =?us-ascii?Q?FROEKrVDgDFDcMXVj1Bt+IBCKJsO4bUe+o6tMnHN58JppFtzQ+fubTNdq9ep?=
 =?us-ascii?Q?61NkvUedtH0OSH6yOyBj/mXiKeWMMFncNxTVrsANDVDO/2mkzlYc+4q/Yq+3?=
 =?us-ascii?Q?ZgdrO01hWof9W5Ff9DUOSsxFX0gmUr7hPUgysnqMHuvjcyG77Z4bpHPwHaO9?=
 =?us-ascii?Q?iVMv0R+kgAZPb3ix5XYXkKljxZV8AFIjz3OZ9whlDj5CwwHVK6rh1UcD1DZU?=
 =?us-ascii?Q?W0TbrTu5e57FP0RQ7unDvi0yPWI8IrPpR7IbkukTQHNWw5AsD2YXkIY6ex6E?=
 =?us-ascii?Q?a3lWpAcdcWLBlFuqvFL1mX0PmxyWt9HIj8D2LuBY5TReJgLXNNxA4liKc2km?=
 =?us-ascii?Q?vK2CNIhb5hxnw3pok+Dxs46Qh4E8S5V6iadHB664KAgVvB+xIn1vyEvZwRSC?=
 =?us-ascii?Q?JqidcOeA82EpcD0sulfufkjwnlauZIAaFsEVKwa3VGpUQaUigaTH+7v+FlvX?=
 =?us-ascii?Q?m8f7wrG/l2Ps8vzYKVHAvNstucqjZ3WPosAY4jpop4b03+n5vFU0o4MZRs7d?=
 =?us-ascii?Q?tFNFuk4A7PBl3sVL66dgqRZY23ysCj0rWenSQm3YIZUmE1P3du2QWCo2wQg9?=
 =?us-ascii?Q?yRiSKmhht63GeNUiUhgttZ2zip2FDZRBoLJMlNmDsBNttWQx6n1FqIwNaP7O?=
 =?us-ascii?Q?5c63e34XPXJszuVw0JPuB+zYsXqQ+iFvn4rAQBzP5fZDM7bUFWPaWTErCx8I?=
 =?us-ascii?Q?lMcoIh7W+xP/UCTXZDHHhcMFVeKm9SakR/ySa+8oPSCX2mDj67QxoxbtgVEI?=
 =?us-ascii?Q?vbMx2+RX802Nnve/sW4ABLVWnGed1SWE6I84LqKjqlRspwwuk3c6yv4Xqx0T?=
 =?us-ascii?Q?mwSQvnMbMH/3i7KIqKbBAyTFG7af9HAsLxsLsbfoYoZGDl2nu/Dwue7ajGW3?=
 =?us-ascii?Q?IvsH/JQybGEOuYxcDWl47c3xMHAOepKVBhtg4ugh5p8T/SEqKpzln+zpGB2e?=
 =?us-ascii?Q?wQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 669bc0ff-6e91-440b-3f86-08db247e1be2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 11:20:25.6910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VLvu+1FXxQsR5U52MkT9JgDPBzlGrAQdiOrFDiyVjU/SJQXcBA0swu7bFAKVUbAEM96d54kvOWfS1G9ijDykokmUDKqGg8v0H7cTexdFfbg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6156
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 01:42:33AM +0300, Serge Semin wrote:
> Initializing maxmtu platform parameter in the stmmac_probe_config_dt()
> method by default makes being pointless the DW MAC-specific maximum MTU
> selection algorithm implemented in the stmmac_dvr_probe() method. At least
> for xGMAC we'll always have a frame MTU limited with 9000 while it
> supports units up to 16KB. Let's remove the default initialization of
> the maxmtu platform setting then. We don't replace it with setting the
> maxmtu with some greater value because a default maximum MTU is
> calculated later in the stmmac_dvr_probe() anyway. That would have been a
> pointless limitation too. Instead from now the main STMMAC driver code
> will consider the out of bounds maxmtu value as invalid and will silently
> replace it with a maximum MTU value specific to the corresponding DW MAC.
> 
> Note this alteration will only affect the xGMAC IP-cores due to the way
> the MTU autodetecion algorithm is implemented. So from now the driver will
> permit DW xGMACs to handle frames up to 16KB length (XGMAC_JUMBO_LEN). As
> before DW GMAC IP-cores of v4.0 and higher and IP-cores with enhanced
> descriptor support will be able to work with frames up to 8KB (JUMBO_LEN).
> The rest of the NICs will support frames of SKB_MAX_HEAD(NET_SKB_PAD +
> NET_IP_ALIGN) size.
> 
> Fixes: 7d9e6c5afab6 ("net: stmmac: Integrate XGMAC into main driver flow")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c     | 4 ----
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 -----
>  2 files changed, 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 32aa7953d296..e5cb4edc4e23 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -7252,10 +7252,6 @@ int stmmac_dvr_probe(struct device *device,
>  	if ((priv->plat->maxmtu < ndev->max_mtu) &&
>  	    (priv->plat->maxmtu >= ndev->min_mtu))
>  		ndev->max_mtu = priv->plat->maxmtu;
> -	else if (priv->plat->maxmtu < ndev->min_mtu)
> -		dev_warn(priv->device,
> -			 "%s: warning: maxmtu having invalid value (%d)\n",
> -			 __func__, priv->plat->maxmtu);

Looks fine but by removing plat->maxmtu = JUMBO_LEN; you eliminate the
case of dev_warn here or you remove dev_warn since the driver will be
able to fix the mtu value?
>  
>  	if (flow_ctrl)
>  		priv->flow_ctrl = FLOW_AUTO;	/* RX/TX pause on */
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 067a40fe0a23..857411105a0a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -468,11 +468,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
>  	plat->en_tx_lpi_clockgating =
>  		of_property_read_bool(np, "snps,en-tx-lpi-clockgating");
>  
> -	/* Set the maxmtu to a default of JUMBO_LEN in case the
> -	 * parameter is not present in the device tree.
> -	 */
> -	plat->maxmtu = JUMBO_LEN;
> -
>  	/* Set default value for multicast hash bins */
>  	plat->multicast_filter_bins = HASH_TABLE_SIZE;
>  
> -- 
> 2.39.2
> 
>