Date:   Tue, 14 Mar 2023 12:26:49 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Serge Semin <Sergey.Semin@baikalelectronics.ru>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "Andrew Lunn" <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Biao Huang <biao.huang@mediatek.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        "Jose Abreu" <Jose.Abreu@synopsys.com>
Subject: Re: [PATCH net 06/13] net: stmmac: Free temporary Rx SKB on request
Message-ID: <ZBBZ+RCOac62thQ1@nimitz>
References: <20230313224237.28757-1-Sergey.Semin@baikalelectronics.ru>
 <20230313224237.28757-7-Sergey.Semin@baikalelectronics.ru>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230313224237.28757-7-Sergey.Semin@baikalelectronics.ru>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2PekCjwtf1M3STOEIKRSEssxdt4104EGJ9SgxvrdiefCACXCs/ATTpyL+TnV?=
 =?us-ascii?Q?zjmWJIWja6OxoK6Uuu3zVGgoCFSS0IVBRfiBHfSt8HzsXwmOiI4KpG9pEaha?=
 =?us-ascii?Q?Oj1GqBvteSZxEBwQXjafkKWLDqCqr9XVZzRw4qXRJ7uhknavVolEvdj/oZ0M?=
 =?us-ascii?Q?e9/6wq0aTwat7iN5c3ih7zNNUeT9h5a/Ovp+q+mta9Idr8RAXspPyYWHa9ER?=
 =?us-ascii?Q?ro6QeytVTDbJdP8ugFL7nM4/ByzeVLdylIJy474K+hIVLNtx8gcbZ0GFOZn6?=
 =?us-ascii?Q?T9WjhKIwBmgKYqBljDMwdHLrdPa4dKF0syR72PI2Hag0XxB3MAhjiB4uvCxW?=
 =?us-ascii?Q?rkgabi/ptVJ12MtxTAj7VjVYkCR27dyb0+zT2yZxaRHEKAvJNWEJCQ7T9MyZ?=
 =?us-ascii?Q?QW82B1u+Qrz3+BYLDsSiOpXhxxKoX5jSnjDE1JXU/12o/269wDAaQMJMLr+U?=
 =?us-ascii?Q?nyO+ehdZzly6DlqeFZydDhF2y1FWKFtiBnxlrSLlk6dE66kmBFCANyxB07Zn?=
 =?us-ascii?Q?BSomBoBSom2+UIRtLVccskrdEtFBB7Oi/19uPkgBn48liUIJqgpZDTiwL/KA?=
 =?us-ascii?Q?wfpWITqT98vFwuhY43G2EPEVWyHUUyU3TH/LHiEMMlnKC0RyyiAl43HG9nio?=
 =?us-ascii?Q?f0udaUwC1LMLO9XoX8m9cWK0NLT20oEBcyBg03/lQkVrE78c9Q3uSQrItG1m?=
 =?us-ascii?Q?yf2pAYCz4jvg+e+xyUaYrpsLyDy6D3bMugYIpE123mj+1JNDPpGRptHtFwQV?=
 =?us-ascii?Q?uC5IJltyOQgMbbTkbIboKNzdBQbwaXyRGirh/pXQAKUUFQSgOy1vaCwo2kMh?=
 =?us-ascii?Q?H72A2iKrMYT8ZXT7AMQn6+O0h6XlgUhsO7WkkPShUPTOPYTJSyiukqlsKdYA?=
 =?us-ascii?Q?jtFKNGPBj/gVPAMg1pPIcn2AdR2b6zaBX2OBIO3Peb6dSPSyDxeoUywMvRRo?=
 =?us-ascii?Q?3l5MAbijIn4CuuYHMlOEcfHruAghrDuPjDz0Opk3KSiI/N05VARH6/ikU2Jd?=
 =?us-ascii?Q?GypqiSuTtIHdHtpFzjb3xKo7hXmsmTUFEjDs1gE0SNefKUrHYnWz2iXzA94f?=
 =?us-ascii?Q?QteiUmf9qHfLuHA63Wysg5t61RAq2Fs5AvCqNWIxjWH9bf+JcLXTPX79qzkx?=
 =?us-ascii?Q?ri6c7YslYSIJ+0tOwbxNXXaBUjGmlKDUDDWhSaP3op8Sp2Zs/X3QeF3dB+Jn?=
 =?us-ascii?Q?3WqHlNr2aQBX4qnPNSWHvH/DdEBhUBLF8DPXvnHtCW/IbzTk/0woio441rss?=
 =?us-ascii?Q?HFPJvAtUBi367V6DN7kTjKjn+jm/qmUQ021NFV59wzutKAesBB1k1vmSgGQN?=
 =?us-ascii?Q?WEAa6+RMATKXk7VuMZUoMiFXrAeaT3pFptlJI0iqaT0b8FKAlnkkfv1tV3mh?=
 =?us-ascii?Q?RQi4/EmmxvzFrucooN3uxP48FsJcd1equ/B559HOFNNip6mggx7Wmkk5lDX5?=
 =?us-ascii?Q?zwQbJ4RoRe4UP30wPeriAkjsik662anja7vkddS8idIDq+k88GjLOtT8sB08?=
 =?us-ascii?Q?DYKhSZOX3L1h4Zb/Prbho5/sQBbrt6pycWicvDDWfU7/e0fXUvbk9KgCfutB?=
 =?us-ascii?Q?WCSITtgcXJIHZMxVHZqEbvqYtSPq6kiAQ9Cth8f7Iy9Y80XItOyI8nt0b9/b?=
 =?us-ascii?Q?Vw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8648714f-6dfa-4d2d-3ba5-08db247f01f2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 11:26:51.7499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qjKbdkBFPh8f1iddalzyqucTG1uUBHgD+uHdz6F18vDNaEfoWqBc4FbJL+t394VrCTW2vib4lcOElIdTFH9Y7mFHqyJCY1GeBzs4AKTU3ak=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4694
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 01:42:30AM +0300, Serge Semin wrote:
> In case if an incoming frame couldn't be finished in one stmmac_rx()
> method call an SKB used to collect data so far will be saved in the
> corresponding Rx-queue state buffer. If the network device is closed
> before the frame is completed the preserved SKB will be utilized on the
> next network interface link uprising cycle right on the first frame
> reception, which will cause having a confused set of SKB data. Let's free
> the allocated Rx SKB then when all Rx-buffers are requested to be freed.
> 
> Fixes: ec222003bd94 ("net: stmmac: Prepare to add Split Header support")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index ee4297a25521..4d643b1bbf65 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1545,6 +1545,10 @@ static void dma_free_rx_skbufs(struct stmmac_priv *priv,
>  
>  	for (i = 0; i < dma_conf->dma_rx_size; i++)
>  		stmmac_free_rx_buffer(priv, rx_q, i);
> +
> +	if (rx_q->state_saved)
> +		dev_kfree_skb(rx_q->state.skb);
> +	rx_q->state_saved = false;
>  }
>  
>  static int stmmac_alloc_rx_buffers(struct stmmac_priv *priv,
> -- 
> 2.39.2
> 
> 
LGTM, thanks.
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>