Message-ID: <f9308bea-7059-bac7-a69d-3405babc9c8f@nvidia.com>
Date:   Tue, 14 Mar 2023 11:46:07 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH V3 2/6] dt-bindings: timestamp: Add Tegra234 support
To:     Dipen Patel <dipenp@nvidia.com>,
        Linus Walleij <linus.walleij@linaro.org>
Cc:     thierry.reding@gmail.com, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        robh+dt@kernel.org, timestamp@lists.linux.dev,
        krzysztof.kozlowski+dt@linaro.org, brgl@bgdev.pl, corbet@lwn.net,
        gregkh@linuxfoundation.org
References: <20230310190634.5053-1-dipenp@nvidia.com>
 <20230310190634.5053-3-dipenp@nvidia.com>
 <CACRpkdYmC=eLiWPPPRG7DYBmQfPNCN4pcDhzTCO=hkQDx2HoGw@mail.gmail.com>
 <798dd219-f4aa-39b3-2368-7a6d072b6de2@nvidia.com>
Content-Language: en-US
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <798dd219-f4aa-39b3-2368-7a6d072b6de2@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzNRQWM5V3oxUTh2cFNEajVUaDRSRDM1c2llWm1Ld2orcGNpaTUxdk80M292?=
 =?utf-8?B?V3llcTUwdW5DdG14UEd2dEU0NzZzV1VXc09kMEJkZ0FtMzA4T2xrSmx0cHhJ?=
 =?utf-8?B?UFJKUWEzRFNJbjBxaHBQTDdXK0FISzd1cnlKT1pDdXBEVnhITDZqMjgrZzdT?=
 =?utf-8?B?MFMzc2o4NmtmN09nOHRlYVRyNmFtWlhGUlNKQ1NGYW50ZXZJUDVjQmp6Q0J4?=
 =?utf-8?B?QnBzbU5uVE95QWNaM1NSODZ4WHdMTEQ2ZXd0WFlKODFReWN4dzd4dmlmS2ds?=
 =?utf-8?B?VzRuOENIVHhZMmNESW5mdEt6dC8yK3JtVmJQLzhrd1lqK1NBUTRwdUkzcWU1?=
 =?utf-8?B?UFJUblVkZFZONlkxdDI4d0wrOW1VMkFDUVVrdWpDbDBaVURKUGdka1JDQ0Y5?=
 =?utf-8?B?bldqaWlJclBlSzZJZjJrZ0tuOTBPK0VGVnpoa1oreVMyeE1YbGhDQUdzQXpp?=
 =?utf-8?B?UVZ4QnpkL0N4cmpqczlLaHlhN3M2UFlzQmpvV3FFczRqQlNOckppQ1QrR3Y5?=
 =?utf-8?B?dzhvdjE1WitFVmpIMm1HeEkwYVpFdnFEck4ycGFLc0dQU0w0U202ZWZLY1kw?=
 =?utf-8?B?V1FnTVZLbVpOVHVEeDFQelBwdGJkV2VPRm8yalJrajVGcys5UERoSTRDYW84?=
 =?utf-8?B?akhGN0NQdnBXOWxTTXpFbGdyb0dMUHlkSksvVTg4TmFvVjNOZkswVlpVSHM4?=
 =?utf-8?B?MWloQTVyeXN2TGhFMDJQcHRXVGN1ZlVtbmRvSDZ1a0RnOFhLSlRyRmNJRjY2?=
 =?utf-8?B?M253d2pGbi9meUk1NURvL09HYWhyRDhrRkhwUnNocmlvSHlMOURzSC81SGZK?=
 =?utf-8?B?dG5sbUhUV251dVB1d2RSVjJ2a21ld1NrVW1YcUtWY0piWnZ6c2ppYmJTVGpp?=
 =?utf-8?B?NFNheHEreWpUR3g0RGxvWEJqSDBzcjVYWHJMeFQ1bTRaaUVMU005ZEYyOEk2?=
 =?utf-8?B?UThQenJoUnowdHlVRnVwaEgzditFNS9NOHlYS0xlaE1MOEowVXB1eTIxa0dy?=
 =?utf-8?B?dEQ4bGlwdVo1d2pOOG5aeFVRaVRuZnYrb3J5UUw2ZUxGMTlzMWY5cE0xczVr?=
 =?utf-8?B?TlNPcG82a3VHQVlUalc2SHA4bHpJOU92UFZGeWxxZ2Z3RnBEcFlFSTdyVUxY?=
 =?utf-8?B?OTVRZVhXeG5sTnU5RWdTTi9sbFZXSStVbWNzUDU2M1lGZys3L0plT0tLb0dK?=
 =?utf-8?B?ZDlPNzhqQ05SRE9QNGdvSFZqcmRSS1ZVWGlKQ1R5dDFTNnVBaktHQzQxZ3o2?=
 =?utf-8?B?d1FFc1graGM3Y2p4M29SVnQ3U1dtQ3pYTW9Ma2RDVzg4TlR2T3luVWRIbllp?=
 =?utf-8?B?a0lUcmhrWHJVYUlQak8vRlYyWXhNYzhEcEpRdTgxRG1hOUtXeWgyN0E3bFFy?=
 =?utf-8?B?dElYRWNEU0k2WDJkQXNURXROd0lIYm44RVpPamNEU3lrSkZ1ODI3TVZUTjdu?=
 =?utf-8?B?SDYyM252Zm1PQjVTYVVYTWljdUI0ZldJdzZkVXdqUUhxeVdkQTA4bkFNT1Nt?=
 =?utf-8?B?dGpVcUtkK3FXRkIzajdJUkdpUEN4OVVxcFpZQ0c2NWtFWHIxMmJoTnEyYXNP?=
 =?utf-8?B?TURrVDFzcVhsMmNsSEZKdjViaWNWNndBNWJXa3lqUCtzZkNMZ1JVOVgxNDlp?=
 =?utf-8?B?czNDcGhYdGNNUFZ5eXU1UFkybWJ4azVwZXFwaG1ZZFVJQ2pITG82aitjc00y?=
 =?utf-8?B?ejZhenhTdis0TjllMFUyMGNIS1pWdllaUk96UE5zZ1BhSVVYWmhQakxaTSta?=
 =?utf-8?B?eWwrZXIrRjJmSTc3clc4OE03MW5qWE1Ja1ZxN0VQVmFBV2M5RTIvM3RRZElQ?=
 =?utf-8?B?THd4ODJEWlV6ZnJQdHJMOXBwemhZc1RmM1lOL0tKdUh5UWVyYnVMYXJxcHJH?=
 =?utf-8?B?S3ZrWmpBdFc5UzU0UDJxcWVkVnJQRnRTbnMyK1c5S2ozN01JRWNocHRLZURO?=
 =?utf-8?B?RStjN0x3VzQ0KzhwbkNPZ3F6aFQ1T2lta1JSUkc5NzRuWlo0b2U5ODlmZDZt?=
 =?utf-8?B?UzBMWEN3Wm1seHJqZzZHK0k5dUFqa1RtcjBob1hqR0E2bjg4NWFPVTNOZDll?=
 =?utf-8?B?SDB5bys3MnJjN1NpbUw3b1NTUks5WmhlWk8vcXZSeGdoZUZWYkxFTjg2dHlC?=
 =?utf-8?B?RGxnU0ZpSnFTZlR2V0dxME5tVk1VOHROU1Bad3ltczBRUFN6WUxoVUtiQThr?=
 =?utf-8?B?Z3c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd53d997-b752-4718-8f38-08db2481b6f1
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 11:46:14.6096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lIVOEPYbwIGPeieDz9KjDK4M7Upzde69okbFhL7SEY3QIeZjiaRztvdCYL5fSQ9N/mwHp2ajBI8ZqQ0tQ917ZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5626
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13/03/2023 23:49, Dipen Patel wrote:
> On 3/13/23 2:57 PM, Linus Walleij wrote:
>> Hi Dipen,
>>
>> thanks for maintaining HTE!
>>
>> On Fri, Mar 10, 2023 at 8:06 PM Dipen Patel <dipenp@nvidia.com> wrote:
>>
>>> -  nvidia,slices:
>>> -     $ref: /schemas/types.yaml#/definitions/uint32
>>
>> I would not delete this, just mark it deprecated.
>>
>> nvidia,slices:
>>      $ref: /schemas/types.yaml#/definitions/uint32
>>      deprecated: true
>>
>> (And remove it from required, of course)
>>
>> This way you do not need to explain about why it was
>> deleted, it's just deprecated, which is fine.
> 
> Great suggestion, thanks, will make changes in the next patch.


When you deprecate it, please make this a separate patch because it is 
separate from adding Tegra234 support. Similarly you will want to have a 
separate patch to remove support of the property from the driver as well.

Jon

-- 
nvpublic