From:   Kamlesh Gurudasani <kamlesh@ti.com>
To:     Jayesh Choudhary <j-choudhary@ti.com>, <nm@ti.com>,
        <vigneshr@ti.com>
CC:     <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <j-choudhary@ti.com>
Subject: Re: [PATCH 0/2] Add Crypto Support for J784S4 SoC
In-Reply-To: <20230313104721.407071-1-j-choudhary@ti.com>
References: <20230313104721.407071-1-j-choudhary@ti.com>
Date:   Tue, 14 Mar 2023 17:20:31 +0530
Message-ID: <87v8j3v9fc.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Jayesh Choudhary <j-choudhary@ti.com> writes:

> This series adds the crypto node for sa2ul for j784s4 platform.
>
> First patch adds the device-id for NAVSS without which the probe
> for dma-controller fails due to 'ti,sci-dev-id' read failure.
> Second patch adds the crypto node.
>
> This series has functional dependency on j784s4 k3_soc_id[1] and
> PSIL-thread support[2] but it does not affect the boot.
>
> [1]:
> <https://lore.kernel.org/all/20230313065025.185320-1-j-choudhary@ti.com/>
>
> [2]:
> <https://lore.kernel.org/all/20230308201513.116638-1-j-choudhary@ti.com/>
>
> For testing the crypto support, crypto extra tests and self tests were
> enabled and tcrypt tests were used to verify SHA-1/256/512, AES and DES3
> algorithms.
>
> Testing log:
> <https://gist.github.com/Jayesh2000/4fe36337af6f9dc96a055359d5d6f4ca>
>
> Jayesh Choudhary (2):
>   arm64: dts: ti: k3-j784s4-main: Add 'ti,sci-dev-id' for main_navss
>   arm64: dts: ti: k3-j784s4-main: Enable crypto accelerator
>
>  arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> -- 
> 2.25.1
Both patches look good to me.

Reviewed-by: Kamlesh Gurudasani <kamlesh@ti.com>