Message-ID: <ca1385b5-b3f8-73f3-276c-a2a08ec09aa0@intel.com>
Date:   Tue, 14 Mar 2023 12:57:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH bpf-next v3 0/4] xdp: recycle Page Pool backed skbs built
 from XDP frames
To:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>
CC:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Menglong Dong <imagedong@tencent.com>,
        Mykola Lysenko <mykolal@fb.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230313215553.1045175-1-aleksander.lobakin@intel.com>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230313215553.1045175-1-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmlHSGIyR3ROT0htU3lSbWFWNVVWalFZRU02RjlkR1ppZ014YUFIZzNBQ1Vm?=
 =?utf-8?B?Y1IvQTZyclJHMVh2SWwrR3cvYkMxNVZVcjFLcUF5a2c1TnVGY3dqVFl2ZjJz?=
 =?utf-8?B?T1VJQzRsSTE1cUs3eFREWDRTZFFsM1c1R2ZwbVNKdnpGMGQ3MUNnNkRXamtm?=
 =?utf-8?B?b2dKL1BxR21lN0Q2M29IMWlRdkdvY2dRYXZXTkRiMjVRNHdyUUdhSGNwY05F?=
 =?utf-8?B?OU82WWNDK21FTGtITUFwM2xUdHBFcmhqM0JlbUNCbDZ4UktKWWhHemFjSml2?=
 =?utf-8?B?N2ZoZ2Y3MTBETWNnQ2M5ZnFUTWZrYW8rS2hMOVFQNVhDRTdSN21tbUgwM3JI?=
 =?utf-8?B?L2FMSDNIaVc5ZDJXZEZYQWlIMmI3eWp0YXJScm8xdElLUk1SVmEvdFFpbnlq?=
 =?utf-8?B?Q0RlRHJVZlI0eUNoY3NPSXlSQi9CdTk4c0Q1YUU5UTFSOHNXRG5leWxZZHIx?=
 =?utf-8?B?NUhPbDBtTEI0YStEUjFJb1JJL0lrR29tRDRtZDlZQ0trR2JjT3pVVDZBRmd2?=
 =?utf-8?B?a1lBZEg0OXcyVXNXeXpCS2F4U283VTJZZUpNWVdsc3FORkZLakphZzl6Ymlv?=
 =?utf-8?B?NlRGUEJWNzVlbGx5Q0JLR1RHRzhyU0t5cmhUOFBRcUM0MEZNa04rTEdOdHQv?=
 =?utf-8?B?T0tpZGlvUVhwVldCUVhMTDhQYmEvNG9EWDRqV2NzTmFpRFJZZWZPakpTSmU2?=
 =?utf-8?B?RkJ2d1lUa0NycTdpM1FBRjM2Z21HMzI1OUNmOFJzSkFucFlidVJOSmxtaldk?=
 =?utf-8?B?TTltUEtCaGI0cUNHUlVjd05iazRsK0l2TDlvUnJmcFNma0hyRmlrYXRKM2lw?=
 =?utf-8?B?QkFEanYyS0NjUFJPOXdGN0VpcTFOS1NEZEtnVitRWDVHY2plOUtMYXFCRmc2?=
 =?utf-8?B?WUlZaXA4bmpHTGRRRTMvV2Z6T0t0UVdKUFJIbnI5QVozM0VEMzdWOHBIK3hT?=
 =?utf-8?B?cDFKWkYzMEsxbFdJR1Q0MFBFSHVtWlJnMzVWV0NrUnRGZnFyaUNkcmwrbkRG?=
 =?utf-8?B?NjFJbERucVEvMXk3R1ZMS0NVdGk4RGtkRGFTa3I2SWwvZDdSZGhFV0F5VnpF?=
 =?utf-8?B?dlFENC9WYVZDektwbTd1VC9aUTQ0Y0JzSXRWZWlha0xtcDcvNktEK1JQU0hF?=
 =?utf-8?B?eDc0Y0dLR1BvYUdaYUVaaUVDeTJkWWxFV2NVeE1rb0RwSUdNaGMzc3FtMnJp?=
 =?utf-8?B?Sk1GTmxTWUpKMytaR3A2Yno2NkFMVW5Nc21oQkxrQVpNRWJ1OVZ0Qi9KQUow?=
 =?utf-8?B?UEJyc1hudk9NZnI1SkRUVzVFZWpVd1M5NkNSNndMQmllcnhHMzdXb0tsN0li?=
 =?utf-8?B?a1Fib0dTTlNHN3J0SHk1OVNaTGpUU25RbG9xUFhEbWl6QmVhQXRyenc2VEw0?=
 =?utf-8?B?bzUyeFp5aDBqU0JQd0VVMUFoOWdUeXAzRVk1NkdRYXlGK1pZaFdaemlnUHN1?=
 =?utf-8?B?R3pkcm9xNVNPaXhyMlVzc1I2bE8zZEhzYlFaTmJlUGE2YmpCQW9lVzlLVVQ5?=
 =?utf-8?B?ZmtOaXFwUm1ON2NXa0dwb282bTQyQVNELzNsdGtuY1l1Q2Ivalkra1Ywa09p?=
 =?utf-8?B?S0ZGNHhJbXJYSlBXUmY2RE5CdHJpUVBsa3pkaXZpNlJUV3FkNzJXMkJMb2F2?=
 =?utf-8?B?RUlvam9CaVlZSi9QNExpRFl3Vk4zbHdMcmRRN3pqanU2Y1hYUlFzcVVoeHBw?=
 =?utf-8?B?YzA4dHZNcTRHaHlWd2Nrb0VnYTN4Y3U3WWlsT0M4MkpzY1JHdkJ5SVpJY0Yw?=
 =?utf-8?B?MlFOc3ZlV1IxS2tVVzR3Q2h4ZGpqR2ZFNUh5YXpZZmxXOTlRdU5rWVhZTG1K?=
 =?utf-8?B?VG9MU3lKR2cxencrV0tub2xlNjIzSzVWUDRMOHBlUnY1d3BrVVRQaVZVSldB?=
 =?utf-8?B?Yms4L2NVREg4YjhyS1RZTkp2SURIeDZWNTlkbyt2ajk0bGFnQ2xVRDQ0VERT?=
 =?utf-8?B?UnA1a0hYY0RybVNkUzVXL1pHTTBvaThydEZQYURQRTFYZ0ZoSEtBRElUK0k0?=
 =?utf-8?B?VDU3RDFWUXhEcU5PS2lXOHlzV0NsTUFvU3A2YitKN1M5WnI5Q2JoTEF5QzRD?=
 =?utf-8?B?enpCdE1SRjA5Qk1HWldISFZCR1Y0M3pzcmwzMFRySE9nNTAyT1hIUUdjWTNT?=
 =?utf-8?B?UTJIdUVVamhzSCtTdklaNzNyTUs1Uzdab1hQK0xRY3BJazVuVUlOMTJOY0E1?=
 =?utf-8?Q?0wN7n8P517ZRlFnK3ZEAOQY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a87e3c18-1dcd-434f-6700-08db24836011
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 11:58:07.7094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HqmxcJ12r6Gam0rWXimksiw51RfDm+uLY6u5Y733t5PNSzP6VnA5j116mq3NF75LRM2nZw6n0XsnhlcedjW7BepXWIk8j1RdC0mQeboc+jA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7455
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Mon, 13 Mar 2023 22:55:49 +0100

> Yeah, I still remember that "Who needs cpumap nowadays" (c), but anyway.
> 
> __xdp_build_skb_from_frame() missed the moment when the networking stack
> became able to recycle skb pages backed by a page_pool. This was making
> e.g. cpumap redirect even less effective than simple %XDP_PASS. veth was
> also affected in some scenarios.
[...]

Regarding failing tests, here's a piece of logs:

  #288     xdp_devmap_attach:OK
  [  156.324473] IPv6: ADDRCONF(NETDEV_CHANGE): veth_src: link becomes ready
  [  156.362859] bond2 (unregistering): Released all slaves
  #289     xdp_do_redirect:OK
  #290     xdp_info:OK

[...]

  #297/1   xfrm_info/xfrm_info:OK
  #297     xfrm_info:OK

  All error logs:
  libbpf: prog 'trace_virtqueue_add_sgs': BPF program load failed: Bad
address
  libbpf: prog 'trace_virtqueue_add_sgs': -- BEGIN PROG LOAD LOG --
  The sequence of 8193 jumps is too complex.
  verification time 77808 usec
  stack depth 64
  processed 156616 insns (limit 1000000) max_states_per_insn 8
total_states 1754 peak_states 1712 mark_read 12
  -- END PROG LOAD LOG --
  libbpf: prog 'trace_virtqueue_add_sgs': failed to load: -14
  libbpf: failed to load object 'loop6.bpf.o'
  scale_test:FAIL:expect_success unexpected error: -14 (errno 14)
  #257     verif_scale_loop6:FAIL
  Summary: 288/1766 PASSED, 21 SKIPPED, 1 FAILED

So, xdp_do_redirect, which was previously failing, now works fine. OTOH,
"verif_scale_loop6" now fails, but from what I understand from the log,
it has nothing with the series ("8193 jumps is too complex" -- I don't
even touch program-related stuff). I don't know what's the reason of it
failing, can it be some CI issues or maybe some recent commits?

Thanks,
Olek