Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A2BC7618D for ; Tue, 14 Mar 2023 12:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbjCNMfM (ORCPT ); Tue, 14 Mar 2023 08:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbjCNMeu (ORCPT ); Tue, 14 Mar 2023 08:34:50 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F69975B; Tue, 14 Mar 2023 05:34:14 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4EB271F894; Tue, 14 Mar 2023 12:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678797184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8bNwe2Njk3+87TEl51b4MBi4XFMN+aBFbgLN0/WG5dQ=; b=YKmPMCtPzyvZbHfTB+tmc7oUnvAS2QdpeleoEwO/zQV4euocgVcdeN+B5wVXecmkWXf6Pr BlmvPh0Bnttpi3GVM4epNfzLjnADT1Ekj4XNL/ZQYmYWvmDMfSGJfVIyAUH3cNnJqHf6SM nCIT5vMgAzGTi0fZiASjUpER/koeARI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678797184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8bNwe2Njk3+87TEl51b4MBi4XFMN+aBFbgLN0/WG5dQ=; b=xvxq3EEFiKf1631WHZsnMfYmqU5Ebmwg2TBptXafuKVSQD/ZYNzjl5MHD1apvisHaSVbbE JelovuE3o8u69DCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F377513A26; Tue, 14 Mar 2023 12:33:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id seWJOn9pEGR6WQAAMHmgww (envelope-from ); Tue, 14 Mar 2023 12:33:03 +0000 Date: Tue, 14 Mar 2023 13:33:03 +0100 Message-ID: <87y1nzbji8.wl-tiwai@suse.de> From: Takashi Iwai To: Niklas Schnelle Cc: Arnd Bergmann , Jaroslav Kysela , Takashi Iwai , Greg Kroah-Hartman , Bjorn Helgaas , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , alsa-devel@alsa-project.org Subject: Re: [PATCH v3 30/38] sound: add HAS_IOPORT dependencies In-Reply-To: <20230314121216.413434-31-schnelle@linux.ibm.com> References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-31-schnelle@linux.ibm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2023 13:12:08 +0100, Niklas Schnelle wrote: > --- a/sound/isa/Kconfig > +++ b/sound/isa/Kconfig > @@ -23,6 +23,7 @@ menuconfig SND_ISA > bool "ISA sound devices" > depends on ISA || COMPILE_TEST > depends on ISA_DMA_API > + depends on HAS_IOPORT > default y > help > Support for sound devices connected via the ISA bus. With this dependency, ... > @@ -31,6 +32,7 @@ if SND_ISA > > config SND_ADLIB > tristate "AdLib FM card" > + depends on HAS_IOPORT > select SND_OPL3_LIB > help > Say Y here to include support for AdLib FM cards. ... this and lots of other similar changes become redundant, as they already depend on CONFIG_SND_ISA. > --- a/sound/pcmcia/Kconfig > +++ b/sound/pcmcia/Kconfig > @@ -13,6 +13,7 @@ if SND_PCMCIA && PCMCIA > config SND_VXPOCKET > tristate "Digigram VXpocket" > select SND_VX_LIB > + depends on HAS_IOPORT > help > Say Y here to include support for Digigram VXpocket and > VXpocket 440 soundcards. > @@ -22,6 +23,7 @@ config SND_VXPOCKET > > config SND_PDAUDIOCF > tristate "Sound Core PDAudioCF" > + depends on HAS_IOPORT > select SND_PCM > help > Say Y here to include support for Sound Core PDAudioCF I guess it's easier to make CONFIG_SND_PCMCIA depending on CONFIG_HAS_IOPORT (like done for CONFIG_SND_ISA). thanks, Takashi