Date:   Tue, 14 Mar 2023 13:33:03 +0100
Message-ID: <87y1nzbji8.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-pci@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 30/38] sound: add HAS_IOPORT dependencies
In-Reply-To: <20230314121216.413434-31-schnelle@linux.ibm.com>
References: <20230314121216.413434-1-schnelle@linux.ibm.com>
        <20230314121216.413434-31-schnelle@linux.ibm.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 14 Mar 2023 13:12:08 +0100,
Niklas Schnelle wrote:
> --- a/sound/isa/Kconfig
> +++ b/sound/isa/Kconfig
> @@ -23,6 +23,7 @@ menuconfig SND_ISA
>  	bool "ISA sound devices"
>  	depends on ISA || COMPILE_TEST
>  	depends on ISA_DMA_API
> +	depends on HAS_IOPORT
>  	default y
>  	help
>  	  Support for sound devices connected via the ISA bus.

With this dependency, ...

> @@ -31,6 +32,7 @@ if SND_ISA
>  
>  config SND_ADLIB
>  	tristate "AdLib FM card"
> +	depends on HAS_IOPORT
>  	select SND_OPL3_LIB
>  	help
>  	  Say Y here to include support for AdLib FM cards.

... this and lots of other similar changes become redundant, as they
already depend on CONFIG_SND_ISA.

> --- a/sound/pcmcia/Kconfig
> +++ b/sound/pcmcia/Kconfig
> @@ -13,6 +13,7 @@ if SND_PCMCIA && PCMCIA
>  config SND_VXPOCKET
>  	tristate "Digigram VXpocket"
>  	select SND_VX_LIB
> +	depends on HAS_IOPORT
>  	help
>  	  Say Y here to include support for Digigram VXpocket and
>  	  VXpocket 440 soundcards.
> @@ -22,6 +23,7 @@ config SND_VXPOCKET
>  
>  config SND_PDAUDIOCF
>  	tristate "Sound Core PDAudioCF"
> +	depends on HAS_IOPORT
>  	select SND_PCM
>  	help
>  	  Say Y here to include support for Sound Core PDAudioCF

I guess it's easier to make CONFIG_SND_PCMCIA depending on
CONFIG_HAS_IOPORT (like done for CONFIG_SND_ISA).


thanks,

Takashi