Date:   Tue, 14 Mar 2023 14:33:13 +0200
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     Robert Mader <robert.mader@collabora.com>,
        Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
        linux-kernel@vger.kernel.org, nicholas@rothemail.net,
        javierm@redhat.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: i2c: imx258: Parse and register properties
Message-ID: <ZBBpiUnKnRGTVPkZ@valkosipuli.retiisi.eu>
References: <20230104122337.123055-1-robert.mader@collabora.com>
 <20230104141159.e2klapbpenslxqbx@uno.localdomain>
 <e55766f0-5090-abb5-dbd7-58230153a8ce@collabora.com>
 <Y7WieRzn4p9NCwsg@paasikivi.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y7WieRzn4p9NCwsg@paasikivi.fi.intel.com>
Precedence: bulk

On Wed, Jan 04, 2023 at 03:59:53PM +0000, Sakari Ailus wrote:
> Hi Robert,
> 
> On Wed, Jan 04, 2023 at 03:14:50PM +0100, Robert Mader wrote:
> > On 04.01.23 15:11, Jacopo Mondi wrote:
> > > Hi Robert
> > > 
> > > On Wed, Jan 04, 2023 at 01:23:37PM +0100, Robert Mader wrote:
> > > > Analogous to e.g. the imx219. This enables propagating
> > > > V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION
> > > > values.
> > > > The motivation is to allow libcamera detect these values from the
> > > > device tree and propagate them further to e.g. Pipewire.
> > > > 
> > > > While at it, reserve space for 3 additional controls even if
> > > > v4l2_ctrl_new_fwnode_properties() can only register 2 of
> > > > them, to fix the existing implementation which reserve space for 8
> > > > controls but actually registers 9.
> > > > 
> > > > Changes in v2:
> > > >   - Reserve 11 instead of 10 controls
> > > >   - Change order of variable declaration
> > > >   - Slightly extend description
> > > This part should go below, after ---, as it shouldn't be part of the commit
> > > message
> > > 
> > > The patch looks good
> > > 
> > > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > Thanks! And ops, right, make sense. Should I spin a v3 for that or is it
> > simple enough to fix when pulling?
> 
> I can fix it while applying the patch.

No need for line breaks after period, just let your editor to break them
before 74 or so.

-- 
Sakari Ailus