Message-ID: <b14b8827-7d09-c37e-0548-a30b14ffe64f@amd.com>
Date:   Tue, 14 Mar 2023 14:08:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] drm/radeon: remove unused variable rbo
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, alexander.deucher@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230314130616.2170856-1-trix@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230314130616.2170856-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2dtT3N0TE1oaFkwdXloT0loa3FjMU9oTUdtejIvbGY1M1czaHVVWFZnRnNR?=
 =?utf-8?B?cFVRSmVQZm43WnlnSFFjdVNoWGpuRnV6Z3hRSFIrc0Q2dGJaMFFyUG93ZHY1?=
 =?utf-8?B?UkhtNzRRRlFEZXZScXNJdlRFL0FGRHloMmR3S3lTb2orbkdEWHRKR08wS2J4?=
 =?utf-8?B?OFByck1iTFRpdDhiTGRRTXRlM1NmTjgxT2V4eGN5Tnc3SDdrUkc4OG8xVGkz?=
 =?utf-8?B?QWxnNFpMR2hoWjN1Sys4TkdGa1l2bGx2QjhsOEM0TGI3WUNsamFvSzdLTzdL?=
 =?utf-8?B?ck4vUWhYbklCTHdMdTVqYWFZamtOME5ZVXJsZDVhYUNoNGZwRjIrMHpzdVhz?=
 =?utf-8?B?UVAxZngxTjhNeXlKSnU1c3JmNXhab1ZPYkh1UTRPd1J4MTQzclpGdDh1OU9F?=
 =?utf-8?B?U001ZXRBS29RZG4zNDNMMzJxZlpqYUZZZDlPbHhwZE4vWWF3aTFkV1V2Yk81?=
 =?utf-8?B?RVZCQmFtUU9Ha2h5MTUxUG9sK1hYUmVadzM1d1lRbjA5a2FhMDEvb201RVZx?=
 =?utf-8?B?Mkk2V25LTWczNzBMSGNJZjB4TFNDcnNkdlVBSG00OXVJNUZGV25qQ01yT0ZV?=
 =?utf-8?B?YzJQWU5oTUpVU0NKNS9LVkRiUGd6cGFmenlDUzRybXNVZXR3Q2laU2FKbEpB?=
 =?utf-8?B?WTlxcGV1ZnhodGtBRExZcE5PU2VnaFFWZTZwbUJudlNyVWJkd3d1bHlLWXBq?=
 =?utf-8?B?VVozcDgrdHZFZmpQczhmd0FDUTVQem1raWlXQlhTWkUxcEMwbWZuK2Q0YlUz?=
 =?utf-8?B?eWlQbVVvSkVyUHZtNkMvOFhIRU1tYkVLcS9WcDEwZTEyM0FiSXFVN3Z2VUxj?=
 =?utf-8?B?L1dRZFNpaXlyNUFEK3dmZnMwUU13MTFkU2lEczJRbHRKUjRTN0N2MzJGd3Ix?=
 =?utf-8?B?VmZTQlpLWEZnVC91RzNRayt6T09vSGI3Y0NRenZTOGpNeXR5L0loNTVKd0t3?=
 =?utf-8?B?d3l4L1ZXcWgvWnZGRU1ScmI2OGNyOWpmb2ZhR2ZwNHo2dWFOU2NXdzhOZkdH?=
 =?utf-8?B?TjhId1ZDZGdZRkJLdDR0Wk91QnFWNWNZUHdvaDFEVEJhbVk2WVZsdGZKUFlE?=
 =?utf-8?B?TDlmeDN3TlFpcnBGOHpRYm1WKzlyTnp1ZVA0N3FLRkVPMkNheE5QQmQzQ3pX?=
 =?utf-8?B?WS9Pc3J2cndvaTR2VnBsbzlnZ095SjhHZk9NSmhiRnNUdG1jYXhTdkMyaXV5?=
 =?utf-8?B?eXFhY28xWVRhLzZqTmxxemp5M09jd0NwZys4ejdualg0MDRqMVRzTEU0WXpV?=
 =?utf-8?B?dEtNTXoraU1HZzVMTkRGUlNJTllhRmJWQ2tWOTNjcE93SEJjQlcvUVV1R2dz?=
 =?utf-8?B?MWRRWTdROVcwV09YelpiUC9GL1VWbC81ckZoT29aQ2N4RVptbExabG9JenRR?=
 =?utf-8?B?T2RUN09qdnJYRGplcXlZNWtlc2hsYjVZYk9JT05uaUdCSXV1NEIvTW5GRC96?=
 =?utf-8?B?bmpUaEVjZ0I1NDlKTTh5WFBZM2xGSU1xNGVreFAvSXNYWFJoT0lpR202MFNu?=
 =?utf-8?B?SXMxSUhpcXJhZ29rRTlXNHdIMUlxN0dBbzRCbytJc2FtSWUxaldLTDFYS0N5?=
 =?utf-8?B?V0VsbFdsUklOUHQxS0dzU0tRU0x6L3ZSMzN0ajRRb3ppL1RReTRLVytDbWUz?=
 =?utf-8?B?VmgrYTlhVHNuQy91OTdoY0pWZ1lxUkdKTDljWThXRWxZT25WVXpZbGJPOWd5?=
 =?utf-8?B?R2wvakhCbVJ5S3hvSjBHQ0YyWTlrd05rTWp2KzlZOHJSSHd1NStXVzNwWW1r?=
 =?utf-8?B?T0ovWHNxbFFkNk9XT1NocWNQRnBLRHVsL2VGTTY0Z0xuazZyemtHRkE0MmVx?=
 =?utf-8?B?R09VL3JkSmNnNlVTbmJraTJXM1FDRnppTGtoemV3dExSdm8zVGRnUUxZN28y?=
 =?utf-8?B?NWNEaDdxZVRaeE4vMHlHbVFqQjVMZkRPK015RURtWHo1cFRpQ1liQjNxY1pu?=
 =?utf-8?B?MytzKzVORUtmOHQ5SDE2dzdReWVpTlVhK1JBdWNXWDAvb3BzNmFydllnVzI2?=
 =?utf-8?B?d0Ztbk45cTE2elN2VURmdHZmM015ZjMvazNFUGUyZjdFQmZ3dkR3N0srM2lZ?=
 =?utf-8?B?QWFaN2ZWZ2hVZW1UTXZUcmdjS3FrY05FVEpWQmJGblR4WDE5bDNtUm5ZMUtM?=
 =?utf-8?Q?tsgvGm84UXIfguK40NvKzVeKN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e91a1ea-4736-49a7-69b8-08db248d2b86
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 13:08:14.4774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MyjEUqgDmJlCl+d1oeE6h72mkiwLUcEqjZkIu404uAZpuONCX/LVa4CqULYvwGpU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7383
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 14.03.23 um 14:06 schrieb Tom Rix:
> gcc with W=1 reports this error
> drivers/gpu/drm/radeon/radeon_ttm.c:201:27: error:
>    variable ‘rbo’ set but not used [-Werror=unused-but-set-variable]
>    201 |         struct radeon_bo *rbo;
>        |                           ^~~
>
> rbo use was removed with
> commit f87c1f0b7b79 ("drm/ttm: prevent moving of pinned BOs")
> Since the variable is not used, remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 2220cdf6a3f6..0ea430ee5256 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -198,7 +198,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
>   {
>   	struct ttm_resource *old_mem = bo->resource;
>   	struct radeon_device *rdev;
> -	struct radeon_bo *rbo;
>   	int r;
>   
>   	if (new_mem->mem_type == TTM_PL_TT) {
> @@ -211,7 +210,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
>   	if (r)
>   		return r;
>   
> -	rbo = container_of(bo, struct radeon_bo, tbo);
>   	rdev = radeon_get_rdev(bo->bdev);
>   	if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
>   			 bo->ttm == NULL)) {