Date:   Tue, 14 Mar 2023 14:09:59 +0100
From:   Christian Brauner <brauner@kernel.org>
To:     Tobias Klauser <tklauser@distanz.ch>
Cc:     Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests/clone3: fix number of tests in ksft_set_plan
Message-ID: <20230314130959.7gfuagxta6k423kf@wittgenstein>
References: <20230314115352.20623-1-tklauser@distanz.ch>
 <20230314123414.26907-1-tklauser@distanz.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230314123414.26907-1-tklauser@distanz.ch>
Precedence: bulk

On Tue, Mar 14, 2023 at 01:34:14PM +0100, Tobias Klauser wrote:
> Commit 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> added an additional test, so the number passed to ksft_set_plan needs to
> be bumped accordingly.
> 
> Also use ksft_finished() to print results and exit. This will catch future
> mismatches between ksft_set_plan() and the number of tests being run.
> 
> Fixes: 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> Cc: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---

Looks good. Thanks for fixing this,
Reviewed-by: Christian Brauner <brauner@kernel.org>

Feel free to take this through the selftests tree, Shuah.