IronPort-Data: A9a23:8MesvqqoT5PRsj0S3s/3kwN7Z65eBmL8ZBIvgKrLsJaIsI4StFCzt
 garIBmBb/fZMWHxeYwja9jipE4H65aEm99hTQFkqCs8EXwX8puZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev
 NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weFziVNVvrzGInqR5fGatgMdgKFb
 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo
 OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay
 RAXACIyZxvapOiZ/JimF8JmmME/APSxFqpK7xmMzRmBZRonabbqZvyQoPV+jHI3jM0IGuvCb
 c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYWPEjCJbZw9ckKwv
 GXJ8n6/GhgHHNee1SCE4jSngeqncSbTAdpKS+3pp6M66LGV7jM4GgIUd1zimKm0rEriVukOc
 BE2wwN7+MDe82TuFLERRSaQonGeuQUHc8FNCOB84waIooLQ4gCEFi0HQyRHZdgOqsA7X3op2
 0WPktevAiZg2JWRSHSA5vKeqTS5OgALImIYIywJVw0I55/kuo5bphvfRNFuOK24lNv4HXf8w
 FiivCU4wrkek8MP/6G65kzcxSKhoIDTSQw47RmRWXiqhj6Vf6agbo2srFLdvfBJKd/DSkHb5
 Sde3c+D8OoJEJeB0jSXR/kAF62o4PDDNyDAhVloHN8q8DHFF2OfQL28KQpWfC9BWvvosxeyC
 KMPkWu9PKNuAUY=
IronPort-HdrOrdr: A9a23:+iXPuago5iQwJ6FD/DaPnvIva3BQXioji2hC6mlwRA09TyX5ra
 2TdZUgpHjJYVMqMk3I9uruBEDtex3hHNtOkOos1NSZLW3bUQmTTL2KhLGKq1Hd8m/Fh4xgPM
 9bGJSWY+eAaGSS4/ya3OG5eexQvOVu8sqT9JjjJ6EGd3AVV0lihT0JezpyCidNNW977QJSLu
 vn2iJAzQDQAEg/X4CAKVQuefPMnNHPnIKOW296O/Z2gDP+9Q9B8dTBYmOl4is=
Date:   Tue, 14 Mar 2023 15:00:36 +0100
From:   Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To:     Juergen Gross <jgross@suse.com>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        Jens Axboe <axboe@kernel.dk>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 4/4] xen/blkback: move blkif_get_x86_*_req() into
 blkback.c
Message-ID: <ZBB+BATNAlW53VJT@Air-de-Roger>
References: <20221216145816.27374-1-jgross@suse.com>
 <20221216145816.27374-5-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221216145816.27374-5-jgross@suse.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enBjMzZ1aGJWNlg4U2dPYTVCZE4rMSt0TkhDQTVmVHJDSmR5ektNNGppNFUy?=
 =?utf-8?B?MFROdUlEakhPbXoxYzF6OFB6WkdQQ3lUYWE1VGtxSVUvUEtrS0k2RUZMSS9M?=
 =?utf-8?B?RFhXR3BzNlIxcjRsZlVhK0hHQjV3eVhXREZNQ2dVY1RVdUhIaFZRWjJYcm1T?=
 =?utf-8?B?NWkvejMvUk8wUFZRdXVHZm5QM091M3hoZEFJNlNRZGZUb0IrandSaFA1cS9u?=
 =?utf-8?B?cXgyeVJkZmJSRjdac29aRHNSVExXdWdNNmhaZVorSThEMnJ1U1VYUDkwTW04?=
 =?utf-8?B?SnNrR0tkQ1pnNlkxL1hGRmNpYXpKN3BpQUpIb3Q2OUN1SUhpbWpQcm02SWk1?=
 =?utf-8?B?c1A4d0RTeGlOb2dIVlhZdkxaVEtady9pN05hSjdzUUs5RFdlaVV1clNuS2Mz?=
 =?utf-8?B?NldERXJMM2lsVm1Jb3dYTUZPTE5NMWgyN1lKZDhUT0NzdHpIaFNUbnpINFZ3?=
 =?utf-8?B?bDAvTlhucDdDUEdpQ0Iwb0JGSllqUTcyKzE2T0tyanErYjlnRTlaUzN6REZm?=
 =?utf-8?B?c1p6ek56REtTYjlTWjg2ZmRlVmp4WW53WnEzbEV0TldvME9xR2RZM1lWT1dq?=
 =?utf-8?B?WFRXZ3ZSdXRSblY5aU1Qcmp6VXl2bVNXQUJzclVXS3VlVWVQNXBXbDdwbWFL?=
 =?utf-8?B?eUtWNVJZenRBbzViNTBrYXczYXA4Z3ZOVkJSNGJJaForU2t6WldZdGFIckxt?=
 =?utf-8?B?S2oxTEd1enhvWUtyeGpGOUc1SVNwSys1amkxYkFGWFlFdElxck9tOHFEdCtT?=
 =?utf-8?B?YjBjeGJ2MGlKcXRCejVydVdzNXhSaWFocDVnVVduWHF5azlObE9WTEo3S1Js?=
 =?utf-8?B?OFFYUERpS1ZqU242aUtQVWxjWVVBZmh0UExpQUVyQzNrRDlWRjZSV2FiMUFz?=
 =?utf-8?B?ZjZ4QzZFbzNnN2VoeEUyNGhBWnVmQmpIbThpUXlxL0RBNXg1Vk5IQmNONG9N?=
 =?utf-8?B?YmhYNnhTNDN2emhzRlJNNURpREhQUEZoWU5jdGtSODBCQ0xRMEorcGtDMTVY?=
 =?utf-8?B?ODB6T3QrS1l5Tk1jRURvNUtrbi94ejZzRnVqS3d2TW5vK0RSQitYbWlCRkNM?=
 =?utf-8?B?bUdNTmRjUkUyMGsyR1NlaXNGakpOWk9YUkI5ZDgvR3hTZ3V5YzRrRWpPNkpQ?=
 =?utf-8?B?WDdTVXV2bzY3TDJ4ci9RUlhlckZGM3NqdStQenVIY0laZGZ4OW5FcU5YS3Jh?=
 =?utf-8?B?ZTV1RVZEc0toM1hLTzg5WVVxeXFpTVFabmhTeDhDai85eXRiRlh2eVBGTzFl?=
 =?utf-8?B?TWJadGVOT0o4dTQ3UktiMUZNeis2T1dXSEphcHFocUhGYkM2TldSZjlKK3Y2?=
 =?utf-8?B?dktVR1pMeG9vOU9BeW1LUUNoZVB4eG05ZlQvYnFLRzlieXpFY1BtRU5zZ2Z0?=
 =?utf-8?B?RWRzaWkvSFZBai9ia3JpZkRqeW01Q1dxSGdCdE1MNHVsWGw0YXlyWjRpeXQ4?=
 =?utf-8?B?WU5nTTdtRmpETkYzNVYrNHN3RUdxcUhDazFxSDYzbUlPM3d4WTRsbmdlRTJp?=
 =?utf-8?B?ZHlubm5id08xVXhiZ0lmTnlMNGx4ZVJ5Wnp4MnJRYUduUDlZUFhCa21JelR2?=
 =?utf-8?B?cTZ4M0hvMUN4RC9iRmpEa0NoRlFOeFRYVjFQRmxtQmFqcEIwRnRCQjRtcWFv?=
 =?utf-8?B?bnpMUFNSM2crdmZSSUN4VVB5TkhKWFlMRXFDbjEwTjREdFVGRjJmb2w3NFRi?=
 =?utf-8?B?K2JZTDY0SDFteE5PWkpuTXdJYmsxOTZhTkh6b1Zwc0NnRjZVWXBHYkxzTW1I?=
 =?utf-8?B?RlkvVi9uMjZUMEtDUXZBa2VjY1pQb25uMUVKeFA2WU93RFkzUXg5aXdaUGFR?=
 =?utf-8?B?TW5KN21SZGFxbnlwK3FoMnJXakRsbUhOMkhqbFdhZXdZTTgzOWlxZFI1YlAw?=
 =?utf-8?B?Z2xRNmJpTlZVZERaQTdyOUtEaHQwRHAxQTlrelA4ZWhhMW50eW9kVnNkL3Iz?=
 =?utf-8?B?WlpMbWhESVhqWjlPMUx2eDcwemVON0xPYVpOSDNPdTNOSjlEYjJZN1lKR2Mw?=
 =?utf-8?B?YW96Q083dGk3Y3pubmtPV3R4dnVidlFQYWlzbDUxRzloUSs0TkVyR1hrZUEx?=
 =?utf-8?B?ZEdjUkpqVjJSVDc0N0ROYllvZUFUZnhZeUU5Z3p0bS9FcXBxN0FLeGtNanpi?=
 =?utf-8?B?UEQ2QXRTV1FyeGhDL3cwRXBaMDJaK0dCenBIZDJRSVAwWHFpc1kxSzVMOTJK?=
 =?utf-8?B?VlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2sJQcRBZdeAPJvynJc7tBIEnJU4ZHIjVcbnpGWN36ylCXFvx0QRdx2jy2r96xm+hI6S/LlYv9/XdwpYtiymmeGd8ThW9jt/NZAY35O4Lz9brCRhYzv48MSwIQemMXIs/cZu5AopMc1TcxzfycPZeoHk3S6n1mrTnHzmBEMHSB16Hv7WRYZgRp/oAaX5CQDB3VZyjFtHOGbqxm1JEz6gw1x3rW3GLWyPQo1sx6Yf0ygEPzWifJsAoGXgrl1clyKMoRCA++lEPI02BKqnNEsNb0YQ+gp600PH2QHaMS2huyrah2M0Ku14ZXhTN1u8IprBfdoZiF4T06Rnc55GkWEIaqETwntQuwLiyy9q2ASQGac9O1eBkcFrxlhcMNu9JJgHVuIY9zgDK+2Aj6SpzhoZNjGI8snsS8iGx4g5EIMcvxURLeHb/rgWelM8ksqooABu8zrGIGQJJDdnSCDF2BNtKn3bSHJbMVNhNTMkrd4dyskgRaFqkuhCuKTG/PELo+/9BSNLn6E8xV3RuGAy5qXsa/qtN8VohLdN/gGhXWUZBxBfAXmcSlOs6yCUxaMUHbOF1WX32v8oU1grV1J2NK8i2Ldk/JlyVouwbOFib5Ai+sboZ3MoYRwbLmcuim2m7aqdHWPbbYbnT07D3sYwWT0o7/DEB1wP8YFiFkCEZAKfYSUTAVJfScJEN/TuE7Jdmq3gMJOTJM7uIDK/2ON7N3jZsFUho23Fjw98nDsFEnEpAulMAAqBI6h7g7x3KlkexLHzPapY1N1GaXZ6nW2D60/G6e1rabtKKOq0hguFUx2IKS4nO5KW6Gn5qtjYmjME8P1WRfA6iwSxFDTKwp/X5r1P2HAfbvLzqeZoQsWFR2Row4ZA/9+kLQMyXLIhhVCnD6O8w
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f8466ba-7526-42b6-e952-08db24948157
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 14:00:45.0900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s0tmV0b5A304I5pZ0MecMrg0tiYLNgOk8OBoP4lKgxPksYb4NBJEacpn/aCeT/VyaX7xR+ckPw+yexHMRB7qUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6202
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 16, 2022 at 03:58:16PM +0100, Juergen Gross wrote:
> There is no need to have the functions blkif_get_x86_32_req() and
> blkif_get_x86_64_req() in a header file, as they are used in one place
> only.
> 
> So move them into the using source file and drop the inline qualifier.
> 
> While at it fix some style issues, and simplify the code by variable
> reusing and using min() instead of open coding it.
> 
> Instead of using barrier() use READ_ONCE() for avoiding multiple reads
> of nr_segments.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  drivers/block/xen-blkback/blkback.c | 104 ++++++++++++++++++++++++++++
>  drivers/block/xen-blkback/common.h  |  96 -------------------------
>  2 files changed, 104 insertions(+), 96 deletions(-)
> 
> diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
> index 243712b59a05..7561fdb72c13 100644
> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -1072,7 +1072,111 @@ static void end_block_io_op(struct bio *bio)
>  	bio_put(bio);
>  }
>  
> +static void blkif_get_x86_32_req(struct blkif_request *dst,
> +				 struct blkif_x86_32_request *src)

src can be const.

> +{
> +	int i, n;

Could we also take the opportunity to convert i and n to unsigned?

With that:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.