Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-221-gec32977366-fm-20230306.001-gec329773
Mime-Version: 1.0
Message-Id: <7ec48487-8565-4a1d-963b-5092eb5f4d15@app.fastmail.com>
In-Reply-To: <20230314121216.413434-1-schnelle@linux.ibm.com>
References: <20230314121216.413434-1-schnelle@linux.ibm.com>
Date:   Tue, 14 Mar 2023 15:05:49 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Niklas Schnelle" <schnelle@linux.ibm.com>,
        "Richard Cochran" <richardcochran@gmail.com>,
        "Paul Walmsley" <paul.walmsley@sifive.com>,
        "Palmer Dabbelt" <palmer@dabbelt.com>,
        "Albert Ou" <aou@eecs.berkeley.edu>
Cc:     "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
        "Mauro Carvalho Chehab" <mchehab@kernel.org>,
        "Alan Stern" <stern@rowland.harvard.edu>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        "Geert Uytterhoeven" <geert@linux-m68k.org>,
        linux-kernel@vger.kernel.org,
        Linux-Arch <linux-arch@vger.kernel.org>,
        linux-pci@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
        linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 00/38] Kconfig: Introduce HAS_IOPORT config option
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 14, 2023, at 13:11, Niklas Schnelle wrote:
> Hello Kernel Hackers,
>
> Some platforms such as s390 do not support PCI I/O spaces. On such pla=
tforms
> I/O space accessors like inb()/outb() are stubs that can never actuall=
y work.
> The way these stubs are implemented in asm-generic/io.h leads to compi=
ler
> warnings because any use will be a NULL pointer access on these platfo=
rms. In
> a previous patch we tried handling this with a run-time warning on acc=
ess. This
> approach however was rejected by Linus[0] with the argument that this =
really
> should be a compile-time check and, though a much more invasive change=
, we
> believe that is indeed the right approach.
>
> This patch series aims to do exactly that by introducing a HAS_IOPORT =
config
> option akin to the existing HAS_IOMEM. When this is unset inb()/outb()=
 and
> friends may not be defined. This is also the same approach originally =
planned by
> Uwe Kleine-K=C3=B6nig as mentioned in commit ce816fa88cca ("Kconfig: r=
ename
> HAS_IOPORT to HAS_IOPORT_MAP").
>
> This series builds heavily on an original patch for demonstating the c=
oncept by
> Arnd Bergmann[1] and incoporates feedback of previous RFC versions [2]=
 and [3].
>
> This version is based on v6.3-rc1 and is also available on my kernel.o=
rg tree
> in the has_ioport_v3 branch with the PGP signed tag has_ioport_v3_sign=
ed:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/niks/linux.git

Thanks a lot for the rebase, hopefully we can finally get this merged.
I'll go through all patches and note everything I spot that should
be improved. I'd like to make sure that at least the first patch
can get merged quickly so we can continue on the rest.

Since this is all related to asm-generic/io.h and cross-architecture
work, I can pick up anything that has nobody else maintaining it
through the asm-generic tree.

   Arnd