Message-ID: <57e05dec-1b85-1b3c-89c2-879fae97b941@oracle.com>
Date:   Tue, 14 Mar 2023 09:25:23 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v19 2/7] crash: add generic infrastructure for crash
 hotplug support
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20230306162228.8277-1-eric.devolder@oracle.com>
 <20230306162228.8277-3-eric.devolder@oracle.com>
 <ZBBPzKBTuzGZe4OC@MiWiFi-R3L-srv>
 <2fd31764-b341-638a-f70e-43dc0d5b0092@oracle.com>
 <ZBCDPuTdjMY+7VrG@MiWiFi-R3L-srv>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <ZBCDPuTdjMY+7VrG@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1VPdzZGdi9LekEwclVlNmxEK0hDY2pZTm5jeFNsWWxxaEtlSCtlaFk5U1ha?=
 =?utf-8?B?WHlOMmZ0c1p3d05SbUpMOHNscVVVc2YxaEZXeTNhSGN2M2lYY3ZPNUVsNEEw?=
 =?utf-8?B?VTBKNjczQ2kwakxaSDhHZVhYZEFvRmNldWk3NlZ2QUVJTDl4Y0RlcnhxRGtB?=
 =?utf-8?B?bUxoaXRNTWQwQWxxRmV5Z0tBWjJVVGp5WG5LdC9rM2l6SU1CR1R6SXF5ZHVV?=
 =?utf-8?B?aTFncTlVV0ptSWFqZkVqc1dsNmcvaGNuS3RKRTEzRUYwYjFQN29GWEdaTmNq?=
 =?utf-8?B?aFJJdU5iMU1lbXhuVTlVK3V6WHRWa3d3Rk1ra29sYVJ3YnhBbGtkOWJBTy9G?=
 =?utf-8?B?MlduM0E3ZjF6cUJDN3VHSW5wUVFHUjE0Z3NkaGhDZ0lsZWhRZitNM240STli?=
 =?utf-8?B?NkZJUEwzcTZhVkhJZ2pwR1lRQ2NqTzVXWmV2ck51OTdyUzh5M2hRK0RQR1oz?=
 =?utf-8?B?Z3VHVExTc2piS3dTMk1IUURCdk1GbVBBUGRDOCtaOS9mMS9GYzBVbTNydk5J?=
 =?utf-8?B?anIrSlpJVURpUFBlQ2plL3RvTnk0UXRLQ2lHRHh2ZlhWMDdwWUNWeWxmc1lr?=
 =?utf-8?B?YW5UQlBLbHlJenBLaUtLUldjM3Q2aXdmbDlRZEpyWVFvRGNHRjdpdHpiK2hP?=
 =?utf-8?B?NTFtQnNwclVhREtDUmpybmhMZllDUGFXTFZRRFM3WnlNcHROU1JwaHkyclQ2?=
 =?utf-8?B?T0NVMXphTXpoS21RWHVGOHJxbjVRNjhBOXdBS21YM3lWZVFWSWhaM0JSZjdQ?=
 =?utf-8?B?cG90UWIyUC9RdFludFVtcVUyVEM2QmlqeFRaTnd5aXg0M2hLK0hOTVYrdWEx?=
 =?utf-8?B?VXhjMHhMc213ZWs4RW9zU1gvUWNnNmo0N1FTd3kvRWhuUk9yT0Q3d05oMFUx?=
 =?utf-8?B?WStvMXNVYUdLdERUL2pYZmVLMkJESXNReDhmejJtZW5PR3lKZXFGa3NkUTIz?=
 =?utf-8?B?OEZFWVNFNlcxQnZ3ZVVSZ2tKQWhDWTlneVg0d05oaXFRa2ZXRFFxOEl5aCtv?=
 =?utf-8?B?Um8yZFF4K2RsU2FGN3dsSzZTTEZyZndISzB3RmlGUFN6MkJOWE1ZMVBld0tF?=
 =?utf-8?B?WjVwalF4WHpIVjhiMEdGcEUrQjJwVFRIYmhTTDZrOE9iY2YxMW8weG02Wmp4?=
 =?utf-8?B?MzR4VE1jNHphQUZXbEh5S2luTFRCWlRvSWlMeFVGU1FXMnRiaFRCTE9FQ25D?=
 =?utf-8?B?WStkaEd0NjBIZ0lCdmlGZUVaL2U4ME5yQnE4a0FZWjQwT09TZHFKVVAvaVNu?=
 =?utf-8?B?cnc5SjFPOUVtNHVMczhNcU81SmZxRjl1S1N2M2kwUzR3akhnNDZDY25oN2VW?=
 =?utf-8?B?YVQ5cWgwNFFnbURGQnNBZnZZbkYxcmJKTmgxSVk0eHlsbUJ2TEN2QWV5ZE55?=
 =?utf-8?B?R2FCZ0tyYnJUSUZYaTVPOXRtSm5LOHFpaHdobVluYkVKTHdVRDJWOXBacS91?=
 =?utf-8?B?NXpNbzJBVHBINEc3WjhvV2FwdEp6U05CRjlnNjBnVWQ4QTF4MGNRMmlFcEpv?=
 =?utf-8?B?M0ZDWHRsQ0M1VFNoOXVrYXRPQzBQTkdWQkh4OTJjNWw4NXlvNkw5TWJVeXJj?=
 =?utf-8?B?U29xRkp4Y2hiRlV3QjF6SncvSnlVQzFOYmg3dW1kVHZlOFM4Rm9wRjNHcU9K?=
 =?utf-8?B?UE83UEJ0UlUvWDFoUlZBK0ZyZ2Z1NWQ2SkZqR01DSEFpVVMrTzFmaHJBN0Vi?=
 =?utf-8?B?aTBkZTR3dEVHTkk3NzJJZWdjMHVkQlZSOTR6WThDN201bWdxTzhqUlBHTmJO?=
 =?utf-8?B?YTlWdWZBWmlxeStPNmxCWGt2aHhRY0JpZDBJL3VnVkJ2ZVU2Qm82M0pUaFNz?=
 =?utf-8?B?U1ZrNE5WOEhJZ21MKzNwdUNHV28wODZtek1mNG5YS3htYXo4ekozbU9XMUxl?=
 =?utf-8?B?YllFUDg3LytXcUZjdkR6NDJlMUZIL0w3TW9kRXlYNGhIN2ZVbWZoNG9xcjlF?=
 =?utf-8?B?dDVkUnAxYzhmRDRJNTd2QkRsRzlpSTZFWU83V1hDRkRUWk5WaS92bTZiejRy?=
 =?utf-8?B?MmFJN2ViTUhRSzJKMFpxMWVYcGVDMC84RlZIR2lGYmVFUzNob1I4dlZibUZE?=
 =?utf-8?B?ZjhnSWw0UlQwc2ZQMXk0TlhmMmhyMkplaUFiZkphSnBQWmRZa2tQYWVCa2tJ?=
 =?utf-8?B?dXNuR3BOL3pRY0V6WTJMRUFYd3gzckZMRHRWdjRBQjFiSmd5NUFHM0VIVkw3?=
 =?utf-8?Q?JAFa9OHGAh6WAQcI/kFITpY=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?S29XcjVaYlJaSWlTQlV5WEl6ZDNHMVMybmtlbWxaTEVLMncrR24rTVBlQzdn?=
 =?utf-8?B?YlZkYWw4eWZ6bFRBVFBrME93czgvdGlTRVd2RnZNMjNxWDFmbTlqemVWS1N3?=
 =?utf-8?B?WXE4MEl2cnRnQWhmc0I5ZTNvMVp3U3NCcXZwZG56WFFEdms0REhMQ0dBMWp6?=
 =?utf-8?B?MHIwRFF2VDd6a2I0YWxLeThSV09mSHpUM29mWURzSGwxcFRhYXZhWnU4MGo5?=
 =?utf-8?B?eEhyOVhwL0JlUE40cWVjamY0QzdJaGRidHB2aEhyODcwTW4rME1wOFFkQVpi?=
 =?utf-8?B?THp0LzA0T1RpOTRKMU1uNlBjeDAxbktYMld2b3NZcGx6bFNYdjJ5MHZ0NWtl?=
 =?utf-8?B?bkt2OHFHQ2xJSUtySHlGbCtZR3hFSFJUbCtSWm81MkwyZjNsaE1Uci83ZXhF?=
 =?utf-8?B?M3hPWlYvZzc1NFZ5L0xXQmN5akdibDREenEzc1ZLenZEV2xuT01ROWtNdUk2?=
 =?utf-8?B?T3lZRVRKemxPWG53VDFKWEF5STFKZ25sR2tTYzEzRnAxMm1GZ3ZkcS9ZNFJz?=
 =?utf-8?B?akhsTUVYR20vME8yL3kxaG5NY3hTSVh2Vm5ZUzJ3MllFUGFpM1FkNS9VTUVF?=
 =?utf-8?B?Qm1vcExPWnVIVWlOVlZIVUl5bFlyd2JzSjVianpmSTRLbTBPcHlDL3k1NFV4?=
 =?utf-8?B?VUF3cjJtWjFFT1h6L1RPS1ZZQVFFc2JwUzZRdFF6L0h0MUtCbHZmU3B5OSs3?=
 =?utf-8?B?KzkxRVRiQnZlV2FjU1VpaDVVRFFHTTYyZ2FPdWJPTXJRQytEM1BFb1luUTV2?=
 =?utf-8?B?RDF1U2JyMldOK3k5WjhUeTByLytkOGR2UjVRbEFUNk5KSEl0aFRFeFF2d2Nr?=
 =?utf-8?B?V0ZrWTRJM1Rvb2VEZmh3NGE2aTBzSG90WVlYSUlBc0pMbjA3UlFxaFN6ajBw?=
 =?utf-8?B?dzkydzljL2M2Q0lyMkd6SnAySEJ6K2p3NGtLK0ZHaHpZRXpEVTBDeW80Q3ZK?=
 =?utf-8?B?djMzRElrMkhGTi9ZQWpSVHdoWnVGOE1GYUdEOTBoeHlnWk1sYkMwclpEbkU0?=
 =?utf-8?B?MnBvb2c2ZjZCd0JKQlNrSG1hb1k2RHo2U2t3T0ZNZ3E0a3VIdXZmNXpodllU?=
 =?utf-8?B?L0pNTG4yTDJIQ29GUVg5eWIyR01VdHF1di83ZDUwM3dSNWZid0lsUk0zMHFa?=
 =?utf-8?B?UGRTdGJ5K2lJQ3dSNWFuUVdkUE54MmhTV1d0c2c4R1NjRTRYVnhwbWZiZmZ2?=
 =?utf-8?B?RkRQOURXVlJHMVBQS25KWi9XNEF3WitYTVpORGlVU2Z3cUxHMUFqVDR2eGpO?=
 =?utf-8?B?b2F2L3VPZzlkMnZsWElYSFdQTGZwUkVKdEhXOFZQdjJnMkRsZHJQV2l6TjRl?=
 =?utf-8?B?VytOc3g0RUNIVEE3L0JXaG4xVk92amhocFF1SnhyeVV1YjJDSHp4bVhUMDhN?=
 =?utf-8?B?OFFZY0ZuaHBtY2ZqM0oyK1VjU0lES2JGOXFWUjliSVNMV2RLOEJKcWVub2Vy?=
 =?utf-8?B?UUZtcDIydEdsVTl3dHdWcG9wdlNvTFA1ZjRpbURvYnM5THVWRXg0aUNENFdx?=
 =?utf-8?B?eDMxdWc3T0xPTDErYkI0RG9FQ1BSUy9QYVJ6NHhKNkJxS3Y4N1pCbk0xTVJ5?=
 =?utf-8?Q?dr9qC4oahe/eG9GTzQFmB00z4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78b45037-b26a-4fb0-4700-08db2497f6fe
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 14:25:30.7609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nZMHL72uSfU+Nx8WMKDDXPg1BF6ymH7e9AMIlS+XrXbXCU9aTM6rqEnzHXM3/llhtHX3dDvhjY7sRKR73DRlonxotWQh3OZhtxF+a7hitxI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6645
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-14_08,2023-03-14_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 phishscore=0
 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2303140121
X-Proofpoint-ORIG-GUID: PRmwuLuhRWkTWr6FK5ag_22USwQs_q6g
X-Proofpoint-GUID: PRmwuLuhRWkTWr6FK5ag_22USwQs_q6g
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/14/23 09:22, Baoquan He wrote:
> On 03/14/23 at 08:28am, Eric DeVolder wrote:
> ......
>>>> +static int crash_memhp_notifier(struct notifier_block *nb, unsigned long val, void *v)
>>>> +{
>>>> +	switch (val) {
>>>> +	case MEM_ONLINE:
>>>> +		crash_handle_hotplug_event(KEXEC_CRASH_HP_ADD_MEMORY,
>>>> +			KEXEC_CRASH_HP_INVALID_CPU);
>>>> +		break;
>>>> +
>>>> +	case MEM_OFFLINE:
>>>> +		crash_handle_hotplug_event(KEXEC_CRASH_HP_REMOVE_MEMORY,
>>>> +			KEXEC_CRASH_HP_INVALID_CPU);
>>>> +		break;
>>>> +	}
>>>> +	return NOTIFY_OK;
>>>> +}
>>>> +
>>>> +static struct notifier_block crash_memhp_nb = {
>>>> +	.notifier_call = crash_memhp_notifier,
>>>> +	.priority = 0
>>>> +};
>>>> +
>>>
>>> Because for_each_possible_cpu() is taken in
>>> crash_prepare_elf64_headers(), x86 doesn't need to respond to cpu
>>> hotplug or doesn't do anything with this patchset. This cpu part in
>>> infrastructure is only for the later powerpc usage, right?
>>
>> That is true, yes.
> 
> Given this patchset is aimed at crash hotplug on x86, while obviously it
> does't need to have the cpu hotplug support on x86 since the
> for_each_possible_cpu() adjustment. People looking into this may be
> confused if they don't follow the discussion thread of v18. Do we need
> to mention this in cover letter or somewhere else? I could miss that
> though it is has been told, please ignore this if yes.
> 
Good point, I'll update the cover letter to reflect this.
eric