Message-ID: <a4b422c6-eb08-89e5-9c97-4e0c4d0f8f01@suse.com>
Date:   Tue, 14 Mar 2023 15:33:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into
 blkback.c
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>
Cc:     =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
        Jens Axboe <axboe@kernel.dk>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
References: <20230314142741.24917-1-jgross@suse.com>
 <20230314142741.24917-5-jgross@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20230314142741.24917-5-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1dNam0zWWREVHZVOGVGSmRhQnVXMzJYekVtRFQzOUlNVlJWLzdseDlWNDhL?=
 =?utf-8?B?K2IzR1FYSHhQNTJxN1B0SjV2L0JMRFBtMFdPVDBZdSt0eFBDQklVL3h0b1BT?=
 =?utf-8?B?NmMvT1RyeDNYdW4zZjRDeE1kRWVuRkhOY3lVL0g3NzdpMFVZTldIQkxhdy9o?=
 =?utf-8?B?Q0NQOUdEUmxybjNZNStEdlVLMk5FaUJ1YzBqOHNtdVp4R05hWVg5eGVlUU5M?=
 =?utf-8?B?TWVVRk1jYUVhMnhSZERkbG5JQmdDbnlWVGJqa2lISTVsSjRVREtFV0xoQmRw?=
 =?utf-8?B?U0k2NkRkOExDQXVPeW8rL0ljZ0habHdnUEhzdmc1MzlHclM4Zm5WYldKSkxT?=
 =?utf-8?B?ZnUvRENScUxZTUJVRWpZeTRUZC9jZFVXM1FhKzF4elNFd1dyS3luMlNVdW9B?=
 =?utf-8?B?OVhCcDdBRUpudHQ2ejR2Y1VnVzlJb1puNkY4ZGdwdlpFSXNoNkY0bEQ0Z0ND?=
 =?utf-8?B?SUtVVlhqTWppU2ZLMUpJc1pxcE5sZmNqYmZDSWpocjFlRGMrSEZybDEwSnht?=
 =?utf-8?B?TzV1QzY2cFA0bTNzRG94L0U5ajBZaUsrS2l5SmRJQVFuTXpTUHFLMzdleVJy?=
 =?utf-8?B?VFA0NityVFFGak1vdHFkazkzNS9LKzI0bVQvUTFlblZTd3haSTJ1d0dyUzdC?=
 =?utf-8?B?ekttNTlsS2p5VWxrSEJDdUFhamFpZEtndmc4NEFHaUZ1ZnhCcXJRQ2hYYkg1?=
 =?utf-8?B?RGF3Z3FnREIzSTN5a0ZPK0hZVllma2J5M25GdWJ5WlROd0R6Y2ZDTmlENGZ5?=
 =?utf-8?B?Qmx5R0crdE52czdkb2F6cG1vbDY5MTlaRVA1aGxyV29wOGJxWEkyeWt1OS95?=
 =?utf-8?B?YTR2ZXlyUXFTc0VHeU5WUndHM09ZNEt0dlJPNjFtQ0poeno0eTZRUWdFbjFm?=
 =?utf-8?B?NzZMWStRN0w0TjFtT0FPQU4yZWlGeUVHUVVSNFdWY0FKczFpU0dYS2t3Q2Jo?=
 =?utf-8?B?WTU3K2taREJFL0E2WDdUd0JBemMwZkt2cmNRblRmUis2WUdQNStubTRRNVFy?=
 =?utf-8?B?Q2F3RWNHVktIWUhZYzNTbVAybmk3Sk5STkRSNDdudWFHS2t0bUJPMGdXZXMr?=
 =?utf-8?B?Q0RBRTZweC9oc01DU1dUdncyRkxIeWNJWUduME4rZUR1TVBrTk14Q1c4eVZh?=
 =?utf-8?B?TktoaSt2ajlTa1hjTms0ZnBvemRCYjNvMkRXV2U1bmJEUURqbE1kam9QOEVX?=
 =?utf-8?B?TzB3dHAwcjB6U2xMNjB1SmE3MU0yQng1VW9jemRWMUxJbWxUVXJKeDNNb3lV?=
 =?utf-8?B?WnBiQmszUXg2TWdBU1Q4NFYzVWtLK1RPOW05REZuNDhURDhaUlBIQXJXWHhK?=
 =?utf-8?B?NW9nTEMxUUJwUlNUZWJxOUdMdVJtM2NsQWNrTlptbmtLWlowalJpdUdPb0Ru?=
 =?utf-8?B?S3U4b3Zkb3BmQmNZTFFudVJqY0FvTllrN2Z6ZlMzMWVpVWU3M3drSTU2aEJy?=
 =?utf-8?B?T0QvWm4wcndGUWRRTmVGekNNTmtYSlZFL3I4RXk5ZkpQTjRYRUJXZ2pMbGsz?=
 =?utf-8?B?T3VPTFg3NWRQZmJCWElHa2hUeFFqV2xkRzZkTHk4d0RYbmcvelcvTklJNktt?=
 =?utf-8?B?UHRxeFJGM3dBM0JVbGxmdnBTWXd0SXJqQUNSSjJDOU42Tmh4anRYeko2MXNj?=
 =?utf-8?B?TW53U2lML015R2JNNGYzU1pMdHNpaEhXRDRGVFNEUU9nOFgwTGtGaHZSNXBV?=
 =?utf-8?B?Z3owT1dQcW5uSG9ENE9xVUlobWk3UkdMOUo4c0pyQThLQnJPZUVjbDhPZVdt?=
 =?utf-8?B?ZnNXMjN4TjR5M2V2am15REJZdDg2c1ZUbVNxOUQrNEc5RGs0K3ZWdlVCWFFq?=
 =?utf-8?B?d1Q2Rm9SNmhzL091OFY3azRjWUlkd0VqelNyeWV5TGF6cU1oQ1NsTFovZjdl?=
 =?utf-8?B?RjFibjFXYU5mYUlLczJ5UTJ1dDhnWU1TNldPRUdLWGhWNWkxNDlIaTRkTXJj?=
 =?utf-8?B?cXU4WVRjZjNpMlpod24wK1JsYytTcFk2OGJOWEJINGpGdnByK1lmektIcE1F?=
 =?utf-8?B?dkRydkovMk1qSlFOdmVpTStLbW5kbm1kRm95MXdJTDV1WEdteG93MnVySTZT?=
 =?utf-8?B?dG0rRC9VK210U3JJenh3Y3ZLa3V5aEZyZi96R1h2dTZjeDR2cUVOM0l0Ym5j?=
 =?utf-8?Q?uIw4pGLecMmCSjMOs7XcJmg8G?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20f3ebef-483a-4af2-83bf-08db249914ad
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 14:33:30.0131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EdgCr+P2wTxOeAuHoX3hsggjqAQMO6WAakwZrXPVwoLH9d4P2kPqopex1tnAwlNufrn3zmpktHJAVUYL4Bkh5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7160
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14.03.2023 15:27, Juergen Gross wrote:
> V2:
> - add const, use unsigned int for loop counters (Roger Pau Monné)

Hmm, ...

> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -1072,7 +1072,111 @@ static void end_block_io_op(struct bio *bio)
>  	bio_put(bio);
>  }
>  
> +static void blkif_get_x86_32_req(struct blkif_request *dst,
> +				 const struct blkif_x86_32_request *src)
> +{
> +	unsigned int i, n;

... here you did, but ...

> +static void blkif_get_x86_64_req(struct blkif_request *dst,
> +				 struct blkif_x86_64_request *src)
> +{
> +	int i, n;

... what about these?

Jan