Message-ID: <ee4dbb15-30c3-259b-3ae7-4f7ad4898d33@ti.com>
Date:   Tue, 14 Mar 2023 20:05:12 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add device id
 property for mcu_navss
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>,
        Siddharth Vadapalli <s-vadapalli@ti.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski@linaro.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <srk@ti.com>
References: <20230314104055.1475054-1-s-vadapalli@ti.com>
 <20230314104055.1475054-2-s-vadapalli@ti.com>
 <20230314132922.ejbutfxt7z7xhqgm@danger>
From:   Jayesh Choudhary <j-choudhary@ti.com>
In-Reply-To: <20230314132922.ejbutfxt7z7xhqgm@danger>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 14/03/23 18:59, Nishanth Menon wrote:
> On 16:10-20230314, Siddharth Vadapalli wrote:
>> The "ti,sci-dev-id" property used to indicate the Device ID is missing
>> for mcu_navss device-tree node. Add it.
>>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>> index 93952af618f6..52311da15579 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>> @@ -212,6 +212,8 @@ mcu_navss: bus@28380000{
>>   		dma-coherent;
>>   		dma-ranges;
>>   
>> +		ti,sci-dev-id = <323>;
>> +
>>   		mcu_ringacc: ringacc@2b800000 {
>>   			compatible = "ti,am654-navss-ringacc";
>>   			reg = <0x00 0x2b800000 0x00 0x400000>,
>> -- 
>> 2.25.1
>>
> 
> Looks like
> https://lore.kernel.org/all/20230313104721.407071-2-j-choudhary@ti.com/
> is another part of the Fixup?
> 
> Why not squash the two as a missing ti,sci-dev-id for j784s4?

Okay I will add this to my series and re-roll v2.

-Jayesh

> 
>