Date:   Tue, 14 Mar 2023 14:40:32 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     linux-kernel@vger.kernel.org
Cc:     linux-tip-commits@vger.kernel.org,
        "Borislav Petkov (AMD)" <bp@alien8.de>,
        Tony Luck <tony.luck@intel.com>, stable@vger.kernel.org,
        x86@kernel.org
Subject: Re: [tip: ras/urgent] x86/mce: Make sure logged MCEs are processed
 after sysfs update
Message-ID: <ZBCHYHq34nlLlXKc@yaz-fattaah>
References: <20230301221420.2203184-1-yazen.ghannam@amd.com>
 <167865351393.5837.17719714572303479044.tip-bot2@tip-bot2>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <167865351393.5837.17719714572303479044.tip-bot2@tip-bot2>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iod0hOg9eiTUj1q1LckNsJwatYGw/Kjs19ro5WCl/7D1GGoU+hpOzsLgXNwP?=
 =?us-ascii?Q?wkvAllLaNlXRR6ulibKLW3hMwmY/D+dGBMuss6PhcmvCz6XIoAeNPGsnVe4X?=
 =?us-ascii?Q?73D4nfRXkmyf3GiF2La+oWfR/YaFTBl0H2BAciTdMRZ6Fg3bUjQG/NjJujmt?=
 =?us-ascii?Q?1u8gB9+kFX/QohPt9VNrOFh8XseGIxz/eHZMRyf34XFXozecW7z9ogNHmr6/?=
 =?us-ascii?Q?yySjIi7MLEqebl112jlkJJLu/RzxFDmJ+eqVHuuPVky9P1iWLQF+9+9woy6x?=
 =?us-ascii?Q?EzLB73/mxl75RB2+gIEkOx3hrv0v25wB8qDd+RPz3ChcQdl/w+wuN3fBCfx8?=
 =?us-ascii?Q?V9tcxObo8QGb+Qaao4S3ptAk5jA77UGeppYCpSHYX5bVmHhLi24u36V65ugM?=
 =?us-ascii?Q?Tb5xRjHlYmHl2mQq5jDLRy/JXcrzPMWg96ZOrQB6Or7dKXX8QL8vP2B4uFjw?=
 =?us-ascii?Q?XPjMZdWeBchXvijBxwY1HJhNdDlj6cw9GGF+duE0SeGMQlQ9aVejEg0dhgf1?=
 =?us-ascii?Q?La+RaAqzbQy9JfWaahpIcbwfNxRQ/dDgBUYJAWAgQhHkpxiChGzjUCCc5E4h?=
 =?us-ascii?Q?OYp5boLDVZlMJuKe2FdRzeSNALarIVsOYQN0CzJxQ91FvSShDBtOOqwCp2fP?=
 =?us-ascii?Q?+KUGm7BGsQaJUr7K95FvLU5RdaB9zqo15Uci/VALq9WpPA/enqS7/z/rZ34A?=
 =?us-ascii?Q?eMQtPq+ZpPwBaUKlAWPIGY5qx3v6ZaYye707aFMYlmKkgfO09kAYstFgFUNm?=
 =?us-ascii?Q?guemvBmV5V80AGmMJFWZDVxiRgsNIujU6/1slNjEEZ8sVLgqf2rmsGVlTYHD?=
 =?us-ascii?Q?DpP9sc7B6+7hgQvQgl/mmP66RCgLfaCzQDSQ1jKzSSOHg/XB4IS3ifPSx9Fh?=
 =?us-ascii?Q?b5lmHseJRhVwq6BLBbw/gZpCLbbdxTvqaW9hTMBjjCjmqT3npfUcxtxUTnSZ?=
 =?us-ascii?Q?BEq49IOvk2u/ul0oFxY4CWwVwo1jVBlK/dSOMM+cR6CDc+MjNEo2300Yh/sF?=
 =?us-ascii?Q?tmAQFlUg72JPSDa9HjzYNSlGLebMQziZmBbpHehXgSFKSJFQGHQta2Xni3aO?=
 =?us-ascii?Q?S/xCq43/bn7hBAOZj25iTg25oVEi2IiPz5fgXBwqRrXlvCuYvDm86AzoqF3f?=
 =?us-ascii?Q?703dyzO7RSRRHryNWyIi3XqKZc+li8JB4ukELT6r40g/8sMRKxZ43hA22iRn?=
 =?us-ascii?Q?J1hz+Ci7bJd3tUG9uS9mXys3nZcTtHEZNIf3CS8/AMSbOZtdXbBvgaEIaNoi?=
 =?us-ascii?Q?VC9RdDvGtmDo1pCUHotmjUBcNoaJC6kbSaKgnrCceLnYDnBXhF/UdwX/iuSy?=
 =?us-ascii?Q?LJZtmj6TexErI0YHwDVO454jTKAwhCpV7MgXFm7L0iLhLZHGXUj4P/WkCVwT?=
 =?us-ascii?Q?L4R/xe3YeFP65j0hotmzyA7vH3qDNyqrZKf1IAhZcCGQfDDdLkuxTjqw8PtR?=
 =?us-ascii?Q?QH9i1sauYKKE9LzFAZIT+ZhL7g7evZrJHo+grLOSn1Ush/K+Oy3abomUS29h?=
 =?us-ascii?Q?mX1lZ0cYJek1H8QgV2z54E6dzGnE7mcGOlWVlKoBrAQGiPW5HwMPl63V352y?=
 =?us-ascii?Q?53AkepGBHQpQAXymiNDhjf35SCf8REpa97p5Wr3o?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d7d431e-e41d-4360-de92-08db249a12a1
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 14:40:36.0312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q5n+LZJ3bWiWC3kUq8KEshSjs4M7cF8VNw87MrtLEzLvIFg8WKGW1YmV4tkvKuEKNxgBkPIbRQLdPPhklvJJ7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5429
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 12, 2023 at 08:38:33PM -0000, tip-bot2 for Yazen Ghannam wrote:
> The following commit has been merged into the ras/urgent branch of tip:
> 
> Commit-ID:     4783b9cb374af02d49740e00e2da19fd4ed6dec4
> Gitweb:        https://git.kernel.org/tip/4783b9cb374af02d49740e00e2da19fd4ed6dec4
> Author:        Yazen Ghannam <yazen.ghannam@amd.com>
> AuthorDate:    Wed, 01 Mar 2023 22:14:20 
> Committer:     Borislav Petkov (AMD) <bp@alien8.de>
> CommitterDate: Sun, 12 Mar 2023 21:12:21 +01:00
> 
> x86/mce: Make sure logged MCEs are processed after sysfs update
> 
> A recent change introduced a flag to queue up errors found during
> boot-time polling. These errors will be processed during late init once
> the MCE subsystem is fully set up.
> 
> A number of sysfs updates call mce_restart() which goes through a subset
> of the CPU init flow. This includes polling MCA banks and logging any
> errors found. Since the same function is used as boot-time polling,
> errors will be queued. However, the system is now past late init, so the
> errors will remain queued until another error is found and the workqueue
> is triggered.
> 
> Call mce_schedule_work() at the end of mce_restart() so that queued
> errors are processed.
> 
> Fixes: 3bff147b187d ("x86/mce: Defer processing of early errors")
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Reviewed-by: Tony Luck <tony.luck@intel.com>

Thank you!

-Yazen