Date:   Tue, 14 Mar 2023 15:44:03 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Jochen Henneberg <jh@henneberg-systemdesign.com>
CC:     <netdev@vger.kernel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "Ong Boon Leong" <boon.leong.ong@intel.com>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 1/2] net: stmmac: Premature loop termination check
 was ignored
Message-ID: <ZBCIM//XkpFkiC4W@nimitz>
References: <20230314123759.132521-1-jh@henneberg-systemdesign.com>
 <20230314123759.132521-2-jh@henneberg-systemdesign.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230314123759.132521-2-jh@henneberg-systemdesign.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j6IHCWO5u6OEyIq3zF+PQJgBChxuqpyv8Wmsny58GfSL9VZ1JCEi8QBCpRoW?=
 =?us-ascii?Q?W2eCpTsEYljAcUEPB+UvVhUNVTiKsTT+/EISym/+8v+4UcDT/N3boWROFKwX?=
 =?us-ascii?Q?bERZ/WAp16BtNQno6N2JAiEqh7wXdllmfRHhG7NZo/mTUvpxb7DEW1qszTze?=
 =?us-ascii?Q?4bLKGNDdRL5uTmIdoRUSjdf/z3XSgmtxQSE3xDoAmsl3mH9mcptvC37HCV7G?=
 =?us-ascii?Q?xdr6APyenBchw/bjeYNYjI2p2qx2ns/ArAsHaOLPh3ESBeeYJRKWn/QR1D4O?=
 =?us-ascii?Q?p/AbimPhq0a096/auILzE2rQ6fLh44y9DosMfLIkEPcgJpKsNSmPoqmxuos+?=
 =?us-ascii?Q?6cHkpyznBJhwPSibRKBhubfLUopCeBiCzGrzWGKWnzyTtIbiTbdAISqJA73m?=
 =?us-ascii?Q?xyc60oRCBp+Iue7S+/oCmFQr5K19vWHHsh3nMMlmJ9MFU8sKAw1HrN1bQ9H2?=
 =?us-ascii?Q?1WJqb3lKC8oVgfoZ8VyJVfD3fNTQZ/8GLYJEvwg8GkCB7sfbeRnsZVVbb9It?=
 =?us-ascii?Q?CQZ/vmfxeAptvNstwBC7UUouJQknpttArhpI23+FosgPWawJL6QtaHzWyvDf?=
 =?us-ascii?Q?7W7snO8E/I+CLejXOSgWNyLTNDeLig5xYypFqVvyolkXxFxGYDgCQoknhNpg?=
 =?us-ascii?Q?wHfyQLJCpawLKauNwu3b52f5MTcq9GlGRZkBl9T5rjVqDA99vBX+nNGHwoMB?=
 =?us-ascii?Q?HQD6Cp9KamcteIdzHHf2gQVmNTuMsEo31Lv2H/K4SbLvVyJr9KCquIhNXq65?=
 =?us-ascii?Q?qsSVDR4fFz98p4WhtaOafR/S1im6F9T7hMAyKD842cqrgoi3emdDXq6jQNBE?=
 =?us-ascii?Q?pSj/BkBZADIqZAqFOPqxHNLkbj3H+p/PA7DTz7qb//w/Dn1LwSJrghNSEq9T?=
 =?us-ascii?Q?7x2c6/gvB+oweqBLCk2y4eB39hAW5SPsdgsAIDAPZ27eQ2hjc9CMjQwXebzF?=
 =?us-ascii?Q?sMsizYF1xHXm3UyAGsICqNDVnaGG9augtknuAQsbhgo+z5zFeoO30VVzH2Cv?=
 =?us-ascii?Q?icDue8IBB2Y9HpyNg9KjQQExJYslRhsHHhDyQ+y3SltD3zKBDYcuzbQ0wZfQ?=
 =?us-ascii?Q?HXGsjmNvZ+KcDOr0+2W3n8mnyNDfm/jow1WsDG1JwJS02OJGTovPACXp2sJw?=
 =?us-ascii?Q?VMAlh/Olk4sKfD585l1PJgGeRzf8GRceMQ7xsVsYb+LxUROXUmZ0Zm8TgMoL?=
 =?us-ascii?Q?2KrdcrnhSMmRaojwxkqOAtYB/dAEY4Zd+RyYkzmPqvbWd/bPma6747ugcyGH?=
 =?us-ascii?Q?n7kxtI7NKwGwx7hbEYAHZZ5hnd8c4/u6wofbuc250fhzQfxMg00YnQ3QNSn5?=
 =?us-ascii?Q?d2GYqaWcP2nZrHRHhfJDxNqW9s54ccEW0A3jXPiawHFFxrCsR+g+1Fz4i3sw?=
 =?us-ascii?Q?VJZ0I4wSqNRn8+g4Z2RBl33BzbYaT3essa3tJQLzRMxQJQ03x8iTeDQoo4x1?=
 =?us-ascii?Q?7VHK725LnSaLbnxPSw/n1z3T/ngWozfE9G5VwZvqDVPOzLQD27lglYJ+HWxb?=
 =?us-ascii?Q?TswTHoyVkJgZrTOHjYC/R/2T9ZeNL2hmN+m+RPWFOnfsK+fuebPNAVpcb12R?=
 =?us-ascii?Q?/CNNbvL3svdpFesG3PJ19QCqZIyV9lXq1g0XNo/Uf4RCRVo1myMKvkx0mFSH?=
 =?us-ascii?Q?BA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 04a2c033-411e-4ee4-a848-08db249a91d2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 14:44:09.7979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PSFl0vJpgy/X9pxklVes4mEQQWuwDYtbSuNl2kcs1+eG26J5doCQ709aBou+gyTU4Or8Buelb1RV18RFvnAqv/2QWSylF3uSkKn/90sfz2U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6794
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 01:37:58PM +0100, Jochen Henneberg wrote:
> The premature loop termination check makes sense only in case of the
> jump to read_again where the count may have been updated. But
> read_again did not include the check.

Your commit titles and messages seems identical in both patches, someone
may get confused, maybe you could change commit titles at least?

Or since those are very related one liner fixes, maybe combine them into
one?

Also a question, since you in generally goto backwards here, is it guarded from
an infinite loop (during some corner case scenario maybe)?

Other than that looks fine, thanks.
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>

> 
> Fixes: ec222003bd94 ("net: stmmac: Prepare to add Split Header support")
> Signed-off-by: Jochen Henneberg <jh@henneberg-systemdesign.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index e4902a7bb61e..ea51c7c93101 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
>  			len = 0;
>  		}
>  
> +read_again:
>  		if (count >= limit)
>  			break;
>  
> -read_again:
>  		buf1_len = 0;
>  		buf2_len = 0;
>  		entry = next_entry;
> -- 
> 2.39.2
>