Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754779AbXIQO2k (ORCPT ); Mon, 17 Sep 2007 10:28:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753806AbXIQO2c (ORCPT ); Mon, 17 Sep 2007 10:28:32 -0400 Received: from nz-out-0506.google.com ([64.233.162.232]:27334 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692AbXIQO2b (ORCPT ); Mon, 17 Sep 2007 10:28:31 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=P0YdOPT3yIkRudyQXkURiaLhnXzVXmJFP4VjrWrM3jS5yWQrmg5daIA98yLdyWQ3SB1lSx6Nt9avWHnheS/xwaNU0Oi18rKP975ZVweBiCPPoIqpfJJ7JJYabbcLCyz3JlF2yX10idVsW5YSlS2nriiCOzLQpl5V7f5m/fSKbDc= Message-ID: Date: Mon, 17 Sep 2007 07:28:30 -0700 From: "Ulrich Drepper" To: "David Howells" Subject: Re: Credentials test patch Cc: viro@ftp.linux.org.uk, hch@infradead.org, torvalds@osdl.org, linux-kernel@vger.kernel.org In-Reply-To: <19877.1190026932@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1577.1189713412@redhat.com> <19877.1190026932@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 13 On 9/17/07, David Howells wrote: > A better way would be to compare fsuid/fsgid to uid/gid and to just take an > extra ref on the incumbent cred object if they're the same, rather than always > allocating a new one. That, I suspect, would speed up 99.99% of the cases. Indeed. It's probably rare to have different values and for the case I mentioned even more so since it happens before the first user code gets executed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/