Date:   Tue, 14 Mar 2023 15:35:15 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Sakari Ailus <sakari.ailus@iki.fi>,
        Nicolas Ferre <nicolas.ferre@microchip.com>
Cc:     Eugen Hristev <eugen.hristev@microchip.com>,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
        luis.oliveira@synopsys.com,
        Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller
 driver
Message-ID: <97746427-c373-4e49-be8d-31a22ece30c7@spud>
References: <20221216143717.1002015-1-eugen.hristev@microchip.com>
 <20221216143717.1002015-4-eugen.hristev@microchip.com>
 <ZBCCmWQ8lM/wfexr@valkosipuli.retiisi.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="8J/HusImJ6ezRElp"
Content-Disposition: inline
In-Reply-To: <ZBCCmWQ8lM/wfexr@valkosipuli.retiisi.eu>
Precedence: bulk


--8J/HusImJ6ezRElp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 14, 2023 at 04:20:09PM +0200, Sakari Ailus wrote:
> Hi Eugen,
>=20
> On Fri, Dec 16, 2022 at 04:37:16PM +0200, Eugen Hristev wrote:
> > From: Luis Oliveira <Luis.Oliveira@synopsys.com>
> >=20
> > Add the Synopsys MIPI CSI-2 controller driver. This
> > controller driver is divided in platform functions and core functions.
> > This way it serves as platform for future DesignWare drivers.
> >=20
> > Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com>
> > Co-developed-by: Eugen Hristev <eugen.hristev@microchip.com>
> > [eugen.hristev@microchip.com:
> > Add format SRGGB10 to supported format list.
> > Write the data type to the correct register DATA_IDS_1.
> > Changed dev_info to dev_dbg to remove extra chatty messages
> > Avoid overwriting static array of formats]
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > [luis.oliveira@synopsys.com: Add MIPI CSI-2 platform data]
> > Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com>
> > [eugen.hristev@microchip.com:
> > Add support for periph clock and phy clock
> > Fix enum_mbus function
> > Implement get_mbus_config
> > Implement media controller
> > Update to use fwnode API
> > In s_stream, first start/stop the sensor
> > remove chatty 'number of lanes' message]
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > [conor.dooley@microchip.com: fix potential uninitialized variable use]
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > [eugen.hristev@microchip.com: port to kernel 5.16, 5.17]
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>=20
> Same comment than on the 4th patch, this isn't very readable or relevant.

I'd imagine it can just be collapsed into a Co-developed-by & a signoff
as we hardly need multiple w/ the same names & companies involved each
time.
My "contribution" here (initialising some variables) doesn't warrant
inclusion IMO.

Eugen doesn't work for Microchip anymore though, and I don't know what
the plan for continuing the upstreaming of this driver is.

@Nicolas, do you have a plan here?

Cheers,
Conor.

--8J/HusImJ6ezRElp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZBCULgAKCRB4tDGHoIJi
0iXuAP43K8ntq9hXNbCfFEVPAXip9/lwYTQwOWcfU6wbxAHrcwD/TZa0zkYCap0q
qTYag3lIixUkXWo4nH8aVLD7SH3EngQ=
=e0GH
-----END PGP SIGNATURE-----

--8J/HusImJ6ezRElp--