Date:   Tue, 14 Mar 2023 16:42:43 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Eric Dumazet <edumazet@google.com>
Cc:     Gavin Li <gavinl@nvidia.com>, davem@davemloft.net, kuba@kernel.org,
        pabeni@redhat.com, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        gavi@nvidia.com, roid@nvidia.com, maord@nvidia.com,
        saeedm@nvidia.com
Subject: Re: [PATCH net-next v7 4/5] ip_tunnel: Preserve pointer const in
 ip_tunnel_info_opts
Message-ID: <ZBCV8/IFqiNr8Hr1@corigine.com>
References: <20230313075107.376898-1-gavinl@nvidia.com>
 <20230313075107.376898-5-gavinl@nvidia.com>
 <CANn89iLDUR_3pmxco47VQkvWweq2g4Og6UhtLN1gQMQiCUy2KQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CANn89iLDUR_3pmxco47VQkvWweq2g4Og6UhtLN1gQMQiCUy2KQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG9INzlxTVFvdURnaWZ4RFNGQ096SkdnMkNjeitiSTM4KzlFRDFoWjkvU3RS?=
 =?utf-8?B?Y1R6Z05DYVFLeTQ2eUc5Vk5uOHFUeExqbkhYM0E3a3UzM2did3ZZcHhJTVIr?=
 =?utf-8?B?NXVRbDk1WVlIdjN4VThSYndWaXZ1N0VBL1M2ZWt1bkNHai9WamJKVkRCMXYr?=
 =?utf-8?B?Ly9PdHlUYTJvb1RqTnVPSkNpWVRpMXB2dldlYjI4QU1xaFo0MGdzWGNUVlhD?=
 =?utf-8?B?WTZoRTF5Z3RXVERYZDB2bHZoelVMTkZqc2lpYXlUdGR4a3FSeUs3Wkd2M2Ex?=
 =?utf-8?B?bFJTM05aY2xKSmc4MjZTeEVMeFI4NFMyQ292d1UvUlVKMUpQRStuYnNRUnll?=
 =?utf-8?B?M2V1SWgwT1R3U2g0cHo1L01IVGowM3NaRVVYaUMrSVJyU25aNDhPRTNxWVRS?=
 =?utf-8?B?KzhIOGJWa2xHbUx1MzhrMzg1YTRuQ0lUYjNSSEYwMzVXRnpubkw0RW1iemZs?=
 =?utf-8?B?UkJkSHFNbTh1RkZRRGJsVmdXYmJZbmo4WG1kSWpXbXY3TVNyMk1yeGtTdkxV?=
 =?utf-8?B?b2RQWXFJeDBhaURySEduOVNZQmtFQzhZZVpPN2xlaXNTSzRRTFBHd0JZcEpy?=
 =?utf-8?B?TkN6UU1qOERQM2JVNm1pVVFaM0I5VWpLU0hNNmF2VHlqRW9nUnFrU2tqcElE?=
 =?utf-8?B?S003NGorTFpmbHFJVy9Fd2dHVUJyOXdjT1poU2MrOElHYThxT3doTFlwaUxs?=
 =?utf-8?B?bVlsOFc1ZEhOaUFDcHJhczJqYnVCbXRPVWp3K0d2QktraEVtTllha3Rna0pF?=
 =?utf-8?B?d0w1ZDhXOXp2amI0bW5UbDUwcFdCek5yTTdaTHV1bkFLeVlxQ1BZODVKaURo?=
 =?utf-8?B?UU1yVkxGTlA2NmJJbmh3V2dXRTBSdjEyK3VvKzJUVWZWS3Z4b25Wb1YweHl1?=
 =?utf-8?B?M3d0MmRjQlJ0MEUxbkdwaGNnajJBekt1c0RZc0hCQnowdmlvSWRjV2N0ajhL?=
 =?utf-8?B?VHIybmpEd2dVaS9ZRmY5RmVCaUkvMGd2R2dvV3pKeVdXOERFdVZEMFVyOFZR?=
 =?utf-8?B?azc1YkhMeDRUUmx0ZzFOeG5VVFhEMkY5ZEw4UGNxU3g5Mk5wQ1I3TTY3VU93?=
 =?utf-8?B?Rk10NzNuK0pnUXRVRk1OZGZ1K2lldzYwcTJUZS90NS80TEFjY0tlRy9VZHdY?=
 =?utf-8?B?S1lWSGpLcGxTYXNJckd6QmRoNTJ2V2h6LzhTNDFLVGFJYXM0amdIU2VGVnV0?=
 =?utf-8?B?cnBta3RxZEdKVmVtN05YOEJPMytWVW1OQmVhSUN1WEVOeWU5VHhTQXJrUDlv?=
 =?utf-8?B?VE1iaVdzSnBaOGxBVFZTSjdWVFV1MkoyVUJTUGdETysrVVd0Mm5sSEhBSEdY?=
 =?utf-8?B?RzVSS052YjNBV1BUaDM1QTlTT09ZYm1KUFAzVldOQnhYY29OR2dibG9YU3Vy?=
 =?utf-8?B?cDh0bUtlZkF2dm16ait3MmNYbkI3bDdmMm8rN2tKWmllV0pwVlh4SnNZWnlC?=
 =?utf-8?B?S2lOdjIyWkt0TDdscElmYTJoclROVDNTOWtxaFlNUXNrc2Z0ai8zNitZT3I3?=
 =?utf-8?B?Szl0SE92QTcvN00vNUlQVzN4enZQVTJPTDEyQStneHVHbkhYMk5JaFZINlB1?=
 =?utf-8?B?Y0lvcktkYnpNRDRIZWYwa2JORzJ0UExHbU9HczhjKysxWWJaZXhTV2NtZDg3?=
 =?utf-8?B?RGRGYmlTb0Q5ek94SVpRV1J0LzRYTEUrVGFEVUFZNGRVZDZld2lvNHlnZmVS?=
 =?utf-8?B?NUxmTHRvU1R6dDdjVm9yTXJaQzUyV2pwM2dRVVAvYTVvc1V5YkNNODRrSDRp?=
 =?utf-8?B?bUd0VE9BWUQwNG9XMWNhQUM0VXRRRnFZdEk3M1dhOXp6Vm1WKzJtM01wRDEx?=
 =?utf-8?B?NFFydWlnTVF5cWdEQnd6a29rOGJFelUzdzdHQ0dIb091SFIzS3pNSjhKL21k?=
 =?utf-8?B?VVdvOU5jVXhRL0IxNGNQNkZQNXJRWDdkQ25nV3NFc1Ewd0NOTVNEMm55MC8w?=
 =?utf-8?B?aDFwSnF5b1hIMWpHdklhSU92bmxFYWFYZFFhV3NEbENSdnc0dzVuMm9URnQ2?=
 =?utf-8?B?WkhsKzdyYmZ3Rm9BZVgzN0V1ZGhZT05YUmYwSk9yK0dtODRtbHFob2lvQ1Vy?=
 =?utf-8?B?aVZoSHpPM0g2cU9SNUNPNk9FV08rNm9nbXE2dUVLWEFpbkFiNUdLNmRaMGFh?=
 =?utf-8?B?enpmM2tuckFPM0lqTnBiY1RRYUx2V0VzeG5XeGlQMzYyTkxndFhSaWFCWVIw?=
 =?utf-8?B?VUlKdGFiUzRoaWQ3YmZEcGRSQlI3dWl0eEw1VEx6UlRsMkIyZk5TczdLcG5V?=
 =?utf-8?B?MUcrZTF1cHN6MkllZ1VhSm0vY3RBPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c853e79-7e42-495a-2b41-08db24a2c457
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 15:42:50.3374
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6Iph4gvwH3P4a9w7zRUsYQ9zZgimeBlozzj2AT9d9Wv2sZBFLt6vmlFzdE/qqqZyQRfUEsNRDX2aT0Aet9CBreX36sUtzrflhP2VZ1PgTss=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3669
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 13, 2023 at 07:57:23PM -0700, Eric Dumazet wrote:
> On Mon, Mar 13, 2023 at 12:51 AM Gavin Li <gavinl@nvidia.com> wrote:
> >
> > Change ip_tunnel_info_opts( ) from static function to macro to cast return
> > value and preserve the const-ness of the pointer.
> >
> > Signed-off-by: Gavin Li <gavinl@nvidia.com>
> > ---
> >  include/net/ip_tunnels.h | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> >
> 
> Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks Gavin,

this addresses my concerns.

Reviewed-by: Simon Horman <simon.horman@corigine.com>