Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9FDC6FD1F for ; Tue, 14 Mar 2023 15:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231301AbjCNPqB (ORCPT ); Tue, 14 Mar 2023 11:46:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbjCNPpm (ORCPT ); Tue, 14 Mar 2023 11:45:42 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACBA4241D1 for ; Tue, 14 Mar 2023 08:45:12 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id cy23so63687977edb.12 for ; Tue, 14 Mar 2023 08:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678808708; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9SCxm8iOPdeAsY0TXKkmz+2L6YqtA1AyHrADOlfOy2M=; b=MMo1OJO3T9Nigf+1XIH5iFNEn34rcy5D7wJEjCFOHC0ELhrtCGc1gCr5H0WcvRV2SV 4VIFJIorbtD+zIdzgVpvL2gxAIsYEpFrObnIPjET/KGvx8opBDVvaze248ARPx8WXynr HjL/KAjUHXMop4VvxUAK08t0piegvCbRoQ//nwYHz4sXv9f2nxffibebOYMmU+yIwO5u occqSWuo6Pks4aJ6YD+exboTAcqFw/BUnMe/nQwPMR3ka3GuA0kJYJf08aSNquzbPw7x WNpbyfEFxUHpQXKQynNQJSHn6OHMsGPRHsrQ6AbXkx5iFA12MZAKm4HkbpdJXRrtSxVQ cF1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678808708; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9SCxm8iOPdeAsY0TXKkmz+2L6YqtA1AyHrADOlfOy2M=; b=vzXSosiCDJ1eofyvGQK07kM3vzopptC4nQx6XNCXJvl/9SwIaIw36VZUfbyWxavl11 yfiJw4rvBiS0j89kGGjsP6uFveFT5WlYTCK1RHLYsHzrhBlkskLZjpSoqGF9PxyrSln0 NfnuLsHQms4WgO8mgHfido9ew29ynnPnV1CWBsTbCyudWcJdqIQ3ljODHZj5eAUPWHl9 9tJbO2uAHntBPraOAsHjbbFjYPg0HgutdkKygdtBRStXVICYpWAO05hMMgeoKs3xtzvD K36P+CnCQ97RF3E+QBBhBSfiWLIyWIYYfxKhtWpmh0NFcwLXv+GqNq5lNHg77qIYR7lp zvCA== X-Gm-Message-State: AO0yUKUUj7OdWnX+JFzHlRSI+1LF9Y1M7SvTRIAv7TXU+1l6nFDttkdW G4I0D8MCaTS440XWUu59TH+o3Q== X-Google-Smtp-Source: AK7set8h0VXGHjuQQFT+Mle8JiJQKMLwlt57Og4xS6JoJpZR63ktbj9TcT7GX03JVYWtZRtR9FLqag== X-Received: by 2002:a17:907:1608:b0:92b:a511:c19e with SMTP id hb8-20020a170907160800b0092ba511c19emr3656998ejc.34.1678808707877; Tue, 14 Mar 2023 08:45:07 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:59be:4b3f:994b:e78c? ([2a02:810d:15c0:828:59be:4b3f:994b:e78c]) by smtp.gmail.com with ESMTPSA id w23-20020a50d797000000b004fadc041e13sm1221690edi.42.2023.03.14.08.45.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 08:45:07 -0700 (PDT) Message-ID: <1ee7386b-f42d-a182-f42d-c1f628fb4dda@linaro.org> Date: Tue, 14 Mar 2023 16:45:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH net-next V3] dt-bindings: net: ethernet-controller: Add ptp-hardware-clock Content-Language: en-US To: Jakub Kicinski , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: Sarath Babu Naidu Gaddam , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, yangbo.lu@nxp.com, radhey.shyam.pandey@amd.com, anirudha.sarangi@amd.com, harini.katakam@amd.com, git@amd.com References: <20230308054408.1353992-1-sarath.babu.naidu.gaddam@amd.com> <20230308054408.1353992-2-sarath.babu.naidu.gaddam@amd.com> <20230313153532.2ed45ddf@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20230313153532.2ed45ddf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/2023 23:35, Jakub Kicinski wrote: > On Wed, 8 Mar 2023 11:14:08 +0530 Sarath Babu Naidu Gaddam wrote: >> There is currently no standard property to pass PTP device index >> information to ethernet driver when they are independent. >> >> ptp-hardware-clock property will contain phandle to PTP clock node. >> >> Its a generic (optional) property name to link to PTP phandle to >> Ethernet node. Any future or current ethernet drivers that need >> a reference to the PHC used on their system can simply use this >> generic property name instead of using custom property >> implementation in their device tree nodes." >> >> Signed-off-by: Sarath Babu Naidu Gaddam >> Acked-by: Richard Cochran > > Rob, Krzysztof, any thoughts on this one? > Looks like the v2 discussion was a bit inconclusive. Anyway this did not implement changes I requested, so NAK. Best regards, Krzysztof