Date:   Tue, 14 Mar 2023 16:56:53 +0100
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
        <kernel@pengutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 0/4] net: set 'mac_managed_pm' at probe time
Message-ID: <ZBCZRYSOCBvG8O2u@localhost.localdomain>
References: <20230314131443.46342-1-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230314131443.46342-1-wsa+renesas@sang-engineering.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z4O95wUWOFe4xhXwsl/R64EiDM1atpHoGatqg7GA6YXBR4ujx7R82qLpxpPd?=
 =?us-ascii?Q?tZe/N1/8TcQmcUEBkkrVildzlGJED604TPVNQM1UIcW6NhyLWv3UltXKgl53?=
 =?us-ascii?Q?aQSZNRgZ+67ot4lM6cd7u+S0pO3tnmHLTNGZLh2IsEJqKhjg1M38WHo0Mclv?=
 =?us-ascii?Q?eGOVTvU62UeDpp0MbErMhf+lxCxhvsJh/BkoncigNMgab4szKEqaLjQF8fOk?=
 =?us-ascii?Q?OtdNhTHNTELtAtGo4PPf9cipeFmYemiKbGaOQqsS5O8inXUMKAsVisXOsMF0?=
 =?us-ascii?Q?RmdfMOfXpItgyONn6nRoEtqXaEDgWMcJw8qir67D/DYXmnSooeKOIdwVYaMs?=
 =?us-ascii?Q?MQpAUKv8OEc+J8lO+DgFi+noe3MMI5ydnfedJ1jOjfmbKCHgT22ejOZ7+USA?=
 =?us-ascii?Q?ZzU2LV+/na6w9AuwPrbVCg/UDNEstROc6mZKXJRUGRa3trmpy5pjgIcFHWjy?=
 =?us-ascii?Q?O929YxbREEDiQERqPsiLbPMnnB8dApxzFiTD8sB/PVsL5+79a06gg0EzQEhC?=
 =?us-ascii?Q?fgCul93PeVesagyvEPLMSG4TTM9c8nG1XG4tTWB97Wo5rdNjBI7zHGLxdMH0?=
 =?us-ascii?Q?61pwp22kQZk5uy1xuw7ILp8DqwdQ1K87//LGphoN69A7QOxpvNfDDtqlyUk9?=
 =?us-ascii?Q?NePnyQ45z+vWkaQ6SldTBPsi592Z5fBBBPJ1aMbOF50XFr8zIIt2z3HFGlnO?=
 =?us-ascii?Q?z0+9oZjci1Bu+jWg0YG4Cv2EpFslXj9I5rY2V9n/zHGUsVuXLmKFQsm59rhv?=
 =?us-ascii?Q?1IXfv56OfrBfqboo5hiBRzHy74DMAh2nsf3aIJyBHNhFUmCjx8B72pRrbpzj?=
 =?us-ascii?Q?F5gPh66OQS5pokMQP17w10ygpGNKZ6T83pgKlGL9A5h0ltJqcpzJl/EKtAi8?=
 =?us-ascii?Q?XSSgSbHM9mWUsiJgd9FSc4iTgHuVVBg0pZ8hjlaWWegP2m02h4yxuJZhFlOl?=
 =?us-ascii?Q?cnG0gPwLLeaa836sDySgVi4h7aJF6+66bjgzZPuxUZ/IeMszT3FTHnUXZorh?=
 =?us-ascii?Q?TaUNZMaczhwO8U3Zd7tJ4WtgavHDlZxZbuxdB6160PG58QL3WNLbzzOavOsX?=
 =?us-ascii?Q?ta/xBDGROxVGYCySPpxqEQIxF7mAYclVW/WhPXqZG3FFa8h1pM9Hd5DLrjhz?=
 =?us-ascii?Q?OYMpReOZFWsndndAldGa2pkLyZb4xSUNJJZjok7mZ+0L8oGICajjF+Ms3Q2K?=
 =?us-ascii?Q?nepvnsgomz18AdzlGU+D/MQaO6pWknIVIQD+cKTvVcjd+/xTTdZEgqf+I5E1?=
 =?us-ascii?Q?esp7SB3Z1JM3GkwimQbsmHPFd7kcAxYXV4ECnyYwqeBZWy0l+XeeRh5YWdB6?=
 =?us-ascii?Q?VA+2qpYbHRsL09OCwaViOIZ7hNXzd2zM6+JK4MvG4tmLlsdDNhYNiGxUl/4u?=
 =?us-ascii?Q?af+pE2UmiNxs+EDWC4yIwXFGOgVGlAV6yC/0M+GsXlUqw4TBtmsAkdpif7wL?=
 =?us-ascii?Q?psdyv8ZRUfdL5TPIh5jl1/b7VDANgh1kgt6yg5h+otSV1uKRmmHcyVo6URpz?=
 =?us-ascii?Q?pTqVutViv54Jh+5GESg+XSzEXyySc8RVjJJbHO9LAPXJuquDpdPQvNjdxOZ2?=
 =?us-ascii?Q?57cBTZoY9MWCLTaKNhKAKNTS1O0LZQHPXhxIGJXe0GafbYlrCe+FM4G0rwzT?=
 =?us-ascii?Q?QQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d5eb03b-ecf0-4333-0f95-08db24a4c17c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 15:57:04.4926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YIUGvymTcdf7x0aZDpvOfdrUNOAzTSyLjkprcbMDbBiHcXS+hQACwm8nPefT9wVG3/arBLIcqupB9IDUmobgHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7144
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 02:14:38PM +0100, Wolfram Sang wrote:
> When suspending/resuming an interface which was not up, we saw mdiobus
> related PM handling despite 'mac_managed_pm' being set for RAVB/SH_ETH.
> Heiner kindly suggested the fix to set this flag at probe time, not at
> init/open time. I implemented his suggestion and it works fine on these
> two Renesas drivers. These are patches 1+2.
> 
> I then looked which other drivers could be affected by the same problem.
> I could only identify two where I am quite sure. Because I don't have
> any HW, I opted to at least add a FIXME and send this out as patches
> 3+4. Ideally, they will never need to go upstream because the relevant
> people will see their patch and do something like I did for patches 1+2.
> 
> Looking forward to comments. Thanks and happy hacking!
> 
> 
> Wolfram Sang (4):
>   ravb: avoid PHY being resumed when interface is not up
>   sh_eth: avoid PHY being resumed when interface is not up
>   fec: add FIXME to move 'mac_managed_pm' to probe
>   smsc911x: add FIXME to move 'mac_managed_pm' to probe
> 
>  drivers/net/ethernet/freescale/fec_main.c |  1 +
>  drivers/net/ethernet/renesas/ravb_main.c  | 12 ++++++++++--
>  drivers/net/ethernet/renesas/sh_eth.c     | 12 ++++++++++--
>  drivers/net/ethernet/smsc/smsc911x.c      |  1 +
>  4 files changed, 22 insertions(+), 4 deletions(-)
> 
> -- 
> 2.30.2
> 

Unfortunately, I wasn't able to check the series in terms of content, but
I have no objections to the logic and coding style.

For the series.
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>

Thanks,
Michal