Date:   Tue, 14 Mar 2023 17:13:06 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and
 tcan4553 variants
Message-ID: <ZBCdEr/W6ZHjqTEq@corigine.com>
References: <20230314151201.2317134-1-msp@baylibre.com>
 <20230314151201.2317134-2-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314151201.2317134-2-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w/OtrKptWW78mWcvTYy2W5NUCt7hd82SSMNNPt9ThAeV6Vdyjlp/pBjIONuU?=
 =?us-ascii?Q?UbLj7wFKGOhg9wrOYZ42LSC0V5dNIY+lI0VXG4xc9w08Xc504u3+tQq70st5?=
 =?us-ascii?Q?/+JkmpVCy2wrdS7TL9zegbFJobI7kyaqshsb38ldMMwmLSAYKA4M1uNg8VBf?=
 =?us-ascii?Q?z3aae14llox3emb5oe1dr2I+WRskaemHR82K84QtRfrAJF/xvmad3z3g4qAG?=
 =?us-ascii?Q?XkHoXHpwZhCxXp3Trz+mb/3f7YZJcfJb/oX8QVom19nNBkE16yCCEIRDWFpc?=
 =?us-ascii?Q?5VoTVTeN/R73gfUyQuPSQvJaIuGkaKaUcXylElII2kQ3L4m4pmm9/c5TuxNv?=
 =?us-ascii?Q?zo5MYhBNnwAbimTTLZ5Vid7P9GasVPRq5JIZUlZwQrru9UkNd4ivYnRzEdp1?=
 =?us-ascii?Q?yYeMgZJ4eo8cOlqXsYgLCHBZSg+FlwK5AHEpRlD/0Wq2vnfclg5JZErvbaJd?=
 =?us-ascii?Q?SwFUdI4ws4nsRpJNftWbKAfap5/JEbeSG2PSgJhDMnc2tZXv29DpYKp4PGbe?=
 =?us-ascii?Q?qr3cui+GkO0tn+jt53P67KsrSLlhucULHXp2pTpJp5p6PoRd1sjfmr+dSZgY?=
 =?us-ascii?Q?8qoRQwsD+oeXacPUsqNIkDg79oDkghGfWpN4SKWhAGiyjXQ5HDSShv9qVkr2?=
 =?us-ascii?Q?nuzo4WZoR6URDIegtjiVLaO8dBs16QNilyJ1/zyJtXhAwqIJtqySTmMbcXYB?=
 =?us-ascii?Q?eGUZHQzmur9VyAn+0yQjl3StwTftZ7gnOeTslH4nRK40JF0bePlfL5jRgvb+?=
 =?us-ascii?Q?0/rQ2JCb4VZ6JqDmSgj8Z36xJjTYmY1fdFsajn5YzIRIU/agRCjAS5DbC9RL?=
 =?us-ascii?Q?pKv5JvsRM3ZqXFBN450Xqm4d8/BdoWxlAzMsxnNzSS3clqUjAZq7pPCJjhnG?=
 =?us-ascii?Q?JLgc4c0KoaatheX2m5hzARN0qUFE80dPQDoTHT5fxHQu1XpfhGVIa3dW9GvB?=
 =?us-ascii?Q?flckv20p5EVCK8CeffcNEcUkFEShNLgIw7aV3A5Vx1Jw24ytUoFAFxCGsYhE?=
 =?us-ascii?Q?ZmXm8vTSTjvrM8iGlkxbTzaEC4zfNmiVq2FYA1ofv3gv1+x5IaLB8i3EG8C4?=
 =?us-ascii?Q?gmL7qxKpTpdomahjvZmgE2l/otBWk3xOtrJn4NSyl7tvMJ/3AXRqgLaKepVi?=
 =?us-ascii?Q?NCmCnjSCeAyPetyz1KynAhDRxn0SyOYbJSfBEbgID+32uB0SYJBgLziBCQj5?=
 =?us-ascii?Q?rFhnjhnG3S0daa7+c1GhU74zDHKuTHX9H+nBj+h3VJ6K8NiI9MPeMSZh+K/j?=
 =?us-ascii?Q?t4H9dduiWmCjhiooFqs8pogMVOYzNg5cy1vu70oivv0F8Iw0F3mrEWLfEJPf?=
 =?us-ascii?Q?OP6jB+amhqA2VEpmCEhfBlCTur+9371PIMzB8G/OSa85+xCogmw2D/gaGyMh?=
 =?us-ascii?Q?YQgs4AoahkTjdlPUOL1NbOOQYLHmjHO5iZJnjiQKaBk+KxqQPtuQPDCrLJqI?=
 =?us-ascii?Q?UmAQTUKh6QIjsu5KivpnFF2+UORbzQZmoV2qkh8N1Hw40+LsVR2am5hIjPta?=
 =?us-ascii?Q?16jlhO+2KtA0lDuSFY8h5L4BCwQbvbdRzS4bXmx/a36OM1zlbZDAoaQ6EIVX?=
 =?us-ascii?Q?ON5x8D4+eH1cfmv0OT4jkv6T1dKrDKSyT439zWWt2wC2NSLfjeBkaxXRR1vi?=
 =?us-ascii?Q?2ZRqXAniGOg7p+6HVZ57Phqu8IA6aZYCqEGiEVfheI65lBkNedoBi5FwgYeh?=
 =?us-ascii?Q?3aeBLA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e01a35f8-08d7-4bfb-b7a0-08db24a7071d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 16:13:20.2458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FN99tpUe5EwqOUF4Vy/9RwgmwejHYrNuqvfLqA2kgyTF4QfTiPx85bNTulyF0qE7wr/HgSIv4QbRKR5H0HvEO3d5GstIDLpiKLHZCl0m370=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5365
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 04:11:57PM +0100, Markus Schneider-Pargmann wrote:
> These two new chips do not have state or wake pins.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

Not a requirement from my side,
but perhaps it would be worth converting this binding to yaml
at some point.

> ---
>  .../devicetree/bindings/net/can/tcan4x5x.txt          | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> index e3501bfa22e9..38a2b5369b44 100644
> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller
>  This file provides device node information for the TCAN4x5x interface contains.
>  
>  Required properties:
> -	- compatible: "ti,tcan4x5x"
> +	- compatible:
> +		"ti,tcan4x5x" or
> +		"ti,tcan4552" or
> +		"ti,tcan4553"
>  	- reg: 0
>  	- #address-cells: 1
>  	- #size-cells: 0
> @@ -21,8 +24,10 @@ Optional properties:
>  	- reset-gpios: Hardwired output GPIO. If not defined then software
>  		       reset.
>  	- device-state-gpios: Input GPIO that indicates if the device is in
> -			      a sleep state or if the device is active.
> -	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
> +			      a sleep state or if the device is active. Not
> +			      available with tcan4552/4553.
> +	- device-wake-gpios: Wake up GPIO to wake up the TCAN device. Not
> +			     available with tcan4552/4553.
>  
>  Example:
>  tcan4x5x: tcan4x5x@0 {
> -- 
> 2.39.2
>