Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <d6401cc5-990c-e46c-2d5c-148ce76c8b79@roeck-us.net>
Date:   Tue, 14 Mar 2023 09:14:50 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2] watchdog: ebc-c384_wdt: Migrate to the regmap API
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        William Breathitt Gray <william.gray@linaro.org>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paul Demetrotion <pdemetrotion@winsystems.com>,
        techsupport@winsystems.com
References: <20230314152916.185939-1-william.gray@linaro.org>
 <ZBCX0iVwYD4uVxwM@smile.fi.intel.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <ZBCX0iVwYD4uVxwM@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/14/23 08:50, Andy Shevchenko wrote:
> On Tue, Mar 14, 2023 at 11:29:16AM -0400, William Breathitt Gray wrote:
>> The regmap API supports IO port accessors so we can take advantage of
>> regmap abstractions rather than handling access to the device registers
>> directly in the driver.
> 
> ...
> 
>>   - Utilize watchdog_set_drvdata() and watchdog_get_drvdata()
> 
> I'm wondering why you can't use dev_get_regmap() instead.
> 

That function is quite expensive to use in code that is called
for each register access. Its typical use is to get the regmap
for a driver once and store it in a local data structure, not
to use it for each access.

Guenter

>>   - Map watchdog control registers based on offset 0x1 and adjust regmap
>>     configurations accordingly; offset 0x0 is unused in this driver so we
>>     should avoid unnecessary exposure of it
> 
> I'm wondering what bad could happen if you expose it.
>