Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC12C6FD1F for ; Tue, 14 Mar 2023 16:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbjCNQ1Q (ORCPT ); Tue, 14 Mar 2023 12:27:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjCNQ1I (ORCPT ); Tue, 14 Mar 2023 12:27:08 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 48E284FAA9; Tue, 14 Mar 2023 09:26:57 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1pc7UG-00048S-00; Tue, 14 Mar 2023 17:26:56 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 7B753C12F6; Tue, 14 Mar 2023 17:18:30 +0100 (CET) Date: Tue, 14 Mar 2023 17:18:30 +0100 From: Thomas Bogendoerfer To: Rob Herring Cc: devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: Use of_property_read_bool() for boolean properties Message-ID: <20230314161830.GA18446@alpha.franken.de> References: <20230310144656.1540950-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310144656.1540950-1-robh@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 10, 2023 at 08:46:56AM -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. > Convert reading boolean properties to to of_property_read_bool(). > > Signed-off-by: Rob Herring > --- > arch/mips/pci/pci-lantiq.c | 2 +- > arch/mips/pci/pci-rt3883.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]