Date:   Tue, 14 Mar 2023 12:31:20 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paul Demetrotion <pdemetrotion@winsystems.com>,
        techsupport@winsystems.com
Subject: Re: [PATCH v2] watchdog: ebc-c384_wdt: Migrate to the regmap API
Message-ID: <ZBChWA6aGLPZ/2vG@fedora>
References: <20230314152916.185939-1-william.gray@linaro.org>
 <ZBCX0iVwYD4uVxwM@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="IxJEXLiCa9EcaoIp"
Content-Disposition: inline
In-Reply-To: <ZBCX0iVwYD4uVxwM@smile.fi.intel.com>
Precedence: bulk


--IxJEXLiCa9EcaoIp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 14, 2023 at 05:50:42PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 14, 2023 at 11:29:16AM -0400, William Breathitt Gray wrote:
> > The regmap API supports IO port accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver.
>=20
> ...
>=20
> >  - Utilize watchdog_set_drvdata() and watchdog_get_drvdata()
>=20
> I'm wondering why you can't use dev_get_regmap() instead.

We can set `wdd->parent =3D dev` in ebc_c384_wdt_probe(), and then use
`dev_get_regmap(wdev->parent)` to retrieve the regmap. The only downside
I see if perhaps the added latency a call to devres_find(), whereas
using watchdog_get_drvdata() is just a pointer dereference.

I'm indifferent to either choice, so if Guenter or Wim have a preference
here I'll follow their decision.

>=20
> >  - Map watchdog control registers based on offset 0x1 and adjust regmap
> >    configurations accordingly; offset 0x0 is unused in this driver so we
> >    should avoid unnecessary exposure of it
>=20
> I'm wondering what bad could happen if you expose it.

The WINSYSTEMS EBC-C384 documentation I have does not specify what
offset 0x0 does (nor offsets 0x3-0x4), so I don't know if there are side
effects to reading those addresses. Really, I'm just avoiding the hassle
of writing an explicit precious registers table for those offsets by not
exposing them at all.

William Breathitt Gray

--IxJEXLiCa9EcaoIp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZBChWAAKCRC1SFbKvhIj
K+drAP9p43P0w0nREDtGKpEvbdiSQ+iGLMm+VukR4SVjeTLX0wD/RmCC9x7xhBnC
UJ0SEqq84HDKODsHYOZfWi6/AB8qSwY=
=PSAm
-----END PGP SIGNATURE-----

--IxJEXLiCa9EcaoIp--