Date:   Tue, 14 Mar 2023 17:40:47 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/4] net: set 'mac_managed_pm' at probe time
Message-ID: <ZBCjj6btYod38O7g@corigine.com>
References: <20230314131443.46342-1-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314131443.46342-1-wsa+renesas@sang-engineering.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QmBiL4953l1FllB94spdYmxDe9+o4AqtLPpvALnzGhOIuO6/NX+3s5mhhcLL?=
 =?us-ascii?Q?XTEEoRFz/pVOEJuKhIFiWn0IX38932tP1t8yn+oF7dB0dME53GJncbg2vm3p?=
 =?us-ascii?Q?sTrRAwtw+ik8yH3OHnsvFNBt5jvuA0+zXfX7IneV81qbBqlBIem+uEG+h7Fb?=
 =?us-ascii?Q?OADyQwvsmUmm6zGabSjaoMV25WJ96wM/4AdAEBeHCYi1wRkhqxxKY3M2u/Xv?=
 =?us-ascii?Q?5JvvmX8BxFZL0qy2AXjtIBVtjYeeig3AiJjo6ctAv+qNZO1NfSDysBJMSUMB?=
 =?us-ascii?Q?BQRyZ/Fl/a+LOT1cC9wXv3TnfyqbMKqdbmBTOCJ9Uv7az8Tq8qOG3JvyX33A?=
 =?us-ascii?Q?OUPtYCqUGfKziFOqm1RczLxH6Of7Br4kMRAXWHVlxh7LETJSBLXViD9Sta/f?=
 =?us-ascii?Q?uRYjdDL0IcP8E0VrF9Vz8TjH+aIRSJzZpoGA09kh+hd/vJnVOft4/Cazu9wq?=
 =?us-ascii?Q?SAzLhvN2DltTSZx14gd/oIc1Tbp+OhB7lCEddQRq1yyZIvE2BQbK1orC/Ekv?=
 =?us-ascii?Q?9e51zvw+p6X7c5Pvs7pvBzX+lN0WFcbnvBimrbT9bnGeFAOVlMyjn3d/9huA?=
 =?us-ascii?Q?IfDI/xCv3OVZr0vGNWEDpo7/oH4cyO8UDaI0w5aslkKlibzqKdEQU3kugMOU?=
 =?us-ascii?Q?bIFi8j5veuD8dtjml64siD5NYd3z2y2J5HbSD1iW8xflhrLdrbsq3SCBjCZu?=
 =?us-ascii?Q?88ES2uVuSMzLOe01CsrXoD/xE6CPrzRSScCTEwSjbfr1D1SEiVdkpKjI0aqx?=
 =?us-ascii?Q?/eoBjr0BmUPBbr6pVtrwhcS+BsMBggSIO8H1lOnRpQR038yc3lRJMYNIzBGb?=
 =?us-ascii?Q?FEQthQ9zOGhTHGnGBb9o0YFYKhBwOQxPhTG/dbCKRopvTHw9dz/JjOdINZYl?=
 =?us-ascii?Q?IZZN5/ufVHLGpTWqJVcOPwWqdQJntwNGUd4/D/+4mJIo/PNjyGcUXPD8OgGV?=
 =?us-ascii?Q?ajjNbT7w+FdVBCBrvZyDYPvHP4dpIKbWa9HvlVgNfeUsDE3BM4BFEe+mFR+Q?=
 =?us-ascii?Q?8M4EGSw3RmilgbCVz37um6Mjx6zOOXzB8YLHiTtmQfxTnYVeH8XPjFOJX+yV?=
 =?us-ascii?Q?/ACKYt6EzTK1+HGv4qfp7pPqmesrcCl0tHFvxU+feWIOlO3u6sK0vgVBXh5Z?=
 =?us-ascii?Q?qbCuoL5Q5FHzFi8RTw0by4fEBLsuArscZOB0t8d6TRJzWFuLYlG9l7OV4c86?=
 =?us-ascii?Q?phfLE1L282KuscFyGPK4Y1+2P3a1zH+wQQUv03jI6eQTvXCFSj39vanVT7CH?=
 =?us-ascii?Q?q5oUShM6tPkqiZsyv7axLuTDiVLQbwMRd0b4rRQOJPK0u7zrvJdl/wN4pKHH?=
 =?us-ascii?Q?yA+fcCwQBwDsZ7Vdgizp5aDqVJEWBu3VWM+zf6D5RerYxPHCaWIgBgmV18eo?=
 =?us-ascii?Q?Bg2KuLcoqu7rLn7uzGoiH+q0NnUzlrSuz08eh5QeNab7nBx07kWd8Wa1tcd2?=
 =?us-ascii?Q?hK0VmYdu8YxA+xt1ttxIaETeQK/64hKyGoHodrA2zpBgEWCWtKKj2M0GuUql?=
 =?us-ascii?Q?Zry/jPF2KOo8CWhvDKq2KaeEP56eOsrBxeJ3/EMRWd2Ba7WMQBeaz9r7pZw8?=
 =?us-ascii?Q?zMiedXjbv0jpoifCF5W/6eNk2TNJ8xZ4IOkyRic9hw2E5JQL0wzRWN+K2aD+?=
 =?us-ascii?Q?CEPrvsRaUt4xyUDxilU53TU03+6guQIUHSVVDEsNI5WZG08h3vd4VzAHCqHy?=
 =?us-ascii?Q?rAGFmw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8952b8a6-6978-408d-992f-08db24aae0ca
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 16:40:53.9358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U1gY8QZ9g0gksrGNO5x6XGO00M3hNQV5ffpqOyR1WVEZ+b7yH7/MFIegOyj4UKhvFF4YmXyQvom3CHw/VG1aQZg1thvjKbN+HcmCkSub5us=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4927
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 02:14:38PM +0100, Wolfram Sang wrote:
> When suspending/resuming an interface which was not up, we saw mdiobus
> related PM handling despite 'mac_managed_pm' being set for RAVB/SH_ETH.
> Heiner kindly suggested the fix to set this flag at probe time, not at
> init/open time. I implemented his suggestion and it works fine on these
> two Renesas drivers. These are patches 1+2.
> 
> I then looked which other drivers could be affected by the same problem.
> I could only identify two where I am quite sure. Because I don't have
> any HW, I opted to at least add a FIXME and send this out as patches
> 3+4. Ideally, they will never need to go upstream because the relevant
> people will see their patch and do something like I did for patches 1+2.
> 
> Looking forward to comments. Thanks and happy hacking!

Hi Wolfram,

an initial comment is, and I know this is a bit of a pain,
that 'net' and 'net-next' patches need to be split into separate serries.

And if there are dependencies, the 'net' series should go first, and then
the 'net-next' series should go out once the 'net' patches have been
accepted and 'net' has been merged into 'net-next', which I believe occurs
after Linus has pulled the weekly 'net' pull request, which typically
occurs on Thursdays.

> Wolfram Sang (4):
>   ravb: avoid PHY being resumed when interface is not up
>   sh_eth: avoid PHY being resumed when interface is not up
>   fec: add FIXME to move 'mac_managed_pm' to probe
>   smsc911x: add FIXME to move 'mac_managed_pm' to probe
> 
>  drivers/net/ethernet/freescale/fec_main.c |  1 +
>  drivers/net/ethernet/renesas/ravb_main.c  | 12 ++++++++++--
>  drivers/net/ethernet/renesas/sh_eth.c     | 12 ++++++++++--
>  drivers/net/ethernet/smsc/smsc911x.c      |  1 +
>  4 files changed, 22 insertions(+), 4 deletions(-)
> 
> -- 
> 2.30.2
>