Date:   Tue, 14 Mar 2023 17:50:30 +0100
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Waiman Long <longman@redhat.com>
Cc:     Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Shuah Khan <shuah@kernel.org>, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/5] cgroup/cpuset: Skip task update if hotplug doesn't
 affect current cpuset
Message-ID: <20230314165030.beu2ywtvqa3p45ta@blackpad>
References: <20230306200849.376804-1-longman@redhat.com>
 <20230306200849.376804-2-longman@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="unrarqlmrlmuhj23"
Content-Disposition: inline
In-Reply-To: <20230306200849.376804-2-longman@redhat.com>
Precedence: bulk


--unrarqlmrlmuhj23
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 06, 2023 at 03:08:45PM -0500, Waiman Long <longman@redhat.com> =
wrote:
> If a hotplug event doesn't affect the current cpuset, there is no point
> to call hotplug_update_tasks() or hotplug_update_tasks_legacy(). So
> just skip it.

This skips "insane" modification of cs->cpus_allowed in
hotplug_update_tasks_legacy() but assuming cs->cpus_allowed is kept in
sync with cs->effective_cpus on v1, it is OK to skip the update based
only on effective_cpus check.

Hence,

>  kernel/cgroup/cpuset.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Michal Koutn=FD <mkoutny@suse.com>

--unrarqlmrlmuhj23
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZBCl1AAKCRAkDQmsBEOq
ub7vAQDuvydF9uT/t92mbXmbdJFDwYtaoBzZSBR7muvk51dYZAD/VflSkqUiEoJf
DK7RTVV/JCWxbff4B8Ud16JHw7PsfQU=
=Phpc
-----END PGP SIGNATURE-----

--unrarqlmrlmuhj23--