MIME-Version: 1.0
References: <20230314114451.8872-1-lujianhua000@gmail.com>
In-Reply-To: <20230314114451.8872-1-lujianhua000@gmail.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 14 Mar 2023 10:12:02 -0700
Message-ID: <CAD=FV=X7K2KQoRCsr17kj-DWiPs7h_zfcYxK_cdBVnC0wR1NwA@mail.gmail.com>
Subject: Re: [PATCH] drm/panel: Fix panel mode type setting logic
To:     Jianhua Lu <lujianhua000@gmail.com>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Tue, Mar 14, 2023 at 4:45=E2=80=AFAM Jianhua Lu <lujianhua000@gmail.com>=
 wrote:
>
> Some panels set mode type to DRM_MODE_TYPE_PREFERRED by the number
> of modes. It isn't reasonable, so set the first mode type to
> DRM_MODE_TYPE_PREFERRED. This should be more reasonable.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
>  drivers/gpu/drm/panel/panel-abt-y030xx067a.c     | 2 +-
>  drivers/gpu/drm/panel/panel-auo-a030jtn01.c      | 2 +-
>  drivers/gpu/drm/panel/panel-edp.c                | 4 ++--
>  drivers/gpu/drm/panel/panel-innolux-ej030na.c    | 2 +-
>  drivers/gpu/drm/panel/panel-newvision-nv3051d.c  | 2 +-
>  drivers/gpu/drm/panel/panel-newvision-nv3052c.c  | 2 +-
>  drivers/gpu/drm/panel/panel-novatek-nt35950.c    | 2 +-
>  drivers/gpu/drm/panel/panel-novatek-nt39016.c    | 2 +-
>  drivers/gpu/drm/panel/panel-orisetech-ota5601a.c | 2 +-
>  drivers/gpu/drm/panel/panel-seiko-43wvf1g.c      | 4 ++--
>  drivers/gpu/drm/panel/panel-simple.c             | 4 ++--
>  11 files changed, 14 insertions(+), 14 deletions(-)

Can you explain more about your motivation here? At least for
panel-edp and panel-simple it seems like it would be better to leave
the logic alone and manually add DRM_MODE_TYPE_PREFERRED to the right
mode for the rare panel that actually has more than one mode listed.
That feels more explicit to me.

-Doug