MIME-Version: 1.0
References: <20230314134642.21535-1-clin@suse.com> <20230314134642.21535-4-clin@suse.com>
In-Reply-To: <20230314134642.21535-4-clin@suse.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 14 Mar 2023 19:19:10 +0200
Message-ID: <CAHp75Vc838SyGSRfnHEj4925efOhH3WwjVkdnGR+_a2VF3Z6gw@mail.gmail.com>
Subject: Re: [PATCH 3/3] pinctrl: s32cc: embed generic struct pingroup and pinfunction
To:     Chester Lin <clin@suse.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        NXP S32 Linux Team <s32@nxp.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Radu Pirea <radu-nicolae.pirea@nxp.com>,
        =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>,
        Matthias Brugger <mbrugger@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 14, 2023 at 3:47=E2=80=AFPM Chester Lin <clin@suse.com> wrote:
>
> Use generic data structure to describe pin control functions and groups i=
n
> S32 SoC family and drop duplicated struct members.

...

>  struct s32_pmx_func {
> -       const char *name;
> -       const char **groups;
> -       unsigned int num_groups;
> +       struct pinfunction data;
>  };

Since you have a single driver with this, just kill the entire custom
structure.

The way it's done in the pinctrl-intel.c is due to dozens of drivers
sharing the same data type and hence converting that will provoke
quite a noise for no benefit. Here it's not the case, so just kill it.

--=20
With Best Regards,
Andy Shevchenko