Date:   Tue, 14 Mar 2023 10:43:36 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
CC:     <rafael@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S. Miller" <davem@davemloft.net>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Alex Shi <alexs@kernel.org>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Alexandre Bounine <alex.bou9@gmail.com>,
        Alison Schofield <alison.schofield@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Dan Williams" <dan.j.williams@intel.com>,
        Dexuan Cui <decui@microsoft.com>,
        "Eric Dumazet" <edumazet@google.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "Hannes Reinecke" <hare@suse.de>,
        Harald Freudenberger <freude@linux.ibm.com>,
        "Heiko Carstens" <hca@linux.ibm.com>, Hu Haowen <src.res@email.cn>,
        Ilya Dryomov <idryomov@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Iwona Winiarska <iwona.winiarska@intel.com>,
        Jakub Kicinski <kuba@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Jonathan Corbet <corbet@lwn.net>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        "Michael Ellerman" <mpe@ellerman.id.au>,
        Paolo Abeni <pabeni@redhat.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Wei Liu <wei.liu@kernel.org>,
        Yanteng Si <siyanteng@loongson.cn>
Subject: RE: [PATCH 23/36] driver core: bus: mark the struct bus_type for
 sysfs callbacks as constant
Message-ID: <6410b248e47ca_58a429425@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230313182918.1312597-1-gregkh@linuxfoundation.org>
 <20230313182918.1312597-23-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230313182918.1312597-23-gregkh@linuxfoundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PAy2RRQG1E/Abwr4YuuSQPAvOJbR+8GenTH+pm8ueAJZcFf3TBUpT0ZcQH6e?=
 =?us-ascii?Q?jsC17D1iy7wScnvxN222KbIdkhPZ1gvdf131CjV5hYBPmcq9om4MeOviIvjR?=
 =?us-ascii?Q?ikuqr5zEUfKXYD9fSZjUXwm/I15VPIoA1exdTnD+9/pWQPqRcXw58ub6FrbM?=
 =?us-ascii?Q?rE0MFMo7ta5vQjK6ZWeu3DzSdXZMVpmUtCpjL8zj0amUn8Fyvyk1BecHtqMJ?=
 =?us-ascii?Q?mtvEV82LdocOhKdZSTyv43FLFSdu1ksUFW/9V1w4dDHr4HiO9lMfYNor8Oyr?=
 =?us-ascii?Q?YXR4Vx0uVPWyJ14RehFN+FRuURSnv5hmHjzJ7H7LwTL4fkTMwrXD4zw/Y8v5?=
 =?us-ascii?Q?7dtZrNI2w+/ihKbHMXbTS2GfRb7YRh3wMj1gZXM7ULHVZtGGwcTRJrKzvJdS?=
 =?us-ascii?Q?Y+6twgLb9MizIWfuGjCGGEYjH5O47g54VWIAwyvsWI+mTcEFzy7uQy1KphNW?=
 =?us-ascii?Q?EX1xrytLx5szAJZAE2LjW1PfplqcQf3NnqVEHQYsVEEsm9btOC7f0uH/wT0d?=
 =?us-ascii?Q?F4f1P3hy2aUQ7kZlGwqINLPUnE9oaXYM1M0yL78r0aF3MFxfWanpElzqeHYs?=
 =?us-ascii?Q?Ob8QgO0QiXL3RlV79shM93qFVRsytoLX3AJff5zJWIU3CPpUqFVZX5myeTLK?=
 =?us-ascii?Q?XDABukD1FmrlIuGPC8RQ65KSKgkrjfqVNaDvh7vqzxOTpTdg9WfFm83Z7vKM?=
 =?us-ascii?Q?WymIWN+FKPu25BerZEBslYylYBksoc2cuNDzC0lRs1/ocWL3bT+FO2Kkz0nM?=
 =?us-ascii?Q?K+C2cBWtSVI5ZlXhL9YGdIItG4oK7bu9dSE41VtpBBL5Z68sn5F9P8FIHIo2?=
 =?us-ascii?Q?1gUhh1ZpeqROSqiS4yU2H+ZZC9Pe2efiB9fP7HV0kXHk2+PaADfp30IzhzGy?=
 =?us-ascii?Q?jloVROWQKK05608vwgInaQEvvUNqg3IEpzphwth10gZwyEy14ihi6ugWDDFZ?=
 =?us-ascii?Q?4AXu+vf7RD7NcIfEHDOP8dkpiioa9krOnIcJsLK7WXut61UKP+lOk04Ofl9V?=
 =?us-ascii?Q?FAWZOmd+gNsrCuMPYbIdXwEdhG7vffyqO818ao39fRbBucqAQ8z7sL7s7vEK?=
 =?us-ascii?Q?wsm2SQamjuZ0zEe0oDFLyPDzfObJxYx83ZQpAClDfOffnFkYNkYrVmS4a7H8?=
 =?us-ascii?Q?QRq+Mlscod85iptJo/FcuGivvMQtNrWPRQYwWa0bipO05+CzVc04oozJe/dc?=
 =?us-ascii?Q?zBEIhEeyCDth5mIlsvAf10yKu4wD8WaeA+uJW8SGQkoud+2lew5xeJOZsghP?=
 =?us-ascii?Q?W2xISpurWvDIaiSdeOXiSRDVP9W/XJwz2nECsev/wTZg6dDIuMhzFYPDSfsi?=
 =?us-ascii?Q?Z7h6v62jtOI8tt/bIFoFKzhlkXgF2IhtaBEqBsqHQ1HbLe+F3u6UZd4W6xjf?=
 =?us-ascii?Q?ZN044V0ewI8zhIaWYLwul31HC+jngxIIw7Cl2hy8ZWkdqXAqNn0Cjzduk6yZ?=
 =?us-ascii?Q?8j7k2j5P+UxIKjqu6bTdG51zJt6TM/OfhNMZVCycX5FewX8aJChhMRkxm7cX?=
 =?us-ascii?Q?fvEZfuyNsjULcxyrwKCqKDjGMCRyqF/rz+ntfzT6govmJ2KihkNuxyaVLSTR?=
 =?us-ascii?Q?17bb1+NSGaN+ErDuHiB6KXhYq+IJw3SGMD680T7ZHsP8Tx4Fgghi5yB+jUTU?=
 =?us-ascii?Q?gA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 04c7df28-988a-4f8c-b588-08db24b3a5d6
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 17:43:40.6209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YEBenhIwdma4jDeVblGQsBD3ORS7RrXB+Aj7N7jlT5eSw+L57i6wRXo6afIAcM4mBDPDNAKcrVRjdrDg6oWdtWBuuTcKi3EGbp9vGXaAy8Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7668
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Greg Kroah-Hartman wrote:
> struct bus_type should never be modified in a sysfs callback as there is
> nothing in the structure to modify, and frankly, the structure is almost
> never used in a sysfs callback, so mark it as constant to allow struct
> bus_type to be moved to read-only memory.
> 
[..]
> Cc: Dan Williams <dan.j.williams@intel.com>
[..]
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 8ee6b6e2e2a4..66333cd6248e 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -1927,7 +1927,7 @@ bool schedule_cxl_memdev_detach(struct cxl_memdev *cxlmd)
>  EXPORT_SYMBOL_NS_GPL(schedule_cxl_memdev_detach, CXL);
>  
>  /* for user tooling to ensure port disable work has completed */
> -static ssize_t flush_store(struct bus_type *bus, const char *buf, size_t count)
> +static ssize_t flush_store(const struct bus_type *bus, const char *buf, size_t count)
>  {
>  	if (sysfs_streq(buf, "1")) {
>  		flush_workqueue(cxl_bus_wq);

For CXL:

Acked-by: Dan Williams <dan.j.williams@intel.com>