Date:   Tue, 14 Mar 2023 19:26:59 +0100
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
CC:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        Simon Horman <simon.horman@corigine.com>,
        <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] can: tcan4x5x: Introduce tcan4552/4553
Message-ID: <ZBC8cw/yLiv9L9OM@localhost.localdomain>
References: <20230314151201.2317134-1-msp@baylibre.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230314151201.2317134-1-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+afvQfoKXddudUbku7UdX2l1oD5yIiiZi4uRK5LPo3PAT1nqJZWBxLrWPvDy?=
 =?us-ascii?Q?btzbjPrlAQN2C19F/LbxgXRFhRQ/qbysy1veHJhspX2WkjCM55jLrxDSZGvQ?=
 =?us-ascii?Q?kcdjhTFKK9In+OzRjVilYMAGrkf8KJM2y8H8ek0vjav4uGk+xbJsEVdkqp3r?=
 =?us-ascii?Q?U2cD6gMfVpHpHDEl6idc9l9o1Djx3RWwa1tCTpSJZ2G30/6fVwFlPlq/GkpU?=
 =?us-ascii?Q?mUuFjGYfWBxogdulpmueywkSL6ub0UKazsUp4n1fiTJJMRYowTA0m/V0BVIQ?=
 =?us-ascii?Q?9nBquEFSEdd7/Hyloo93K2+UVFaxv+FgyMdGV4vUK90rmmeyed5EKBLvMaTS?=
 =?us-ascii?Q?YIzXRUPKuqXkEZMAJKJ/4aHE3J5sf4tp7TqePJLUhZmgEhImLvma3z/WXAKn?=
 =?us-ascii?Q?g4eu+N9NoErVEKt9zwqGUFlLy3r/jfLeiTCLNppc94m4mk6w/BjhEpF5KcQd?=
 =?us-ascii?Q?62CT0DacJb6w7un5S1dd8MQOcwCXCs9fn8nGqnw625+2mrvZsVQPzcSN2RVx?=
 =?us-ascii?Q?4L7ievOK37nKAtQ3pOKQUo+7/V+5SuG7JWI9YuFxsa+AJJo0ws3QHA3S5Oem?=
 =?us-ascii?Q?Ed5VLJQbOmnl5Kum0slM8SpR6ysHyItBegbVIy3ac3zZ9RIcnBUPeJyCCRPe?=
 =?us-ascii?Q?0IqThHWsXzbMmZC6M0qyUB6q/LpWA7FWx4knBo2B6Y7GRaQxwmCeYSq82pru?=
 =?us-ascii?Q?9oyg8rFwSSPcUkyIHfHg8EINISjF6I8FyBDt4T6HAhsIJJOvgyvh1xCMSl5A?=
 =?us-ascii?Q?WNKgzIjPQMg7ajVjddQu3QvaBftFzoc22+vCrXBw1hMVD7VFLDroPG5D6ukZ?=
 =?us-ascii?Q?b/ceRigbHKb0L9uCFTQfDD3M3HyXvIISOds2x6frJ11u4sbG0wHrsGhd3eVc?=
 =?us-ascii?Q?Qh8DpZXUt59Eri3zlvjlw2VoVZE9ijWe9wleHEm1H5gV3evMs4m4JZbwap0f?=
 =?us-ascii?Q?2AEQmwekn4vqSN4UxKw1U0EH/NxorbInbH7MxfYdaT2D7T6jwyQDbodH8CuN?=
 =?us-ascii?Q?ewyfEZFPMUDi4EePq03dOEBaxqxUuCB3Z8OxegmQGqJdw2wa6wqUuF+KPYMQ?=
 =?us-ascii?Q?R1us2CtHrEUMtsBAKEUUNB/7xwJl36EQO0zxV8+rNS4JFFPeAMT4cm6Xlq57?=
 =?us-ascii?Q?AdK64WpXBCE7NnpEgGR74Zt9gIqZGyEYiAOfvMPBD7LBr6uNNOC7LgivdeaW?=
 =?us-ascii?Q?ML8oot7VruAoKuS2vYeXTYqLxbAHLgVVxqHzqI0BDlcUi5qk4Vr3MusbBGUU?=
 =?us-ascii?Q?o+wuWH7iNGQ/sVyCDF6cCEFTwVnQ/LT+0Y+Tuel9o7paA6rLES5QsqliESQo?=
 =?us-ascii?Q?s/RFtxFsNrxQziQaqMwHWSYTg3faku6OO8HfCKRA7xAa/BWH5tRIV4gMoCZ0?=
 =?us-ascii?Q?OXmp8wWq0L2VPNoVSEfed0Yz2g9HQnxLu/ePblOAMBoTvaJLcuC0gw8sv+DC?=
 =?us-ascii?Q?3BSz1WSb0Zmi4q5tC5COrtlQ1o/e/3Qp0l9K16sZRFnFCwZoaHzN67kVjflT?=
 =?us-ascii?Q?yHCNDNl8dBTr0I43lWzVhiY5LdNEMVrYv8djzK4G1jXF2cJMpneMZV+6P9i1?=
 =?us-ascii?Q?fCqyleAcl/mvmQ/UNEWUCgIcZCKXDY7ZzZUXQsspUo/ekCusO83jXhibUfud?=
 =?us-ascii?Q?8w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ab2cc1f8-bc8c-45e6-1833-08db24b9b723
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 18:27:06.4855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rgMAVQw3wM3reBgGsnDzIOyGe5uZJhRuAzrGYKRPy1hpIo9wVuFGVvbq9wjJc4KqLQH9U5p4NmKL/NR/5v1VIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5067
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 04:11:56PM +0100, Markus Schneider-Pargmann wrote:
> Hi Marc and everyone,
> 
> This series introduces two new chips tcan-4552 and tcan-4553. The
> generic driver works in general but needs a few small changes. These are
> caused by the removal of wake and state pins.
> 
> I included two patches from the optimization series and will remove them
> from the optimization series. Hopefully it avoids conflicts and not
> polute the other series with tcan4552/4553 stuff.
> 
> Best,
> Markus
> 
> optimization series:
> https://lore.kernel.org/lkml/20221221152537.751564-1-msp@baylibre.com
> 
> Markus Schneider-Pargmann (5):
>   dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants
>   can: tcan4x5x: Remove reserved register 0x814 from writable table
>   can: tcan4x5x: Check size of mram configuration
>   can: tcan4x5x: Rename ID registers to match datasheet
>   can: tcan4x5x: Add support for tcan4552/4553
> 
>  .../devicetree/bindings/net/can/tcan4x5x.txt  |  11 +-
>  drivers/net/can/m_can/m_can.c                 |  16 +++
>  drivers/net/can/m_can/m_can.h                 |   1 +
>  drivers/net/can/m_can/tcan4x5x-core.c         | 122 ++++++++++++++----
>  drivers/net/can/m_can/tcan4x5x-regmap.c       |   1 -
>  5 files changed, 121 insertions(+), 30 deletions(-)
>

The logic and coding style looks OK to me, but CAN-specific stuff should
be reviewed by someone else.
Just one nitpick in the last patch.

Thanks,
Michal

For entire series:
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>

> -- 
> 2.39.2
>