From:   Luca Weiss <luca@z3ntu.xyz>
To:     Sakari Ailus <sakari.ailus@iki.fi>
Cc:     Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        devicetree@vger.kernel.org,
        Shunqian Zheng <zhengsq@rock-chips.com>,
        phone-devel@vger.kernel.org,
        Helen Koike <helen.koike@collabora.com>
Subject: Re: [PATCH] media: dt-bindings: ov2685: convert to dtschema
Date:   Tue, 14 Mar 2023 19:33:06 +0100
Message-ID: <5654018.DvuYhMxLoT@z3ntu.xyz>
In-Reply-To: <ZBBh9Euor7R24euV@valkosipuli.retiisi.eu>
References: <20230206-ov2685-dtschema-v1-1-9e4da3474c10@z3ntu.xyz>
 <2665862.mvXUDI8C0e@z3ntu.xyz> <ZBBh9Euor7R24euV@valkosipuli.retiisi.eu>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On Dienstag, 14. M=E4rz 2023 13:00:52 CET Sakari Ailus wrote:
> Hi Luca,
>=20
> On Thu, Feb 09, 2023 at 05:46:48PM +0100, Luca Weiss wrote:
> > +CC Helen Koike
> >=20
> > On Montag, 6. Februar 2023 22:50:08 CET Rob Herring wrote:
> > > On Mon, 06 Feb 2023 21:23:16 +0100, Luca Weiss wrote:
> > > > Convert the text-based dt-bindings to yaml.
> > > >=20
> > > > Changes from original txt:
> > > > * Take wording for various properties from other yaml bindings, this
> > > >=20
> > > >   removes e.g. volt amount from schema since it isn't really releva=
nt
> > > >   and the datasheet is a better source.
> > > >=20
> > > > * Don't make reset-gpios a required property since it can be tied to
> > > >=20
> > > >   DOVDD instead.
> > > >=20
> > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > > > ---
> > > >=20
> > > >  .../devicetree/bindings/media/i2c/ov2685.txt       |  41 ---------
> > > >  .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101
> > > >  +++++++++++++++++++++ MAINTAINERS
> > > > =20
> > > >  |   1 +
> > > > =20
> > > >  3 files changed, 102 insertions(+), 41 deletions(-)
> > >=20
> > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_ch=
eck'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >=20
> > > yamllint warnings/errors:
> > >=20
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > medi a/rockchip-isp1.example.dtb: camera@3c: 'clocks' is a required
> > > property From schema:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/i2c/ovti,ov2685.yaml
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/rockchip-isp1.example.dtb: camera@3c: 'clock-names' is a required
> > > property From schema:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/i2c/ovti,ov2685.yaml
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/rockchip-isp1.example.dtb: camera@3c: 'dvdd-supply' is a required
> > > property From schema:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/i2c/ovti,ov2685.yaml
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/rockchip-isp1.example.dtb: camera@3c: 'avdd-supply' is a required
> > > property From schema:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/i2c/ovti,ov2685.yaml
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/rockchip-isp1.example.dtb: camera@3c: 'dovdd-supply' is a required
> > > property From schema:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindin=
gs/
> > > med
> > > ia/i2c/ovti,ov2685.yaml
> >=20
> > Looks like rockchip-isp1.yaml uses very incomplete sensor examples in
> > their
> > binding example, which sort of makes sense since those bindings are
> > showing
> > the rockchip isp bindings and contain the bare minimum to show how a
> > sensor is connected in dt.
> >=20
> > Not sure how to solve this - ov2685 is also one of three sensors that a=
re
> > used very abbreviated there.
>=20
> Could these regulators be simply made optional?

Sure, from driver side it would just get dummy regulators instead.

Still the clocks are also missing in this rockchip example. Any suggestion=
=20
what to do about those?

Honestly I don't want to spend too much time on some ISP docs that I don't=
=20
really care about, would be nice if the maintainers of that could do that...

Regards
Luca