Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E76C05027 for ; Tue, 14 Mar 2023 19:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231285AbjCNTPr (ORCPT ); Tue, 14 Mar 2023 15:15:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjCNTPp (ORCPT ); Tue, 14 Mar 2023 15:15:45 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C12532E54; Tue, 14 Mar 2023 12:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Ja2ccLTGrrmxpDMpbSovaPevECIyWeUtOAUdEF9VuTg=; b=dfNbfJHyGAKHgATjZZSmYNKQec 5MiMlFh9zzdSZugyFProL5ZF6MiVtTJFFCmbE8E0oOoDd+i5oHP/lSh1BJpQwhkxFb3ODyFXi7L6m wvT5POBpgvy4yqkzyAXg2Jg+bsywn4X3i43XsopfDj6VShcwRT/6cq7CH8S0AdTmH2/Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pcA7P-007KAO-0f; Tue, 14 Mar 2023 20:15:31 +0100 Date: Tue, 14 Mar 2023 20:15:31 +0100 From: Andrew Lunn To: Klaus Kudielka Cc: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 3/4] net: dsa: mv88e6xxx: move call to mv88e6xxx_mdios_register() Message-ID: <4b5a5bc9-be4d-47b6-ab5a-6645fe99ab32@lunn.ch> References: <20230314182659.63686-1-klaus.kudielka@gmail.com> <20230314182659.63686-4-klaus.kudielka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314182659.63686-4-klaus.kudielka@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2023 at 07:26:58PM +0100, Klaus Kudielka wrote: > Call the rather expensive mv88e6xxx_mdios_register() at the beginning of > mv88e6xxx_setup(). This avoids the double call via mv88e6xxx_probe() > during boot. > > For symmetry, call mv88e6xxx_mdios_unregister() at the end of > mv88e6xxx_teardown(). > > Link: https://lore.kernel.org/lkml/449bde236c08d5ab5e54abd73b645d8b29955894.camel@gmail.com/ > Suggested-by: Andrew Lunn > Signed-off-by: Klaus Kudielka Reviewed-by: Andrew Lunn Andrew