MIME-Version: 1.0
References: <20230225115144.31212-1-W_Armin@gmx.de> <d2660362-dc25-e75f-394b-1997bd062933@gmx.de>
In-Reply-To: <d2660362-dc25-e75f-394b-1997bd062933@gmx.de>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 14 Mar 2023 20:49:55 +0100
Message-ID: <CAJZ5v0itUSnsxgdvw39e+YZWe4jTHA1fLjw3HZSKHTkp+eLHwQ@mail.gmail.com>
Subject: Re: [PATCH v2 0/4] ACPI: SBS: Fix various issues
To:     Armin Wolf <W_Armin@gmx.de>
Cc:     rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sun, Mar 12, 2023 at 6:15 PM Armin Wolf <W_Armin@gmx.de> wrote:
>
> Am 25.02.23 um 12:51 schrieb Armin Wolf:
>
> > On my Acer Travelmate 4002WLMi, the system locks up upon
> > suspend/shutdown. After a lot of research, it turned out
> > that the sbs module was the culprit. The driver would not
> > correctly mask out the value used to select a battery using
> > the "Smart Battery Selector" (subset of the "Smart Battery Manager").
> > This accidentally caused a invalid power source to be selected,
> > which was automatically corrected by the selector. Upon
> > notifing the host about the corrected power source, some batteries
> > would be selected for re-reading, causing a endless loop.
> > This would lead to some workqueues filling up, which caused the
> > lockup upon suspend/shutdown.
> >
> > The first three patches fix a stacktrace on module removal caused
> > by some locking issues. The last patch finally fixes the
> > suspend/shutdown issues.
> >
> > As a side note: This was the first machine on which i installed Linux,
> > to finally fixing this took ~5 years of tinkering.
>
> What is the status of this patchset? Should i use a SRCU notifier chain
> for the query notifiers? I would really like to see this getting fixed,
> as it prevents me from using linux on this machine.

I'm not entirely convinced about the query notifiers idea TBH.