Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754718AbXIQRKW (ORCPT ); Mon, 17 Sep 2007 13:10:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751681AbXIQRKK (ORCPT ); Mon, 17 Sep 2007 13:10:10 -0400 Received: from gateway-1237.mvista.com ([63.81.120.158]:21867 "EHLO gateway-1237.mvista.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbXIQRKI (ORCPT ); Mon, 17 Sep 2007 13:10:08 -0400 Subject: Re: [ofa-general] [PATCH] [WORKAROUND] CONFIG_PREEMPT_RT and ib_umad_close() issue From: Daniel Walker To: Roland Dreier Cc: John Blackwood , linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, general@lists.openfabrics.org, Sven-Thorsten Dietrich In-Reply-To: References: <46EE9BCC.1040301@ccur.com> Content-Type: text/plain Date: Mon, 17 Sep 2007 10:07:56 -0700 Message-Id: <1190048876.3253.41.camel@imap.mvista.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 24 On Mon, 2007-09-17 at 08:56 -0700, Roland Dreier wrote: > > When using OFED-1.2.5 based infiniband kernel modules on 2.6.22 based > > kernels with the Ingo Molnar CONFIG_PREEMPT_RT applied, then commands > > such as ibnetdiscvoer, smpquery, sminfo, etc. will hang. The problem > > is with the downgrade_write() rw semaphore usage in the > > ib_umad_close() routine. > > Can you give a few more details on how PREEMPT_RT changes locking > rules (or just exposes existing bugs maybe?) so that the > downgrade_write() causes the issue? I would like to fix this cleanly > but I don't really understand what the problem is. the read/write semaphore functionality is basically reduced to just a binary semaphore , i.e. one reader, or one writer . I think the BUG(); in downgrade_write() is likely part of a removal plan for downgrade_write() (that's just a guess tho) Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/