Message-ID: <b134781b-f28f-57c0-3ebc-9dba28d51074@linaro.org>
Date:   Tue, 14 Mar 2023 16:23:35 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net 0/4] net: ipa: minor bug fixes
Content-Language: en-US
From:   Alex Elder <elder@linaro.org>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     caleb.connolly@linaro.org, mka@chromium.org, evgreen@chromium.org,
        andersson@kernel.org, quic_cpratapa@quicinc.com,
        quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com,
        quic_subashab@quicinc.com, elder@kernel.org,
        netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230314203841.1574172-1-elder@linaro.org>
In-Reply-To: <20230314203841.1574172-1-elder@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/14/23 3:38 PM, Alex Elder wrote:
> The four patches in this series fix some errors, though none of them
> cause any compile or runtime problems.
> 
> The first changes the files included by "drivers/net/ipa/reg.h" to
> ensure everything it requires is included with the file.  It also
> stops unnecessarily including another file.  The prerequisites are
> apparently satisfied other ways, currently.
> 
> The second adds two struct declarations to "gsi_reg.h", to ensure
> they're declared before they're used later in the file.  Again, it
> seems these declarations are currently resolved wherever this file
> is included.
> 
> The third removes register definitions that were added for IPA v5.0
> that are not needed.  And the last updates some validity checks for
> IPA v5.0 registers.  No IPA v5.0 platforms are yet supported, so the
> issues resolved here were never harmful.

Sorry, it seems I used the wrong hashes in some
of my "Fixes" tags.  I will post v2 of this series
tomorrow.

					-Alex


> 					-Alex
> 
> Alex Elder (4):
>    net: ipa: reg: include <linux/bug.h>
>    net: ipa: add two missing declarations
>    net: ipa: kill FILT_ROUT_CACHE_CFG IPA register
>    net: ipa: fix some register validity checks
> 
>   drivers/net/ipa/gsi_reg.c |  9 ++++++++-
>   drivers/net/ipa/gsi_reg.h |  4 ++++
>   drivers/net/ipa/ipa_reg.c | 28 ++++++++++++++++++----------
>   drivers/net/ipa/ipa_reg.h | 21 ++++++---------------
>   drivers/net/ipa/reg.h     |  3 ++-
>   5 files changed, 38 insertions(+), 27 deletions(-)
>