From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        Alison Schofield <alison.schofield@intel.com>
Cc:     outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only
Date:   Tue, 14 Mar 2023 22:31:21 +0100
Message-ID: <3376017.mWHT0XuiSF@suse>
In-Reply-To: <ZBDcfNOXmGeN2tlb@aschofie-mobl2>
References: <ZA9mThZ7NyRrQAMX@khadija-virtual-machine> <ZBDcfNOXmGeN2tlb@aschofie-mobl2>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On marted=EC 14 marzo 2023 21:43:40 CET Alison Schofield wrote:
> On Mon, Mar 13, 2023 at 11:07:10PM +0500, Khadija Kamran wrote:
> > Module parameter, read_timeout, can only be set at the loading time. As
> > it can only be modified once, initialize read_timeout once in the probe
> > function.
> > As a result, only use read_timeout as the last argument in
> > wait_event_interruptible_timeout() call.
> >=20
> > Same goes for write_timeout.
> >=20
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > ---
>=20
> Looks like this is [PATCH v5] and needs a changelog.
>
Alison,

In fact, this is only the second patch that addresses Greg's suggested=20
refactoring.=20

Khadija moved from v3 of "staging: axis-fifo: remove tabs to align argument=
s"=20
to v4 of this completely independent patch. And then back to v1, because (a=
t=20
the time of v4) I pointed out to her that she had started working on a proj=
ect=20
that has a completely different purpose than the previous one.

The best course of action would have been to ask Greg to drop the previous=
=20
patches and then reset the numbering of the new job to v1. Unfortunately I =
did=20
not pay attention to how she then managed the numbering following my=20
observation.

What would be the best course of action at this point?

=46abio