Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-221-gec32977366-fm-20230306.001-gec329773
Mime-Version: 1.0
Message-Id: <e19fd8bc-5944-409d-a4a1-3a3d53691634@app.fastmail.com>
In-Reply-To: <4ac809d2-3924-3839-479f-0b4be9f18a1f@linaro.org>
References: <20230314163201.955689-1-arnd@kernel.org>
 <4ac809d2-3924-3839-479f-0b4be9f18a1f@linaro.org>
Date:   Tue, 14 Mar 2023 22:40:26 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Christian Lamparter" <chunkeey@googlemail.com>,
        "Kalle Valo" <kvalo@kernel.org>
Cc:     "Linus Walleij" <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux-OMAP <linux-omap@vger.kernel.org>,
        "Tony Lindgren" <tony@atomide.com>,
        "Aaro Koskinen" <aaro.koskinen@iki.fi>,
        "Felipe Balbi" <balbi@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        =?UTF-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        "Russell King" <linux@armlinux.org.uk>,
        "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Johannes Berg" <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree
Content-Type: text/plain
Precedence: bulk

On Tue, Mar 14, 2023, at 20:57, Krzysztof Kozlowski wrote:
> On 14/03/2023 17:30, Arnd Bergmann wrote:
>
> Please split bindings to separate patch.
>
>>  MAINTAINERS                                   |  1 +
>>  arch/arm/boot/dts/omap2.dtsi                  |  4 ++
>>  arch/arm/boot/dts/omap2420-n8x0-common.dtsi   | 12 ++++
>
> DTS as well...

ok

>> +maintainers:
>> +  - Johannes Berg <johannes@sipsolutions.net>
>> +  - Christian Lamparter <chunkeey@web.de>
>> +
>> +description: |
>
> You can drop '|'.

ok

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - st,stlc4550
>> +      - st,stlc4560
>> +      - isil,p54spi
>> +      - cnxt,3110x
>
> Order above entries by name.

ok

>> +
>> +  power-gpios:
>
> If this is GPIO driving some power pin, then it should be
> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml)

As far as I can tell, it's the opposite: the gpio turns the power on
in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown,
if you think that's better, but I don't think that is how it was
meant.

>> +examples:
>> +  - |
>> +   gpio {
>
> Align example with above |, so four spaces. Or better indent entire
> example with four spaces.

Ok, that makes it much more readable.

>> +     gpio-controller;
>> +     #gpio-cells = <1>;
>> +     #interupt-cells = <1>;
>> +   };
>
> Drop "gpio" node. It's not needed for the example.

ok.

>> +   spi {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      wifi@0 {
>> +        reg = <0>;
>> +        compatible = "st,stlc4560";
>
> compatible before reg.

ok.

       Arnd