IronPort-SDR: 9LK/OnKFXhDxpSWjwqkooV7sFxNzq+2qoQZhYrGUodtnbJA6R+P0PJmiNEmk3kIKwL4U8tnr3W
 t2WXAAODoq6qv9FR0SA/j0q5e8RP/Bef8+7CBMafbTPLkB4/vKJpwsN7Ll5uaxrDGKtGvwIVLj
 6FdcRKhmA/hoTSi8BaBQ026RyiFN1a8IbQGs86wXoEuEoH5kd1TeY0WFJWpEVFiTTlRHFnYeT4
 fJf7+gRC7Z5KdsZYOxbLvi0rkN02YEJ2n4H1wIxzdmaVTSl1rf0Q/pwMaH+IdTpz+92lQRBzN9
 qYs=
IronPort-SDR: 6MYjDq52A/XP5aJczbvRMXwlOISf1ALWvUqv+wVPQWd8jq1Lm9ubc8uLa6pR6331Lg5FCITMn+
 n/+ZhdLXwCIFjhO8T2p5bBG1ch4fXfvufWw/1BsE2MekatobLQDojqQuNHW1yKVekRDW7EL/f5
 rz8RlH6BoR/I/lB4Koo99e1VfegbD2xn7uLgIJBB/VM8/Zm+KvUp76xUW5lRH/0EXu9sEs1ovO
 DL6Z9UzgMcJIqr/0qb8hszPyn7SqE0siYUPySoYkTsZkt/2SDnI+gCO74yAYxRp1f91N9NjMc8
 8v8=
WDCIronportException: Internal
Message-ID: <7453aba3-9f2a-4723-3039-a85652883b48@opensource.wdc.com>
Date:   Wed, 15 Mar 2023 10:23:38 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v3 02/38] ata: add HAS_IOPORT dependencies
Content-Language: en-US
To:     Niklas Schnelle <schnelle@linux.ibm.com>,
        Arnd Bergmann <arnd@arndb.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-pci@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
        linux-ide@vger.kernel.org
References: <20230314121216.413434-1-schnelle@linux.ibm.com>
 <20230314121216.413434-3-schnelle@linux.ibm.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230314121216.413434-3-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/14/23 21:11, Niklas Schnelle wrote:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.

I do not see HAS_IOPORT=y defined anywhere in 6.3-rc. Is that in linux-next ?
There is a HAS_IOPORT_MAP, but I guess it is different.

> 
> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
>  drivers/ata/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b56fba76b43f..e5e67bdc2dff 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -342,6 +342,7 @@ endif # HAS_DMA
>  
>  config ATA_SFF
>  	bool "ATA SFF support (for legacy IDE and PATA)"
> +	depends on HAS_IOPORT
>  	default y
>  	help
>  	  This option adds support for ATA controllers with SFF

-- 
Damien Le Moal
Western Digital Research