To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, rafael@kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Alex Shi <alexs@kernel.org>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Alexandre Bounine <alex.bou9@gmail.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dexuan Cui <decui@microsoft.com>,
        Eric Dumazet <edumazet@google.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Hannes Reinecke <hare@suse.de>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Hu Haowen <src.res@email.cn>,
        Ilya Dryomov <idryomov@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Iwona Winiarska <iwona.winiarska@intel.com>,
        Jakub Kicinski <kuba@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Jonathan Corbet <corbet@lwn.net>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Paolo Abeni <pabeni@redhat.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Wei Liu <wei.liu@kernel.org>,
        Yanteng Si <siyanteng@loongson.cn>
Subject: Re: [PATCH 23/36] driver core: bus: mark the struct bus_type for
 sysfs callbacks as constant
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq11qlq68x5.fsf@ca-mkp.ca.oracle.com>
References: <20230313182918.1312597-1-gregkh@linuxfoundation.org>
        <20230313182918.1312597-23-gregkh@linuxfoundation.org>
Date:   Tue, 14 Mar 2023 22:33:57 -0400
In-Reply-To: <20230313182918.1312597-23-gregkh@linuxfoundation.org> (Greg
        Kroah-Hartman's message of "Mon, 13 Mar 2023 19:29:05 +0100")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HG/8jrsICkQ0wUbcI8qhXOuTyN7s9JGI1X9SGnZlfwNZCrAHOfKqk5q/CJFJ?=
 =?us-ascii?Q?D5axyonhkXuZGlm5AHVfGZF3lrrTEuklrjCpehzSGWEiJRLT7ie4liXSX2xa?=
 =?us-ascii?Q?xcdy6x0qp/vpZuHXwgi7ie7ikByKJnnY2wolbH37ro1N0YWtutlGVMcyX26m?=
 =?us-ascii?Q?MZrheNhwO9FpmwUjvKHXJFq9qFVyAbkv+MqIhN9X9+c4XND6hMWCtC0tHLpg?=
 =?us-ascii?Q?wZgDnw5cru7TfNl8Fus2Pkj1vayiBJQ2+e0Alc0Y+uzg6FXgrMD28G0M4zCS?=
 =?us-ascii?Q?eFOKYuaoxboclHzBDA5wC+pvYCDAKZE6s7xDMTBgkK4ZS4g358wgqwx1Uaby?=
 =?us-ascii?Q?mD3DQ2Z682S4BiksJc3ibykvSpcNT9IAm+UEq9nc0qbyaZxjMgwjxOJkVhIw?=
 =?us-ascii?Q?o31vattm2tXhFz9RxXPHEnLbNlQ0ZGcjHQT7jl9OcGJkTHsKdl5OQ1p70BAA?=
 =?us-ascii?Q?D8zrCg1Jwz2j02VTSxxbaOtxBlpCiY8yUZwCU9+Zf+YcjXSOARRPS+brQJjh?=
 =?us-ascii?Q?LHfz5YI6sFKFYcxeDoDE9Vn4PG4S/NLqIWN7zVAqVoT74iCBiQyHMYGRKcn9?=
 =?us-ascii?Q?mEGXFlyTYOmBr7KqnAB80CqTCi02c8naAyMaZLxoWAHi5jYJpGuTErVTeoYF?=
 =?us-ascii?Q?fRD4dIieX+b/ULfippNEEHDjmilea4PNLhFitRCpsFe7RN6CmVRjjLBLEOeZ?=
 =?us-ascii?Q?1YHZJd9eNEv0i2bIVBNQ67PRsA6aHPEHvBehRcaZM3E3jGcpLNgYZmXNiLNA?=
 =?us-ascii?Q?qSqa/H9DQsozEkGb8i0jcvq9iIFO6Q3gWnGT4ggZcPkbL65xC9Im5fZpk5av?=
 =?us-ascii?Q?QxRQE6Ad5fZi5qWe8SHgT63ij6cBgovlUb0f2rLusscSMCKv6iZMA5wqsWlo?=
 =?us-ascii?Q?6EmLZCYDiBYrMoD94c7TlzOhkLFgQOc7gH8SiV7VDp/OmAknAk+LNkrDkxH1?=
 =?us-ascii?Q?7D0oE1lmugR+DRxTuJTVTEDzUA21wavWPneUsJ4//SszxBwE7WLnMtff7mKq?=
 =?us-ascii?Q?b+q9QBwdz0A+Q3yIKPz/h8t6xlcD2plwNo91wVfvhdHAj5SAzYXidPRDY53f?=
 =?us-ascii?Q?L0x1nvgWw1fCrYwK16zHM24VO/kEZ78L7fGTKH8ZZ2F58U3dnTnhm8zuBtfD?=
 =?us-ascii?Q?+CCAwIZW1bPVjwwFhNUm9iH0TLYcEFlN9Ie9p1E6Z7ZMBijMPZNdp7hxUpvh?=
 =?us-ascii?Q?myc8pOiHYbWFQRAAypD5Lk5obBwz9xIrpYRj+WatAfEQKG4FfLXsMAH8N5US?=
 =?us-ascii?Q?hDBejWJV/aDMgKk7s2StG7E1tcchVQ0XpD6LSLwHJNi31HMq6af9oel+/7Nu?=
 =?us-ascii?Q?1z59Cj6NmEaH9ZtiQv8T74AcfEJiZMqJIRqXa80fXKK82llzimpUEUz+CXyz?=
 =?us-ascii?Q?/xwKMjkwPVA8Sjj4DHPgdNQbSvoiVe2lFYHTfmFFVKu01dHYaicgqxSadAjC?=
 =?us-ascii?Q?cghAsmQPaz9M+qAFrF3ZnkW0/9ZINusYbjY8mU5gc2T+ePjPLFRZJo208WQs?=
 =?us-ascii?Q?cmkaL9oQ1Of+Nr3hmew4S6Kd5u1r6ZaPM0WpXmloGuoOmcl8YD5WHum2OIOG?=
 =?us-ascii?Q?k6BT5XRdakA0uPXfrGGi49jpISpVHAJkJDr5jmQN2flQ7Eo7AJuFhDLTdzJx?=
 =?us-ascii?Q?9w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?aBvbqmeBe0nYM0er9Ly+3+0WhFxNtqqZ1oJb/vhX7B6vnaJ/QoS7xpeVVZYX?=
 =?us-ascii?Q?WwhZO8gC9ncHcThDE7/lycuzSyRJfO463aCRGxMa/dZPe0ZVcgDq5B2v5kj4?=
 =?us-ascii?Q?GgoNHiC1+RRT5x8NOmysds1K6V9RPyd8glMrGGdl5DIzm7kZSS3eJxeVthzM?=
 =?us-ascii?Q?lxuRpEY9TDv8+HOeq9LkoH7pI6+cKlYs2xULqgfk8UoOLDJAcNjA7ixBOc5o?=
 =?us-ascii?Q?eB57kAkwHD9KNXxwN4tRgcPuotjk7XJilr6+jeZsIOh4uCRRf9q7PnQdGoLe?=
 =?us-ascii?Q?8FzATEWduz7aaz7O+JqFeBdSuAXZaCW4Dkj7AIS2Z4N2DAabKCfFvO3uHpx1?=
 =?us-ascii?Q?CWnhF3rAsP+PAPyXgZlvV6tOjYzb0BH1tOsOsP/jxtJlZhJt3yMLRAZ6b3TZ?=
 =?us-ascii?Q?5ABJNj7PswWP5j74rMGW0dUQD6yPY/pmrvPlCVPXpWdxxOS6k8D10zYn0SqX?=
 =?us-ascii?Q?SSqkt8wi2EPpSj/WqI8KpcpuMkqReUGOs/4M+TlR/4NgZBwCkHAoLTK2kb8d?=
 =?us-ascii?Q?606yJldnzvlpR6BKdXYvtudy3upaZBCKTr8FmfXRaUUY2oEAegOkIhqi4EW8?=
 =?us-ascii?Q?DOXpr0cJH3Bx2QYLyvqScWOs2M5tnxomknDTq8Q4hOgoj4CbRHdh/E8fkV0F?=
 =?us-ascii?Q?3ZcKI9Q2o9cVvqs5cyYZyl0hYftZOHrbfRMjDWi2yrpJgYTnhDdFDNlJL0Rw?=
 =?us-ascii?Q?QTzlE/0JDZNRVMpNvDiKSrJWddoG9BEK3r505mBWF5IgxHdzXMHXUkBlhPui?=
 =?us-ascii?Q?w1GtgkzqPFohRZGkXdFE3Gnt1JsF8JOVMDPt6NcP2KjB75mqmdyHRI6FtyMT?=
 =?us-ascii?Q?/DzSDwAUmoNuGteOw9sS6iTyYGSWi/5xUuWhfIH5F0+vOq+u2ZOFHX9AAQ/r?=
 =?us-ascii?Q?D8Rp3Be2ObED9vh9KtgWFtj+jGRqY2M/9vloJwkBeulckJzl7ydm76kTmPnb?=
 =?us-ascii?Q?DwMNsC1p2TByAAwPpq3/bQ2HfVXCC6kw+2HrRUqZ6gZ7BCeqiepBsZy/9SuN?=
 =?us-ascii?Q?Ns4yIPYvoa/PwIw74fUYm14dpdaK1FO+Qa+Hf6DRPH6Jo8jOP2QzWcxPT1U3?=
 =?us-ascii?Q?73KfehrAlwyaK3f9KlS3VRLFwp/U6Hsp4sMpEAfQMgSxsLYz0OJeVLdV3e4t?=
 =?us-ascii?Q?LuXG7R9XfcGrH5DBc7C0YVpW35XeF0erCLYSGwePNdSU4FFuYModCi7Njipf?=
 =?us-ascii?Q?XcBAds8s3ZRZa5WMPTREIaVgQwNypGbabhZX1PGetk+uMj0nGACdE0Gh0+KE?=
 =?us-ascii?Q?PWnEi4/I+SNoHJTdEysGHtBIkCEAVqVdhX3QEZQ5QXj6VsNz8ebZimEgI95S?=
 =?us-ascii?Q?/u4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8e945a2-4795-482a-7484-08db24fdbb7f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 02:33:59.8605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ZrWPk3bL5NwoUJLyHsQPNBnEGPznbvavXV5aZBJYnWpKJN2uVcoZz0M9pvgKMyCIwosfo7MqM+0F4N+tzE6+wBWuklqI6U7wLGMyiFNtKY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6292
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-14_16,2023-03-14_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=950 phishscore=0
 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2302240000 definitions=main-2303150020
X-Proofpoint-ORIG-GUID: 4JAfoCR29WxjuNjZhdWrSkxoRMG4C5nx
X-Proofpoint-GUID: 4JAfoCR29WxjuNjZhdWrSkxoRMG4C5nx
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Greg,

> struct bus_type should never be modified in a sysfs callback as there
> is nothing in the structure to modify, and frankly, the structure is
> almost never used in a sysfs callback, so mark it as constant to allow
> struct bus_type to be moved to read-only memory.

Acked-by: Martin K. Petersen <martin.petersen@oracle.com> # scsi

-- 
Martin K. Petersen	Oracle Linux Engineering